Files
substrate/internal/serverboot/serverboot.go
T
Krisztian F acf5c12df4 (otel): onboard ateom to the OTLP metrics path (#562)
This PR wires `ateom` into the OTLP push path so it can emit metrics,
and unblock unblocking
https://github.com/agent-substrate/substrate/issues/550

- serverboot: new InitMetricsPushOnly (OTLP periodic reader, no
Prometheus pull surface) for binaries that run no metrics HTTP server
- ateom-gvisor + ateom-microvm call it, so the existing otelgrpc server
handler now feeds `rpc.server.*` to the collector
- atecontroller propagates its `OTEL_EXPORTER_OTLP_ENDPOINT` +
`OTEL_RESOURCE_ATTRIBUTES` into the ateom worker pods
- fixes ateom telemetry not reaching the collector 
- e2e: metrics suite asserts an `ateom` service reaches the collector

cc. @git286 

- [x] Tests pass
- [ ] Appropriate changes to documentation are included in the PR
2026-07-29 10:25:37 -04:00

244 lines
8.8 KiB
Go

// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Package serverboot collects the startup boilerplate shared by the
// long-running substrate server binaries (ateapi, atelet, ateom-gvisor,
// ateom-microvm): slog wiring, OTel tracer + meter providers, a Prometheus +
// /readyz HTTP surface, and a couple of small helpers for startup fail-fast.
package serverboot
import (
"context"
"errors"
"fmt"
"io"
"log/slog"
"net/http"
"os"
"sync/atomic"
"github.com/agent-substrate/substrate/internal/contextlogging"
"github.com/google/uuid"
"github.com/prometheus/client_golang/prometheus/promhttp"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/exporters/prometheus"
"go.opentelemetry.io/otel/propagation"
sdkmetric "go.opentelemetry.io/otel/sdk/metric"
"go.opentelemetry.io/otel/sdk/resource"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.40.0"
)
// InitLogger sets the global slog logger to a JSON handler wrapped in
// contextlogging.NewHandler, writing to os.Stdout. Call once at process start.
func InitLogger() {
InitLoggerWithWriter(os.Stdout)
}
// InitLoggerWithWriter is InitLogger with an explicit destination. Use it to share
// one synchronized writer between the runtime logger and a separate writer (e.g.
// ateom's actor-log forwarder) so their lines don't interleave.
func InitLoggerWithWriter(w io.Writer) {
slog.SetDefault(slog.New(contextlogging.NewHandler(slog.NewJSONHandler(w, nil))))
}
// serviceInstanceID is generated once so the tracer and meter resources share it.
var serviceInstanceID = uuid.NewString()
// newResource builds the resource shared by the tracer and meter providers.
// WithFromEnv is last so OTEL_* env vars override the defaults.
func newResource(ctx context.Context, serviceName string) (*resource.Resource, error) {
res, err := resource.New(ctx,
resource.WithTelemetrySDK(),
// Must track the schema version the SDK's own detectors emit, else the
// merge drops the schema URL with ErrSchemaURLConflict (tolerated below).
resource.WithSchemaURL(semconv.SchemaURL),
resource.WithAttributes(
semconv.ServiceName(serviceName),
semconv.ServiceInstanceID(serviceInstanceID),
),
resource.WithFromEnv(),
)
if errors.Is(err, resource.ErrPartialResource) || errors.Is(err, resource.ErrSchemaURLConflict) {
slog.WarnContext(ctx, "partial telemetry resource", slog.Any("err", err))
} else if err != nil {
return nil, err
}
return res, nil
}
// TracingOptions configures InitTracing.
type TracingOptions struct {
// ServiceName is required; populates resource.semconv ServiceName.
ServiceName string
// Sampler is required. ateapi typically uses ParentBased(AlwaysSample);
// atelet/ateom-gvisor use ParentBased(NeverSample).
Sampler sdktrace.Sampler
}
// InitTracing registers a global TracerProvider with the given options
// and the TraceContext text-map propagator.
func InitTracing(ctx context.Context, opts TracingOptions) (*sdktrace.TracerProvider, error) {
if opts.ServiceName == "" {
return nil, fmt.Errorf("TracingOptions.ServiceName is required")
}
res, err := newResource(ctx, opts.ServiceName)
if err != nil {
return nil, fmt.Errorf("create tracer resource: %w", err)
}
tpOpts := []sdktrace.TracerProviderOption{
sdktrace.WithResource(res),
sdktrace.WithSampler(opts.Sampler),
}
exporter, err := otlptracegrpc.New(ctx,
// GKE managed traces doesn't support validating the TLS certs of the collector.
otlptracegrpc.WithInsecure(),
)
if err != nil {
return nil, fmt.Errorf("create OTLP exporter: %w", err)
}
tpOpts = append(tpOpts, sdktrace.WithBatcher(exporter))
tp := sdktrace.NewTracerProvider(tpOpts...)
otel.SetTracerProvider(tp)
otel.SetTextMapPropagator(propagation.TraceContext{})
return tp, nil
}
// InitMetrics registers a global MeterProvider with both a Prometheus
// reader (exposed via StartMetricsServer's /metrics handler) and an
// OTLP periodic reader.
func InitMetrics(ctx context.Context, serviceName string) (*sdkmetric.MeterProvider, error) {
if serviceName == "" {
return nil, fmt.Errorf("serviceName is required")
}
promExporter, err := prometheus.New()
if err != nil {
return nil, fmt.Errorf("create Prometheus metric exporter: %w", err)
}
return newMeterProvider(ctx, serviceName, promExporter)
}
// InitMetricsPushOnly is InitMetrics without the Prometheus reader, for binaries
// that run no metrics HTTP server (ateom): a pull reader would collect into a
// registry nothing serves.
func InitMetricsPushOnly(ctx context.Context, serviceName string) (*sdkmetric.MeterProvider, error) {
return newMeterProvider(ctx, serviceName)
}
func newMeterProvider(ctx context.Context, serviceName string, extraReaders ...sdkmetric.Reader) (*sdkmetric.MeterProvider, error) {
if serviceName == "" {
return nil, fmt.Errorf("serviceName is required")
}
otlpExporter, err := otlpmetricgrpc.New(ctx, otlpmetricgrpc.WithInsecure())
if err != nil {
return nil, fmt.Errorf("create OTLP metric exporter: %w", err)
}
res, err := newResource(ctx, serviceName)
if err != nil {
return nil, fmt.Errorf("create metric resource: %w", err)
}
opts := []sdkmetric.Option{
sdkmetric.WithResource(res),
sdkmetric.WithReader(sdkmetric.NewPeriodicReader(otlpExporter)),
}
for _, r := range extraReaders {
opts = append(opts, sdkmetric.WithReader(r))
}
mp := sdkmetric.NewMeterProvider(opts...)
otel.SetMeterProvider(mp)
return mp, nil
}
// Fatal logs msg + err and exits with status 1. For startup-time
// fail-fast where there's no recovery path.
func Fatal(ctx context.Context, msg string, err error) {
slog.ErrorContext(ctx, msg, slog.Any("err", err))
os.Exit(1)
}
// ShutdownProvider invokes the OTel provider's Shutdown and logs any
// error. Designed to be deferred from main():
//
// defer serverboot.ShutdownProvider("TracerProvider", tp.Shutdown)
func ShutdownProvider(name string, shutdown func(context.Context) error) {
if err := shutdown(context.Background()); err != nil {
slog.Error("Failed to shutdown "+name, slog.Any("err", err))
}
}
// Readiness is a predicate for process readiness. The zero value
// reports ready. Calling MarkNotReady flips it permanently to not ready,
// which causes /readyz to start returning "Service Unavailable" (503).
type Readiness struct {
notReady atomic.Bool
}
// MarkNotReady makes /readyz return 503 from now on.
func (r *Readiness) MarkNotReady() { r.notReady.Store(true) }
// Ready reports whether /readyz returns 200.
func (r *Readiness) Ready() bool { return !r.notReady.Load() }
// MetricsServerOptions configures StartMetricsServer.
type MetricsServerOptions struct {
// Addr is the TCP listen address (e.g. ":9090").
Addr string
// Readiness, if non-nil, enables a /readyz handler: 200 while
// Ready, 503 after MarkNotReady. A zero-value Readiness never
// flips, giving a static 200 for binaries with no drain sequence.
// Nil serves no /readyz at all.
Readiness *Readiness
// EnableHealthz adds an always-200 /healthz for liveness probes,
// which must keep succeeding while a draining server fails /readyz.
EnableHealthz bool
}
// StartMetricsServer runs an HTTP server exposing /metrics (Prometheus)
// and optionally /readyz and /healthz. Blocks until http.ListenAndServe
// returns; designed to be `go`-launched.
func StartMetricsServer(ctx context.Context, opts MetricsServerOptions) {
slog.InfoContext(ctx, "Starting metrics HTTP server", slog.String("addr", opts.Addr))
if err := http.ListenAndServe(opts.Addr, metricsMux(opts)); err != nil {
slog.Error("Failed to start prometheus metrics server", slog.Any("err", err))
}
}
// metricsMux builds the handler for StartMetricsServer; split out so
// tests can exercise the endpoints without binding a port.
func metricsMux(opts MetricsServerOptions) *http.ServeMux {
mux := http.NewServeMux()
mux.Handle("/metrics", promhttp.Handler())
if opts.Readiness != nil {
mux.HandleFunc("/readyz", func(w http.ResponseWriter, _ *http.Request) {
if !opts.Readiness.Ready() {
http.Error(w, "draining", http.StatusServiceUnavailable)
return
}
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte("ok"))
})
}
if opts.EnableHealthz {
mux.HandleFunc("/healthz", func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte("ok"))
})
}
return mux
}