chore: update flash attention warnings (#805 )

fix: accept NULL in sd_img_gen_params_t::input_id_images_path (#809 )
2026-10-03 02:38:25 +08:00 · 2025-09-10 21:38:21 +08:00 · 2025-09-10 21:22:55 +08:00
1 changed files with 11 additions and 2 deletions
@@ -345,7 +345,7 @@ public:
            }
            if (sd_version_is_sd3(version)) {
                if (sd_ctx_params->diffusion_flash_attn) {
-                    LOG_WARN("flash attention in this diffusion model is currently unsupported!");
+                    LOG_WARN("flash attention in this diffusion model is currently not implemented!");
                }
                cond_stage_model = std::make_shared<SD3CLIPEmbedder>(clip_backend,
                                                                     offload_params_to_cpu,
@@ -362,6 +362,15 @@ public:
                    }
                }
                if (is_chroma) {
+                    if (sd_ctx_params->diffusion_flash_attn && sd_ctx_params->chroma_use_dit_mask) {
+                        LOG_WARN(
+                            "!!!It looks like you are using Chroma with flash attention. "
+                            "This is currently unsupported. "
+                            "If you find that the generated images are broken, "
+                            "try either disabling flash attention or specifying "
+                            "--chroma-disable-dit-mask as a workaround.");
+                    }
+
                    cond_stage_model = std::make_shared<T5CLIPEmbedder>(clip_backend,
                                                                        offload_params_to_cpu,
                                                                        model_loader.tensor_storages_types,
@@ -2361,7 +2370,7 @@ sd_image_t* generate_image(sd_ctx_t* sd_ctx, const sd_img_gen_params_t* sd_img_g
                                                        sd_img_gen_params->control_strength,
                                                        sd_img_gen_params->style_strength,
                                                        sd_img_gen_params->normalize_input,
-                                                        sd_img_gen_params->input_id_images_path,
+                                                        SAFE_STR(sd_img_gen_params->input_id_images_path),
                                                        ref_latents,
                                                        sd_img_gen_params->increase_ref_index,
                                                        concat_latent,
Author	SHA1	Message	Date
Wagner Bruna	abb36d66b5	chore: update flash attention warnings (#805 )	2025-09-10 21:38:21 +08:00
Wagner Bruna	ff4fdbb88d	fix: accept NULL in sd_img_gen_params_t::input_id_images_path (#809 )	2025-09-10 21:22:55 +08:00