Resolve corpus promises 7503 and 7504 with an explicit undefined

tsgo checks JavaScript calls to an untyped Promise's resolve against its
one parameter, so resolve() with no argument is an error there while
tsc-ts accepts it. The two programs pass undefined, which both checkers
accept and which settles the promise the same way.
This commit is contained in:
Chris Tate
2026-10-24 14:33:02 -05:00
parent 53baad4ebe
commit 55740d094a
2 changed files with 8 additions and 8 deletions
@@ -58,7 +58,7 @@ async function run(name) {
queueMicrotask(() => log.push(`${name} microtask`));
pipeline(src, sink(name, objectMode), (err) => {
log.push(`${name} done ${err ? err.code ?? err.message : err}`);
resolve();
resolve(undefined);
});
log.push(`${name} after call`);
});
@@ -72,7 +72,7 @@ await new Promise((resolve) =>
src2,
new Transform({ transform(c, _e, cb) { cb(null, c.toString().toUpperCase()); } }),
sink("transform"),
(err) => { log.push(`transform done ${err}`); resolve(); },
(err) => { log.push(`transform done ${err}`); resolve(undefined); },
),
);
const src3 = new Set(["f1", "f2"]);
@@ -81,7 +81,7 @@ await new Promise((resolve) =>
src3,
async function* (source) { for await (const c of source) yield c + "!"; },
sink("fnstage"),
(err) => { log.push(`fnstage done ${err}`); resolve(); },
(err) => { log.push(`fnstage done ${err}`); resolve(undefined); },
),
);
// promises form
@@ -92,11 +92,11 @@ log.push("promises resolved");
function* bad() { yield "ok"; throw new Error("source failed"); }
const src5 = bad();
await new Promise((resolve) =>
pipeline(src5, sink("bad"), (err) => { log.push(`bad done ${err && err.message}`); resolve(); }),
pipeline(src5, sink("bad"), (err) => { log.push(`bad done ${err && err.message}`); resolve(undefined); }),
);
// a source of non-string values into a byte-mode writable
const src6 = [1, 2];
await new Promise((resolve) =>
pipeline(src6, sink("numbers"), (err) => { log.push(`numbers done ${err && err.code}`); resolve(); }),
pipeline(src6, sink("numbers"), (err) => { log.push(`numbers done ${err && err.code}`); resolve(undefined); }),
);
console.log(log.join("\n"));
@@ -30,7 +30,7 @@ await new Promise((resolve) => {
});
pipeline(pick(counted("f", 5)), dst, (err) => {
console.log("fail done", err && err.message);
resolve();
resolve(undefined);
});
});
@@ -45,7 +45,7 @@ await new Promise((resolve) => {
});
pipeline(pick(counted("b", 3)), dst, (err) => {
console.log("slow done", err);
resolve();
resolve(undefined);
});
});
@@ -85,6 +85,6 @@ await new Promise((resolve) => {
pipeline(
pick(new Map([["k", 1]])),
new Writable({ objectMode: true, write(c, _e, cb) { console.log("map write", JSON.stringify(c)); cb(); } }),
(err) => { console.log("map done", err); resolve(); },
(err) => { console.log("map done", err); resolve(undefined); },
);
});