trending/scriptc
1
0
Fork 0
mirror of https://github.com/vercel-labs/scriptc.git synced 2026-11-02 07:43:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Keep a key-order divergence in the coverage fixture

Browse Source 
The fixture's Point literals now each record their own key order, so
they no longer diverge. The fixture adds a spread that sets an optional
key its source lacks, which keeps the type's declaration order, so SC6002
still reports the literal written in another order.
This commit is contained in:
Chris Tate
2026-10-22 06:39:06 -05:00
parent ce47b9bad9
commit 4cb46d6472
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/coverage-fixtures/divergences.ts
+7 -3
View File
@@ -20,14 +20,18 @@ console.log(tagged.label);
const view: Labeled = tagged;
console.log(view === tagged);
// Key order: values of one type are built in two orders and the program
// observes them, so the type keeps its declaration order.
// Key order: values of one type are built in two orders, and a spread sets
// an optional key its source lacks, so the values cannot record their own
// orders and the type keeps its declaration order.
interface Point {
x: number;
y: number;
label?: string;
}
const point: Point = { y: 1, x: 2 };
console.log(JSON.stringify(point), JSON.stringify({ x: 3, y: 4 }));
const other: Point = { x: 3, y: 4 };
const labeled: Point = { ...point, label: "p" };
console.log(JSON.stringify(point), JSON.stringify(other), JSON.stringify(labeled));
// Text outside the built-in collation compares by code point natively.
console.log(["б", "а"].sort((p, q) => p.localeCompare(q)).join(","), "яблоко".localeCompare("груша"));
tests/harness/__snapshots__/coverage-divergences.txt
+5 -5
View File
@@ -1,7 +1,7 @@
scriptc coverage tests/coverage-fixtures/divergences.ts
statements analyzed 18
compile statically 18 (100%)
statements analyzed 20
compile statically 20 (100%)
in dynamic tier 1 (operate on values typed only at runtime; --explain-dynamic lists them)
fully static — all analyzed statements compile to native code.
@@ -14,11 +14,11 @@ scriptc coverage tests/coverage-fixtures/divergences.ts
at tests/coverage-fixtures/divergences.ts:20:23
hint: declare the parameter or binding with the value's full type ('Tagged'), or make the shape a class — class instances keep their identity when passed as a base class
×1 SC6002 this object's keys enumerate as 'x, y' natively (the declaration order of 'Point') but as 'y, x' under Node (insertion order), and the program observes the order (JSON.stringify, Object.keys, for-in …
at tests/coverage-fixtures/divergences.ts:29:22
at tests/coverage-fixtures/divergences.ts:31:22
hint: write the properties in the declaration order of 'Point' (or reorder the declaration to match how objects are built)
×1 SC6003 localeCompare over 'яблоко' compares characters outside the built-in collation (Latin letters, digits, punctuation and symbols) by code point natively, while Node applies ICU's full collation
at tests/coverage-fixtures/divergences.ts:33:70
at tests/coverage-fixtures/divergences.ts:37:70
hint: results agree with Node for Latin-script text; for other scripts compare explicitly (for example by code point with < and >) so both runtimes agree
×1 SC6004 this 'Circle' reaches a cast to the unrelated class 'Square' in the callee: natively the checked cast throws a TypeError when it executes, while Node reads the members structurally
at tests/coverage-fixtures/divergences.ts:48:20
at tests/coverage-fixtures/divergences.ts:52:20
hint: narrow with 'instanceof Square' before casting, or cast to a base class or interface both classes share