trending/scriptc
1
0
Fork 0
mirror of https://github.com/vercel-labs/scriptc.git synced 2026-10-30 07:14:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Copy only stable descriptor fields when registering a cycle type (#971)

Browse Source
This commit is contained in:
Chris Tate
2026-10-14 07:46:29 -05:00
committed by GitHub
parent 9246c45126 5cfcc0d565
commit 0fe19bd3ed
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/runtime/src/scr_cycle.c
+4 -2
View File
@@ -278,8 +278,10 @@ uint32_t scr_cyc_register(ScrCycType *type) {
if (id) return id;
uint32_t fresh = __atomic_fetch_add(&scr_cyc_ntypes, 1, __ATOMIC_RELAXED);
if (fresh >= SCR_CYC_MAX_TYPES) scr_trap("scriptc: too many cycle-collected types\n");
scr_cyc_types[fresh] = *type;
scr_cyc_types[fresh].id = fresh;
/* Copy the fields another thread never writes; `id` may be published
* concurrently by a racing registration. */
scr_cyc_types[fresh] = (ScrCycType){
.trace = type->trace, .free_fn = type->free_fn, .kind = type->kind, .id = fresh};
__atomic_thread_fence(__ATOMIC_RELEASE);
uint32_t expected = 0;
if (__atomic_compare_exchange_n(&type->id, &expected, fresh, false, __ATOMIC_ACQ_REL,