trending/scriptc
1
0
Fork 0
mirror of https://github.com/vercel-labs/scriptc.git synced 2026-10-28 06:53:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Group record-flow references by symbol once per name (#1690)

Browse Source
This commit is contained in:
Chris Tate
2026-10-21 12:22:44 -05:00
committed by GitHub
parent ef5fc0fb2c 293facfdf6
commit 0739b81f7a
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler/src/frontend/lowering/runtime-optional-records.ts
+16 -8
View File
@@ -81,7 +81,9 @@ export class RecordFlowClasses {
/** Identifiers by name; symbols resolve only for the names of slots and
* functions, so the scan asks the checker about few nodes. */
private readonly names = new Map<string, ts.Identifier[]>();
private readonly references = new Map<ts.Symbol, ts.Identifier[]>();
/** The identifiers of each name grouped by the symbol they resolve to,
* built on the first reference query for that name. */
private readonly references = new Map<string, Map<ts.Symbol, ts.Identifier[]>>();
/** Names written as shorthand properties (`{ p }`): the checker resolves
* those to the property, so a binding of that name stays open. */
private readonly shorthandNames = new Set<string>();
@@ -349,14 +351,20 @@ export class RecordFlowClasses {
/** The identifiers that name `symbol`, its declaration included. */
private referencesOf(symbol: ts.Symbol): readonly ts.Identifier[] {
let list = this.references.get(symbol);
if (!list) {
list = (this.names.get(ts.symbolName(symbol)) ?? []).filter(
(node) => this.host.symbolOf(node) === symbol,
);
this.references.set(symbol, list);
const name = ts.symbolName(symbol);
let bySymbol = this.references.get(name);
if (!bySymbol) {
bySymbol = new Map();
for (const node of this.names.get(name) ?? []) {
const resolved = this.host.symbolOf(node);
if (!resolved) continue;
const list = bySymbol.get(resolved);
if (list) list.push(node);
else bySymbol.set(resolved, [node]);
}
this.references.set(name, bySymbol);
}
return list;
return bySymbol.get(symbol) ?? [];
}
private collectFunctions(): void {