trending/scriptc
1
0
Fork 0
mirror of https://github.com/vercel-labs/scriptc.git synced 2026-11-01 07:33:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Test two inline-cache entries inline at dynamic-tier property sites (#2367)

Browse Source
This commit is contained in:
Chris Tate
2026-10-26 21:20:00 -05:00
committed by GitHub
parent 807f5f6712 6beed6cb01
commit 06bd585a53
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/compiler/src/backend/llvm/js-ic.ts
+7 -4
View File
@@ -84,10 +84,13 @@ function kindIs(host: Host, d: string, kind: number, yes: string, no: string): v
* inline made polymorphic reads 7-10% faster (the design prototype's W2/W3)
* and monomorphic method code no faster, for 65-225 more bytes per site;
* the prototype hit made method-heavy code 3-6% faster for 15-90 bytes.
* So a site tests entry 0, own or prototype, and its probe does the rest.
* (0 makes every access probe: with a runtime built with SCR_JS_VERIFY,
* that probes every access.) */
const INLINE_WAYS: number = 1;
* Two entries cover the common two-layout site (object literals of one
* record built in two key orders): on bench:runtime's dynamic-properties
* they made the run 13% faster than one entry, and 26% faster without its
* class instances; four were no faster than two. So a site tests entries
* 0 and 1, own or prototype, and its probe does the rest. (0 makes every access probe: with a runtime
* built with SCR_JS_VERIFY, that probes every access.) */
const INLINE_WAYS: number = 2;
const INLINE_PROTO = true;
/** The address of slot `slot` of layout-mode object `d`. */
packages/compiler/test/js-ic-emission.test.ts
+4
View File
@@ -50,6 +50,10 @@ console.log(read(o), at(dyn([5, 6]), 1), call(o), o.n);
);
expect(body(llvm, "read")).toContain("@scr_js_get_probe(");
expect(body(llvm, "write")).toContain("@scr_js_store_probe(");
// Reads and writes test the first two entries inline: the second
// starts 40 bytes into the record.
for (const site of ["read", "write"])
expect(body(llvm, site)).toMatch(/getelementptr inbounds i8, ptr @sc_js_ic_\d+, i64 40$/m);
expect(body(llvm, "at")).toContain("@scr_js_keyed_probe(");
expect(body(llvm, "call")).toContain("@scr_js_load_probe(");
// A compound assignment stores its number result from the jsval: an