fix(coding-agent): support -- end-of-options, closes #7269

This commit is contained in:
Armin Ronacher
2026-08-22 23:16:40 +02:00
parent cec3a91c02
commit 74786a748f
2 changed files with 49 additions and 1 deletions
+10 -1
View File
@@ -79,7 +79,16 @@ export function parseArgs(args: string[]): Args {
for (let i = 0; i < args.length; i++) {
const arg = args[i];
if (arg === "--help" || arg === "-h") {
if (arg === "--") {
for (const positionalArg of args.slice(i + 1)) {
if (positionalArg.startsWith("@")) {
result.fileArgs.push(positionalArg.slice(1));
} else {
result.messages.push(positionalArg);
}
}
break;
} else if (arg === "--help" || arg === "-h") {
result.help = true;
} else if (arg === "--version" || arg === "-v") {
result.version = true;
@@ -0,0 +1,39 @@
import { fauxAssistantMessage } from "@earendil-works/pi-ai";
import { afterEach, describe, expect, it } from "vitest";
import { parseArgs } from "../../../src/cli/args.ts";
import { createHarness, getUserTexts, type Harness } from "../harness.ts";
describe("issue #7269 CLI end-of-options delimiter", () => {
let harness: Harness | undefined;
afterEach(() => {
harness?.cleanup();
harness = undefined;
});
it.each(["- summarize the following points for me", "--answer my question briefly"])(
"passes %j as a prompt after --",
async (prompt) => {
const parsed = parseArgs(["-ne", "--no-session", "-p", "--", prompt]);
expect(parsed.messages).toEqual([prompt]);
expect(parsed.unknownFlags.size).toBe(0);
expect(parsed.diagnostics).toEqual([]);
harness = await createHarness();
harness.setResponses([fauxAssistantMessage("ok")]);
await harness.session.prompt(parsed.messages[0]);
expect(getUserTexts(harness)).toEqual([prompt]);
},
);
it("stops parsing options while retaining @file handling", () => {
const parsed = parseArgs(["--unknown-flag", "value", "--", "--provider", "openai", "-c", "@prompt.md"]);
expect(parsed.unknownFlags.get("unknown-flag")).toBe("value");
expect(parsed.provider).toBeUndefined();
expect(parsed.continue).toBeUndefined();
expect(parsed.messages).toEqual(["--provider", "openai", "-c"]);
expect(parsed.fileArgs).toEqual(["prompt.md"]);
expect(parsed.diagnostics).toEqual([]);
});
});