trending/dbx
1
0
Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-02 02:34:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(sql-schema): gate duckdb column rename on sidecar feature

Browse Source
This commit is contained in:
Sachin Chaudhary
2026-10-01 02:11:51 +08:00
committed by GitHub
parent 0f7e2b6c6c
commit bdb28cd6f4
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/dbx-sql-schema/src/table_structure_sql/column_alter.rs
+1
View File
@@ -1029,6 +1029,7 @@ pub(super) fn build_sqlite_existing_column_sql(
statements
}
#[cfg(feature = "duckdb-sidecar")]
pub(super) fn build_duckdb_existing_column_sql(table: &str, column: &EditableStructureColumn) -> Vec<String> {
let Some(original) = &column.original else {
return Vec::new();
crates/dbx-sql-schema/src/table_structure_sql/columns.rs
+8 -6
View File
@@ -1,12 +1,13 @@
#[cfg(feature = "duckdb-sidecar")]
use super::column_alter::build_duckdb_existing_column_sql;
use super::column_alter::build_transwarp_existing_column_clause;
use super::column_alter::{
build_clickhouse_existing_column_sql, build_dameng_existing_column_sql, build_doris_existing_column_sql,
build_duckdb_existing_column_sql, build_h2_existing_column_sql, build_informix_existing_column_sql,
build_iris_existing_column_sql, build_mysql_existing_column_clause, build_oracle_like_existing_column_sql,
build_oscar_existing_column_sql, build_postgres_existing_column_sql, build_questdb_existing_column_sql,
build_sqlite_existing_column_sql, build_sqlserver_existing_column_sql, build_xugu_existing_column_sql,
dameng_drops_identity, has_column_extra_change, has_existing_column_attribute_change,
validate_dameng_existing_identity_change,
build_h2_existing_column_sql, build_informix_existing_column_sql, build_iris_existing_column_sql,
build_mysql_existing_column_clause, build_oracle_like_existing_column_sql, build_oscar_existing_column_sql,
build_postgres_existing_column_sql, build_questdb_existing_column_sql, build_sqlite_existing_column_sql,
build_sqlserver_existing_column_sql, build_xugu_existing_column_sql, dameng_drops_identity,
has_column_extra_change, has_existing_column_attribute_change, validate_dameng_existing_identity_change,
};
use super::column_format::{
column_definition, has_dameng_identity, is_dameng_identity_compatible_type, is_mysql_character_data_type,
@@ -296,6 +297,7 @@ pub(super) fn build_column_sql(options: &TableStructureSqlOptions, warnings: &mu
warnings,
)),
StructureDialect::Sqlite => statements.extend(build_sqlite_existing_column_sql(&table, column, warnings)),
#[cfg(feature = "duckdb-sidecar")]
StructureDialect::DuckDb => statements.extend(build_duckdb_existing_column_sql(&table, column)),
StructureDialect::Questdb => statements.extend(build_questdb_existing_column_sql(&table, column)),
_ => warnings.push(format!("Editing existing columns is not supported for {database_label} yet.")),