trending/codebase-memory-mcp
1
0
Fork 0
mirror of https://github.com/DeusData/codebase-memory-mcp.git synced 2026-11-05 08:23:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(daemon): error-code the pid-query rejection and log server-side refusals

Browse Source 
The classified smoke run pinned the Windows client loop on
GetNamedPipeServerProcessId failing against a successfully opened pipe
(step=server_pid_query, 12 hits in one 30 s window). Two data points
were still missing: the Win32 error of that exact call (and whether the
function pointer resolved at all), and the server-side view - the
daemon's accept path disconnects unverifiable clients silently, which a
client experiences as exactly this failure. Both now log.

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This commit is contained in:
Martin Vogel
2026-07-18 21:06:57 +02:00
parent a6a17e3a24
commit e28ae9a73d
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/daemon/ipc.c
+15 -2
View File
@@ -5192,6 +5192,10 @@ int cbm_daemon_ipc_accept(cbm_daemon_ipc_listener_t *listener, uint32_t timeout_
return result;
}
if (!win_pipe_client_is_current_user(listener->pipe)) {
/* The daemon-side twin of the client's server_identity log: without
* it a server-initiated disconnect is indistinguishable from a
* client-side failure in the field. */
cbm_log_warn("daemon.accept.client_rejected", "stage", "client_identity");
(void)DisconnectNamedPipe(listener->pipe);
(void)CloseHandle(listener->pipe);
listener->pipe = INVALID_HANDLE_VALUE;
@@ -5220,8 +5224,17 @@ static bool win_pipe_server_is_current_user(HANDLE pipe) {
"GetNamedPipeServerProcessId")
: NULL;
ULONG process_id = 0;
if (!get_server_pid || !get_server_pid(pipe, &process_id) || process_id == 0) {
cbm_log_warn("daemon.client.server_identity", "step", "server_pid_query");
if (!get_server_pid) {
cbm_log_warn("daemon.client.server_identity", "step", "pid_fn_missing");
return false;
}
if (!get_server_pid(pipe, &process_id) || process_id == 0) {
char error_text[16];
(void)snprintf(error_text, sizeof(error_text), "%lu", (unsigned long)GetLastError());
char pid_text[16];
(void)snprintf(pid_text, sizeof(pid_text), "%lu", (unsigned long)process_id);
cbm_log_warn("daemon.client.server_identity", "step", "server_pid_query", "error",
error_text, "pid", pid_text);
return false;
}
HANDLE process = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, FALSE, process_id);