trending/codebase-memory-mcp
1
0
Fork 0
mirror of https://github.com/DeusData/codebase-memory-mcp.git synced 2026-11-03 08:03:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): report dirty freshness for traces

Browse Source 
Add canonical-only dirty freshness metadata to trace_path responses so traced callers/callees stay visible while pending dirty files are disclosed.

Cover the behavior with an MCP regression test and validate with focused trace canary, full MCP suite, source-safety, diff hygiene, and product build logs under /private/tmp.

Signed-off-by: Andrew Hundt <ATHundt@gmail.com>
This commit is contained in:
Andrew Hundt
2026-07-03 16:48:54 -04:00
parent 5eeeed8b1a
commit 509ce5352d
2 changed files with 65 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mcp/mcp.c
+8
View File
@@ -5014,6 +5014,14 @@ static char *handle_trace_path(cbm_mcp_server_t *srv, const char *args) {
(do_outbound && tr_out.linkrank_stale) ||
(do_inbound && tr_in.linkrank_stale),
false);
int dirty_pending = 0;
int dirty_overlay_ready = 0;
if (get_dirty_file_counts(store, project, &dirty_pending, &dirty_overlay_ready)) {
add_dirty_file_freshness_counts(doc, root, dirty_pending, dirty_overlay_ready);
add_response_warning(doc, root,
"trace_path reads canonical graph rows; dirty file changes may "
"be absent until overlay or reindex completes.");
}
if (srv->session_project[0])
yyjson_mut_obj_add_str(doc, root, "session_project", srv->session_project);
tests/test_mcp.c
+57
View File
@@ -1577,6 +1577,62 @@ TEST(tool_trace_path_warns_on_stale_rank_views) {
PASS();
}
TEST(tool_trace_path_reports_dirty_metadata_as_canonical_only) {
cbm_mcp_server_t *srv = cbm_mcp_server_new(NULL);
ASSERT_NOT_NULL(srv);
cbm_store_t *st = cbm_mcp_server_store(srv);
ASSERT_NOT_NULL(st);
const char *proj = "trace-dirty";
cbm_mcp_server_set_project(srv, proj);
ASSERT_EQ(cbm_store_upsert_project(st, proj, "/tmp/trace-dirty"), CBM_STORE_OK);
cbm_node_t root = {.project = proj,
.label = "Function",
.name = "root",
.qualified_name = "trace-dirty.root",
.file_path = "root.c"};
cbm_node_t callee = {.project = proj,
.label = "Function",
.name = "callee",
.qualified_name = "trace-dirty.callee",
.file_path = "callee.c"};
int64_t root_id = cbm_store_upsert_node(st, &root);
int64_t callee_id = cbm_store_upsert_node(st, &callee);
ASSERT_GT(root_id, 0);
ASSERT_GT(callee_id, 0);
cbm_edge_t edge = {.project = proj,
.source_id = root_id,
.target_id = callee_id,
.type = "CALLS"};
ASSERT_GT(cbm_store_insert_edge(st, &edge), 0);
cbm_dirty_file_state_t dirty = {.project = proj,
.rel_path = "root.c",
.observed_hash = "trace-dirty-hash",
.observed_generation = 12,
.source = CBM_STORE_DIRTY_SOURCE_EXPLICIT_REINDEX,
.status = CBM_STORE_DIRTY_STATUS_PENDING};
ASSERT_EQ(cbm_store_upsert_dirty_file(st, &dirty), CBM_STORE_OK);
char *resp = cbm_mcp_server_handle(
srv, "{\"jsonrpc\":\"2.0\",\"id\":65,\"method\":\"tools/call\","
"\"params\":{\"name\":\"trace_path\","
"\"arguments\":{\"function_name\":\"root\",\"project\":\"trace-dirty\","
"\"direction\":\"outbound\"}}}");
ASSERT_NOT_NULL(resp);
char *inner = extract_text_content(resp);
ASSERT_NOT_NULL(inner);
ASSERT_NOT_NULL(strstr(inner, "callee"));
ASSERT_NOT_NULL(strstr(inner, "\"warnings\""));
ASSERT_NOT_NULL(strstr(inner, "trace_path reads canonical graph rows"));
ASSERT_TRUE(has_dirty_freshness_counts(inner, 1, 0));
free(inner);
free(resp);
cbm_mcp_server_free(srv);
PASS();
}
TEST(tool_delete_project_not_found) {
cbm_mcp_server_t *srv = cbm_mcp_server_new(NULL);
@@ -3934,6 +3990,7 @@ SUITE(mcp) {
RUN_TEST(tool_trace_path_ambiguous);
RUN_TEST(tool_trace_path_prefers_definition);
RUN_TEST(tool_trace_path_warns_on_stale_rank_views);
RUN_TEST(tool_trace_path_reports_dirty_metadata_as_canonical_only);
RUN_TEST(tool_delete_project_not_found);
RUN_TEST(tool_get_architecture_empty);
RUN_TEST(tool_get_architecture_emits_populated_sections);