fix(browser): preserve default Chrome arg order

This commit is contained in:
Growth Radar QA
2026-08-31 13:15:27 -07:00
parent d379a32887
commit df2701e524
2 changed files with 34 additions and 1 deletions
+2 -1
View File
@@ -907,7 +907,8 @@ class BrowserProfile(BrowserConnectArgs, BrowserLaunchPersistentContextArgs, Bro
"""Get the list of all Chrome CLI launch args for this profile (compiled from defaults, user-provided, and system-specific)."""
if isinstance(self.ignore_default_args, list):
default_args = set(CHROME_DEFAULT_ARGS) - set(self.ignore_default_args)
ignored_default_args = set(self.ignore_default_args)
default_args = [arg for arg in CHROME_DEFAULT_ARGS if arg not in ignored_default_args]
elif self.ignore_default_args is True:
default_args = []
elif not self.ignore_default_args:
+32
View File
@@ -0,0 +1,32 @@
from browser_use.browser.profile import CHROME_DEFAULT_ARGS, BrowserProfile
def test_get_args_keeps_default_order_when_ignoring_default_args(tmp_path):
profile = BrowserProfile(
user_data_dir=tmp_path,
ignore_default_args=['--disable-popup-blocking', '--no-default-browser-check'],
enable_default_extensions=False,
)
args = profile.get_args()
expected_defaults = [
arg for arg in CHROME_DEFAULT_ARGS if arg not in {'--disable-popup-blocking', '--no-default-browser-check'}
]
actual_defaults = [arg for arg in args if arg in CHROME_DEFAULT_ARGS]
assert actual_defaults == expected_defaults
assert '--disable-popup-blocking' not in args
assert '--no-default-browser-check' not in args
def test_get_args_keeps_default_order_with_default_ignored_args(tmp_path):
profile = BrowserProfile(user_data_dir=tmp_path, enable_default_extensions=False)
args = profile.get_args()
ignored_default_args = profile.ignore_default_args if isinstance(profile.ignore_default_args, list) else []
expected_defaults = [arg for arg in CHROME_DEFAULT_ARGS if arg not in ignored_default_args]
actual_defaults = [arg for arg in args if arg in CHROME_DEFAULT_ARGS]
assert actual_defaults == expected_defaults