mirror of
https://github.com/ankitects/anki.git
synced 2026-10-02 05:24:38 +08:00
user1823
1f51c40a05
## Linked issue (required) Fixes https://github.com/ankitects/anki/issues/5285 - Follow up to https://github.com/ankitects/anki/pull/5277 Also allows forgetting curve to appear when the memory states are absent. ## Summary / motivation (required) The frontend was inferring FSRS state from indirect signals such as memoryState or desiredRetention. This can be incorrect and it's better to rely on the actual bool from the Rust backend instead. ## Steps to reproduce (required, use N/A if not applicable) 1. Have a card with no memory states and no desired retention but FSRS enabled (e.g. by setting "Ignore reviews before" to a date later than its latest review) 2. Open card info 3. Ease is shown and forgetting curve is not shown. ## How to test (required) On repeating the above steps, - ease is not shown - forgetting curve is shown (to show the forgetting curve, you need to follow the steps with a memory-state-less card from an earlier Anki version by changing deck. If you set "ignore reviews before" to a later date, there will be no forgetting curve) ### Checklist (minimum) - [x] I ran `./ninja check` or an equivalent relevant check locally. - [x] I added or updated tests when the change is non-trivial or behavior changed. ### Details One test is removed because it's not possible to have memory states with FSRS disabled. ## Before / after behavior (optional) <!-- For bugfixes: behavior before vs after. For other types: N/A or a short note. --> ## Risk / compatibility / migration (optional) <!-- Breaking changes, rollout notes, or N/A for small / low-risk PRs --> ## UI evidence (required for visual changes; otherwise N/A) <!-- Screenshot or short video --> ## Scope - [x] This PR is focused on one change (no unrelated edits).
Anki
This repo contains the source code for the computer version of Anki.
About
Anki is a spaced repetition program. Please see the website to learn more.
Getting Started
Contributing
Want to contribute to Anki? Check out the Contribution Guidelines.
For more information on building and developing, please see Development.
Contributors
The following people have contributed to Anki: CONTRIBUTORS
Anki Betas
If you'd like to try development builds of Anki but don't feel comfortable building the code, please see Anki betas.
License
Anki's license: LICENSE