Files
a69c9190b4 fix(install): relative global bin link and clean failed downloads (#2675)
* fix(install): link global bin entry relatively

Volta installs into a staging directory and renames it afterwards, which left the absolute bin symlink dangling. A relative link survives the rename.

* fix(install): keep failed downloads out of bin/

The fallback download created the binary before checking the HTTP status, so a 404 left a 0-byte executable that the launcher then ran (ENOEXEC). Download to a temp file, rename on success, remove on failure, follow 301/302/307/308, and skip empty candidates when locating the binary.

Co-Authored-By: Lykin <293371022+xunguangzlj-cloud@users.noreply.github.com>
Co-Authored-By: hassnalalshaikh <51247426+hassnalalshaikh@users.noreply.github.com>

* fixup! fix(install): keep failed downloads out of bin/

* fix(install): name empty binaries in the launcher error and bound postinstall tests

---------

Co-authored-by: Lykin <293371022+xunguangzlj-cloud@users.noreply.github.com>
Co-authored-by: hassnalalshaikh <51247426+hassnalalshaikh@users.noreply.github.com>
2026-11-19 20:11:11 -03:00

131 lines
4.4 KiB
JavaScript

/**
* Locates the native agent-browser binary for this host.
*
* Shared by bin/agent-browser.js and scripts/postinstall.js. Kept free of
* subprocesses because the launcher imports it on every wrapped invocation.
*/
import { existsSync, statSync } from 'fs';
import { createRequire } from 'module';
import { dirname, join } from 'path';
import { platform, arch } from 'os';
// Uses the process report instead of spawning `ldd`, which costs a shell
// startup on every call.
export function hostLibc() {
if (platform() !== 'linux') return null;
process.report.excludeNetwork = true;
const report = process.report.getReport();
if (report.header.glibcVersionRuntime) return 'glibc';
if (report.sharedObjects.some((path) => /(?:^|\/)ld-musl-|libc\.musl-/.test(path))) return 'musl';
// A statically linked Node has no loaded libc in its process report.
const loaderArch = arch() === 'arm64' ? 'aarch64' : 'x86_64';
return existsSync(`/lib/ld-musl-${loaderArch}.so.1`) ? 'musl' : 'glibc';
}
/**
* Describes where the binary for a host can live:
* - packageName/file: the per-platform optional dependency and its executable
* - binaryName: the file name used inside this package's bin/ directory
* (postinstall download, source builds and linked installs)
* - candidates: bin/ file names to try, in order
*/
export function nativeTarget(os = platform(), cpuArch = arch(), libc = os === 'linux' ? hostLibc() : null) {
let archKey;
switch (cpuArch) {
case 'x64':
case 'x86_64':
archKey = 'x64';
break;
case 'arm64':
case 'aarch64':
archKey = 'arm64';
break;
default:
return null;
}
switch (os) {
case 'darwin':
return {
packageName: `@agent-browser/cli-darwin-${archKey}`,
file: 'agent-browser',
binaryName: `agent-browser-darwin-${archKey}`,
candidates: [`agent-browser-darwin-${archKey}`],
};
case 'linux': {
const musl = libc === 'musl';
const binaryName = `agent-browser-linux-${musl ? 'musl-' : ''}${archKey}`;
return {
packageName: `@agent-browser/cli-linux-${archKey}-${musl ? 'musl' : 'gnu'}`,
file: 'agent-browser',
binaryName,
candidates: [binaryName],
};
}
case 'win32':
// Prefer a source-built native ARM64 executable when present. Otherwise,
// use the published x64 binary through Windows' built-in emulation.
return {
packageName: '@agent-browser/cli-win32-x64-msvc',
file: 'agent-browser.exe',
binaryName: 'agent-browser-win32-x64.exe',
candidates:
archKey === 'arm64'
? ['agent-browser-win32-arm64.exe', 'agent-browser-win32-x64.exe']
: ['agent-browser-win32-x64.exe'],
};
default:
return null;
}
}
// A zero-byte file is a leftover of a failed download, never a runnable binary.
function isUsableFile(path) {
try {
return statSync(path).size > 0;
} catch {
return false;
}
}
// Returns the platform package binary path whether or not it exists, or null.
function platformPackageBinaryPath(packageRoot, target) {
try {
const require = createRequire(join(packageRoot, 'package.json'));
const manifest = require.resolve(`${target.packageName}/package.json`);
return join(dirname(manifest), 'bin', target.file);
} catch {
return null;
}
}
// Returns existing zero-byte candidates, so callers can name them.
export function emptyNativeBinaries(packageRoot, target) {
const paths = target.candidates.map((name) => join(packageRoot, 'bin', name));
const packaged = platformPackageBinaryPath(packageRoot, target);
if (packaged) paths.push(packaged);
return paths.filter((path) => existsSync(path) && !isUsableFile(path));
}
// Returns the binary inside the installed platform package, or null.
export function platformPackageBinary(packageRoot, target) {
try {
const require = createRequire(join(packageRoot, 'package.json'));
const manifest = require.resolve(`${target.packageName}/package.json`);
const binary = join(dirname(manifest), 'bin', target.file);
return isUsableFile(binary) ? binary : null;
} catch {
return null;
}
}
// Returns the binary to run: a file already in bin/, else the platform package.
export function findNativeBinary(packageRoot, target) {
for (const name of target.candidates) {
const binary = join(packageRoot, 'bin', name);
if (isUsableFile(binary)) return binary;
}
return platformPackageBinary(packageRoot, target);
}