trending/OpenShell
1
0
Fork 0
mirror of https://github.com/NVIDIA/OpenShell.git synced 2026-10-28 07:13:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): e2e gate must verify work actually ran, not just top-level success (#926)

Browse Source
This commit is contained in:
Piotr Mlocek
2026-04-23 08:28:27 -07:00
committed by GitHub
parent d0a29b64eb
commit 89dd10bd4e
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/e2e-gate-check.yml
+19 -7
View File
@@ -84,18 +84,30 @@ jobs:
exit 1
fi
run_id=$(jq -r '.id' <<< "$latest")
status=$(jq -r '.status' <<< "$latest")
conclusion=$(jq -r '.conclusion' <<< "$latest")
if [ "$conclusion" = "success" ]; then
echo "$WORKFLOW_FILE succeeded for $HEAD_SHA."
exit 0
fi
if [ "$status" != "completed" ]; then
echo "::error::$WORKFLOW_FILE is $status for $HEAD_SHA. This gate will re-evaluate on completion."
exit 1
fi
echo "::error::$WORKFLOW_FILE concluded as $conclusion for $HEAD_SHA."
exit 1
if [ "$conclusion" != "success" ]; then
echo "::error::$WORKFLOW_FILE concluded as $conclusion for $HEAD_SHA."
exit 1
fi
# Top-level success isn't enough: if `pr_metadata` gated downstream
# jobs out (label wasn't set at run time), only the gate job itself
# concludes `success` and the workflow still reports `success`.
# Require at least one non-gate job to have succeeded as proof the
# label was present when the workflow ran.
real_success=$(gh api "repos/$GH_REPO/actions/runs/$run_id/jobs" --jq '[.jobs[] | select(.conclusion == "success" and .name != "Resolve PR metadata")] | length')
if [ "$real_success" -lt 1 ]; then
echo "::error::$WORKFLOW_FILE run $run_id only ran the metadata gate — $REQUIRED_LABEL was not set when the workflow last executed. Re-run $WORKFLOW_FILE so the gate re-evaluates with the label present."
exit 1
fi
echo "$WORKFLOW_FILE run $run_id executed and succeeded for $HEAD_SHA ($real_success non-gate job(s) passed)."
exit 0