trending/OpenShell
1
0
Fork 0
mirror of https://github.com/NVIDIA/OpenShell.git synced 2026-10-28 07:13:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(mxc): resolve Windows lint and generated binding drift

Browse Source 
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This commit is contained in:
Drew Newberry
2026-10-13 08:24:13 -07:00
parent c0cba92a4a
commit 6763b09008
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/openshell-mxc-boundary/src/socket_owner.rs
+5 -7
View File
@@ -177,7 +177,7 @@ fn tcp_table(address_family: u32) -> Result<(Vec<u32>, usize)> {
for _ in 0..3 {
let mut buffer = vec![0u32; (byte_len as usize).div_ceil(size_of::<u32>()).max(1)];
let mut actual_len = u32::try_from(buffer.len() * size_of::<u32>())
.map_err(|_| format!("TCP table buffer is too large"))?;
.map_err(|_| "TCP table buffer is too large".to_string())?;
// SAFETY: The u32-backed buffer has sufficient alignment and capacity
// for the requested byte count. The API writes at most `actual_len`
// bytes and updates it when the table grows concurrently.
@@ -203,9 +203,7 @@ fn tcp_table(address_family: u32) -> Result<(Vec<u32>, usize)> {
byte_len = actual_len;
}
Err(format!(
"GetExtendedTcpTable changed size during three consecutive reads"
))
Err("GetExtendedTcpTable changed size during three consecutive reads".to_string())
}
fn table_rows<T: Copy>(
@@ -215,7 +213,7 @@ fn table_rows<T: Copy>(
row_stride: usize,
) -> Result<Vec<T>> {
if byte_len < size_of::<u32>() {
return Err(format!("Windows TCP table is missing its header"));
return Err("Windows TCP table is missing its header".to_string());
}
if row_stride < size_of::<T>() {
return Err(format!(
@@ -231,10 +229,10 @@ fn table_rows<T: Copy>(
.checked_add(
(count - 1)
.checked_mul(row_stride)
.ok_or_else(|| format!("Windows TCP row count overflow"))?,
.ok_or_else(|| "Windows TCP row count overflow".to_string())?,
)
.and_then(|last_row| last_row.checked_add(size_of::<T>()))
.ok_or_else(|| format!("Windows TCP table size overflow"))?
.ok_or_else(|| "Windows TCP table size overflow".to_string())?
};
if required > byte_len || required > size_of_val(buffer) {
return Err(format!(
sdk/go/proto/sandboxv1/sandbox.pb.go
+1
View File
@@ -979,6 +979,7 @@ type NetworkEndpoint struct {
// When non-empty, the SSRF internal-IP check is replaced by an allowlist check:
// - If host is also set: domain must resolve to an IP in this list.
// - If host is empty: any domain is allowed as long as it resolves to an IP in this list.
//
// Supports exact IPs ("10.0.5.20") and CIDR notation ("10.0.5.0/24").
// Loopback (127.0.0.0/8) and link-local (169.254.0.0/16) are always blocked
// regardless of this field.