perf(config): speed up wt config show by avoiding claude --version (#883)

Replace `claude --version` (1.2s Node.js startup) with `which::which("claude")`
(instant PATH lookup) for detecting Claude Code availability.

Performance: ~1.2s → ~150ms (8x faster)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Maximilian Roos
2026-01-26 18:43:13 -08:00
committed by GitHub
co-authored by Claude
parent 9267cd373f
commit 0679e6d8ac
2 changed files with 19 additions and 21 deletions
+5 -5
View File
@@ -73,11 +73,11 @@ pub fn handle_config_show(full: bool) -> anyhow::Result<()> {
/// Check if Claude Code CLI is available
fn is_claude_available() -> bool {
Cmd::new("claude")
.arg("--version")
.run()
.map(|o| o.status.success())
.unwrap_or(false)
// Allow tests to override detection
if let Ok(val) = std::env::var("WORKTRUNK_TEST_CLAUDE_INSTALLED") {
return val == "1";
}
which::which("claude").is_ok()
}
/// Get the home directory for Claude Code config detection
+14 -16
View File
@@ -685,6 +685,8 @@ pub fn configure_cli_command(cmd: &mut Command) {
cmd.env("WT_TEST_EPOCH", TEST_EPOCH.to_string());
// Enable warn-level logging so diagnostics show up in test failures
cmd.env("RUST_LOG", "warn");
// Treat Claude as not installed by default (tests can override with "1")
cmd.env("WORKTRUNK_TEST_CLAUDE_INSTALLED", "0");
// Apply shared static env vars (see STATIC_TEST_ENV_VARS)
for &(key, value) in STATIC_TEST_ENV_VARS {
@@ -999,6 +1001,8 @@ pub struct TestRepo {
git_config_path: PathBuf,
/// Path to mock bin directory for gh/glab commands
mock_bin_path: Option<PathBuf>,
/// Whether Claude CLI should be treated as installed
claude_installed: bool,
/// Snapshot settings guard - keeps insta filters active for this repo's lifetime
_snapshot_guard: insta::internals::SettingsBindDropGuard,
}
@@ -1044,6 +1048,7 @@ impl TestRepo {
test_config_path,
git_config_path,
mock_bin_path: None,
claude_installed: false,
_snapshot_guard: snapshot_guard,
};
@@ -1087,6 +1092,7 @@ impl TestRepo {
test_config_path,
git_config_path,
mock_bin_path: None,
claude_installed: false,
_snapshot_guard: snapshot_guard,
};
@@ -1803,10 +1809,7 @@ impl TestRepo {
.command("auth", MockResponse::exit(1))
.write(&mock_bin);
// claude: not installed
MockConfig::new("claude")
.command("_default", MockResponse::exit(1))
.write(&mock_bin);
// claude: not installed (don't create mock - which::which won't find it)
self.mock_bin_path = Some(mock_bin);
}
@@ -1816,18 +1819,8 @@ impl TestRepo {
/// Call this after setup_mock_ci_tools_unauthenticated() to simulate
/// Claude Code being available on the system.
pub fn setup_mock_claude_installed(&mut self) {
use crate::common::mock_commands::{MockConfig, MockResponse};
let mock_bin = self
.mock_bin_path
.as_ref()
.expect("Call setup_mock_ci_tools_unauthenticated first");
// claude: installed
MockConfig::new("claude")
.version("Claude Code 1.0.0 (mock)")
.command("_default", MockResponse::exit(0))
.write(mock_bin);
// Mark Claude as installed for test environment
self.claude_installed = true;
}
/// Setup the worktrunk plugin as installed in Claude Code
@@ -2073,6 +2066,11 @@ impl TestRepo {
let new_path = std::env::join_paths(&paths).unwrap();
cmd.env(&path_var_name, new_path);
}
// Override Claude installed status if setup_mock_claude_installed() was called
if self.claude_installed {
cmd.env("WORKTRUNK_TEST_CLAUDE_INSTALLED", "1");
}
}
/// Set a marker for a branch.