trending/univer
1
0
Fork 0
mirror of https://github.com/dream-num/univer.git synced 2026-10-02 04:24:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): support reliable base attachment previews (#7592)

Browse Source
This commit is contained in:
Univer
2026-08-25 02:59:43 +08:00
committed by GitHub
parent f8652364a4
commit d9d5391c85
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/services/gallery/__tests__/desktop-gallery.service.spec.ts
+11
View File
@@ -44,6 +44,17 @@ describe('DesktopGalleryService', () => {
sub.unsubscribe(); sub.unsubscribe();
}); });
it('replays the open state when the global gallery UI subscribes after the first open', () => {
const service = createService();
service.open({ images: ['a.png'] });
const snapshots: IGalleryProps[] = [];
const sub = service.gallery$.subscribe((value) => snapshots.push(value));
expect(snapshots).toEqual([{ open: true, images: ['a.png'] }]);
sub.unsubscribe();
});
it('completes gallery state when the open handle is disposed', () => { it('completes gallery state when the open handle is disposed', () => {
const service = createService(); const service = createService();
let completed = false; let completed = false;
packages/ui/src/services/gallery/desktop-gallery.service.ts
+2 -2
View File
@@ -18,7 +18,7 @@ import type { IDisposable } from '@univerjs/core';
import type { IGalleryProps } from '@univerjs/design'; import type { IGalleryProps } from '@univerjs/design';
import type { IGalleryService } from './gallery.service'; import type { IGalleryService } from './gallery.service';
import { Disposable, Inject, Injector, toDisposable } from '@univerjs/core'; import { Disposable, Inject, Injector, toDisposable } from '@univerjs/core';
import { Subject } from 'rxjs'; import { ReplaySubject } from 'rxjs';
import { connectInjector } from '../../utils/di'; import { connectInjector } from '../../utils/di';
import { GalleryPart } from '../../views/components/gallery-part/GalleryPart'; import { GalleryPart } from '../../views/components/gallery-part/GalleryPart';
import { BuiltInUIPart, IUIPartsService } from '../parts/parts.service'; import { BuiltInUIPart, IUIPartsService } from '../parts/parts.service';
@@ -33,7 +33,7 @@ export class DesktopGalleryService extends Disposable implements IGalleryService
this._initUIPart(); this._initUIPart();
} }
gallery$ = new Subject<IGalleryProps>(); gallery$ = new ReplaySubject<IGalleryProps>(1);
override dispose(): void { override dispose(): void {
super.dispose(); super.dispose();