trending/univer
1
0
Fork 0
mirror of https://github.com/dream-num/univer.git synced 2026-10-02 04:24:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: set defined name in formula bar (#6304)

Browse Source 
Co-authored-by: r.sergeev <r.sergeev@yadro.com>
This commit is contained in:
Roman Sergeev
2025-12-15 19:03:24 +08:00
committed by GitHub
co-authored by r.sergeev
parent dd79f5f5a1
commit b485708076
2 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/engine-formula/src/services/defined-names.service.ts
+10
View File
@@ -223,6 +223,16 @@ export class DefinedNamesService extends Disposable implements IDefinedNamesServ
return this._definedNameMap;
}
getDefinedNameByRefString(unitId: string, formulaOrRefString: string) {
if (!this._definedNameMap[unitId]) return;
for (const [_, item] of Object.entries(this._definedNameMap[unitId])) {
if (item.formulaOrRefString === formulaOrRefString) {
return item;
}
}
}
private _update() {
this._update$.next(null);
}
packages/sheets-ui/src/views/defined-name/DefinedName.tsx
+21 -6
View File
@@ -17,11 +17,11 @@
import type { Workbook, Worksheet } from '@univerjs/core';
import type { ChangeEvent, KeyboardEvent } from 'react';
import type { IScrollToCellCommandParams } from '../../commands/commands/set-scroll.command';
import { ICommandService, IUniverInstanceService, ThemeService, UniverInstanceType } from '@univerjs/core';
import { AbsoluteRefType, ICommandService, IUniverInstanceService, ThemeService, UniverInstanceType } from '@univerjs/core';
import { borderRightClassName, clsx, Dropdown } from '@univerjs/design';
import { deserializeRangeWithSheet, IDefinedNamesService, isReferenceString } from '@univerjs/engine-formula';
import { deserializeRangeWithSheet, IDefinedNamesService, isReferenceString, LexerTreeBuilder, serializeRangeWithSheet } from '@univerjs/engine-formula';
import { MoreDownIcon } from '@univerjs/icons';
import { getPrimaryForRange, SetSelectionsOperation } from '@univerjs/sheets';
import { getPrimaryForRange, SetSelectionsOperation, SheetsSelectionsService } from '@univerjs/sheets';
import { useDependency } from '@univerjs/ui';
import { useEffect, useState } from 'react';
import { ScrollToCellCommand } from '../../commands/commands/set-scroll.command';
@@ -34,6 +34,9 @@ export function DefinedName({ disable }: { disable: boolean }) {
const definedNamesService = useDependency(IDefinedNamesService);
const commandService = useDependency(ICommandService);
const univerInstanceService = useDependency(IUniverInstanceService);
const selectionManagerService = useDependency(SheetsSelectionsService);
const lexerTreeBuilder = useDependency(LexerTreeBuilder);
const worksheet = univerInstanceService.getCurrentUnitOfType<Workbook>(UniverInstanceType.UNIVER_SHEET)!.getActiveSheet();
const unitId = worksheet?.getUnitId();
const subUnitId = worksheet?.getSheetId();
@@ -41,9 +44,21 @@ export function DefinedName({ disable }: { disable: boolean }) {
useEffect(() => {
const subscription = definedNamesService.currentRange$.subscribe(() => {
const range = definedNamesService.getCurrentRangeForString();
setRangeString(range);
setInputValue(range);
const selections = selectionManagerService.getCurrentSelections();
const formulaOrRefs = selections?.map((selection) => {
return serializeRangeWithSheet(worksheet.getName(), selection.range);
})?.join(',');
const absoluteRef = lexerTreeBuilder.convertRefersToAbsolute(formulaOrRefs, AbsoluteRefType.ALL, AbsoluteRefType.ALL, worksheet.getName());
const definedName = definedNamesService.getDefinedNameByRefString(unitId, absoluteRef);
if (definedName) {
setRangeString(definedName.name);
setInputValue(definedName.name);
} else {
const range = definedNamesService.getCurrentRangeForString();
setRangeString(range);
setInputValue(range);
}
});
return () => {