trending/univer
1
0
Fork 0
mirror of https://github.com/dream-num/univer.git synced 2026-10-02 04:24:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): fix new sheet params ts type (#6323)

Browse Source
This commit is contained in:
wpxp123456
2025-12-17 10:41:17 +08:00
committed by GitHub
parent 23f6ae22b4
commit 120263f0b8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/sheets/src/facade/f-workbook.ts
+5 -5
View File
@@ -16,7 +16,7 @@
import type { CommandListener, CustomData, ICommandInfo, IDisposable, IRange, IStyleData, IWorkbookData, IWorksheetData, LocaleType, Workbook } from '@univerjs/core'; import type { CommandListener, CustomData, ICommandInfo, IDisposable, IRange, IStyleData, IWorkbookData, IWorksheetData, LocaleType, Workbook } from '@univerjs/core';
import type { ISetDefinedNameMutationParam } from '@univerjs/engine-formula'; import type { ISetDefinedNameMutationParam } from '@univerjs/engine-formula';
import type { IInsertSheetCommandParams, IRangeThemeStyleJSON, ISetSelectionsOperationParams, ISheetCommandSharedParams } from '@univerjs/sheets'; import type { IRangeThemeStyleJSON, ISetSelectionsOperationParams, ISheetCommandSharedParams } from '@univerjs/sheets';
import type { FontLine as _FontLine } from './f-range'; import type { FontLine as _FontLine } from './f-range';
import { ICommandService, ILogService, Inject, Injector, IPermissionService, IResourceLoaderService, IUniverInstanceService, LocaleService, mergeWorksheetSnapshotWithDefault, RANGE_TYPE, RedoCommand, toDisposable, Tools, UndoCommand, UniverInstanceType } from '@univerjs/core'; import { ICommandService, ILogService, Inject, Injector, IPermissionService, IResourceLoaderService, IUniverInstanceService, LocaleService, mergeWorksheetSnapshotWithDefault, RANGE_TYPE, RedoCommand, toDisposable, Tools, UndoCommand, UniverInstanceType } from '@univerjs/core';
import { FBaseInitialable } from '@univerjs/core/facade'; import { FBaseInitialable } from '@univerjs/core/facade';
@@ -223,9 +223,9 @@ export class FWorkbook extends FBaseInitialable {
* console.log(newSheetWithData); * console.log(newSheetWithData);
* ``` * ```
*/ */
create(name: string, rows: number, columns: number, options?: Pick<IInsertSheetCommandParams, 'index' | 'sheet'>): FWorksheet { create(name: string, rows: number, columns: number, options?: { index?: number; sheet?: Partial<IWorksheetData> }): FWorksheet {
const newSheet: Partial<IWorksheetData> = mergeWorksheetSnapshotWithDefault(Tools.deepClone(options?.sheet ?? {})); const newSheet: Partial<IWorksheetData> = mergeWorksheetSnapshotWithDefault(Tools.deepClone(options?.sheet ?? {}));
newSheet.name = name; newSheet.name = this._workbook.uniqueSheetName(name);
newSheet.rowCount = rows; newSheet.rowCount = rows;
newSheet.columnCount = columns; newSheet.columnCount = columns;
newSheet.id = options?.sheet?.id; newSheet.id = options?.sheet?.id;
@@ -353,9 +353,9 @@ export class FWorkbook extends FBaseInitialable {
* console.log(newSheetWithData); * console.log(newSheetWithData);
* ``` * ```
*/ */
insertSheet(sheetName?: string, options?: Pick<IInsertSheetCommandParams, 'index' | 'sheet'>): FWorksheet { insertSheet(sheetName?: string, options?: { index?: number; sheet?: Partial<IWorksheetData> }): FWorksheet {
const newSheet: Partial<IWorksheetData> = mergeWorksheetSnapshotWithDefault(Tools.deepClone(options?.sheet ?? {})); const newSheet: Partial<IWorksheetData> = mergeWorksheetSnapshotWithDefault(Tools.deepClone(options?.sheet ?? {}));
newSheet.name = sheetName; newSheet.name = this._workbook.uniqueSheetName(sheetName);
newSheet.id = options?.sheet?.id; newSheet.id = options?.sheet?.id;
const newSheetIndex = options?.index ?? this._workbook.getSheets().length; const newSheetIndex = options?.index ?? this._workbook.getSheets().length;