mirror of https://github.com/Tencent/teamai-cli.git synced 2026-10-02 03:14:40 +08:00

Files

T

Jeffandreview a84bf6fbba chore(review): scope e2e to behavior changes, drop provider×agent matrix, add P3 (#781 )

* chore(review): scope e2e requirement, drop provider×agent matrix, add P3

The auto-review gate over-flagged: it required a full provider × agent
e2e matrix as [P1 blocking] on every PR, raised theoretical/low-confidence
risks at blocking severity, and repeated already-resolved findings.

- e2e record is [P1 blocking] only for behavior-changing PRs; docs-only /
  tests-only diffs need none. One representative real-CLI run is enough;
  missing extra provider/agent coverage the author flagged as untestable
  here or deferred to CI is at most [P3 nit], never blocking.
- Add a third severity [P3 nit] (minor/optional polish, theoretical edge
  case, coverage deferred to CI).
- Tell the reviewer not to over-review: report only high-confidence
  findings, prefer few high-signal over exhaustive, never restate a
  resolved finding.

Kept in sync across AGENTS.md (## Code Review Rules, the trusted base
criteria) and the workflow prompt in codex-review-on-assign.yml.

* chore(review): relax PR 前测试 matrix, gate P1 by evidence not count

Address SaulMoro's changes-requested on #781:

- The provider × agent matrix requirement still lived in `## PR 前测试`
  (AGENTS.md/CLAUDE.md), which the Codex reviewer loads whole — so the
  matrix could return as a P1 despite `## Code Review Rules` relaxing it.
  Relax `## PR 前测试` to match: one representative real-CLI run suffices,
  docs/tests-only needs no e2e, extra provider/agent coverage defers to CI.
- Replace "prefer a few high-signal findings" (which caps real bugs and
  pushes them to later passes) with evidence-gated severity: every
  [P1 blocking] must cite a concrete failure scenario or the exact rule it
  breaks, else it drops to P2/P3. Count is uncapped; real bugs surface in
  one pass. Synced into the workflow prompt.

---------

Co-authored-by: review <review@local>

2026-09-24 19:04:58 +08:00

2.3 KiB

Raw Blame History

TeamAI CLI

CLI for syncing team skills, rules, docs, and env across AI coding tools. Package: teamai-cli.

TypeScript, Node 20+, tsup (ESM), Vitest. Commands: npm run build, npx tsc --noEmit, npx vitest run, npm run test:e2e.

Git

Default branch: main. Worktrees and PRs based on origin/main.
PR only to Tencent/teamai-cli. Before push, check git log origin/main..HEAD; rebase or cherry-pick if unrelated commits appear.
必须使用 Worktree：改代码前先 EnterWorktree，禁止在主工作目录修改。

Rules

CLI user-facing output must be English. No Chinese in production code. Tests assert English output.
Keep bilingual docs in sync (README / *.zh-CN.md, docs/usage-guide.*). Behavior changes must update every affected doc (including docs/designs/); grep old wording before opening the PR.
README 精简：尽量少改动 README，保持简洁。确需改动时，所有语言版本（README.md 及全部 README.*.md，改前先 ls README* 确认清单）必须全部改完并保持一致。
skill-data/ 与文档同等对待：那是 agent 真正读到的内容。行为变更必须同步更新受影响的 skill（core / setup / wiki / share），并在 PR 前 grep 旧措辞。
skill-data/core/references/commands.md 由 Commander 命令表生成，改动命令或 flag 后运行 npx vitest run commands-reference -u 重新生成。
部署到 agent 的只有 skills/teamai/SKILL.md（发现入口），保持与版本无关：新增工作流是在 skill-data/ 下加目录 + 在 stub 里加一行，不要把内容写进 stub。
奥卡姆剃刀：避免过早添加新 CLI 命令；非必要不加；优先复用或扩展现有命令与选项。

PR 前测试

改动运行时行为的 PR（docs-only / tests-only 之外），npm run build 后必须用真实 CLI 对本次改动做端到端验证，不能只跑 type check / unit test；一次代表性的 real-CLI 运行即可，把实际通过的验证记录贴进 PR。docs-only / tests-only 的改动无需 e2e 记录。

不要求覆盖下面的完整 provider × agent 矩阵——额外 provider / agent 的覆盖交给 CI，或在本地环境不具备时说明即可：

Agent：Claude、Codex、CodeBuddy、OpenCode
Provider：git、gitlab、github

2.3 KiB Raw Blame History Unescape Escape

TeamAI CLI

Git

Rules

PR 前测试

2.3 KiB

Raw Blame History