mirror of
https://github.com/agent-substrate/substrate.git
synced 2026-10-27 07:34:12 +08:00
Chuang Wang
07ebc56797
Follow-up to the review comments on #1288 (merged before they could land there). - [x] Tests pass - [x] Appropriate changes to documentation are included in the PR Changes: - `hack/third_party/csi-driver-host-path/deploy/csi-hostpath-testing.yaml`: same fix as #1288 — the inline `watched_directory` was a no-op, so the serving cert and trust bundle move to filesystem SDS (SPIFFE SAN pin kept inline via `combined_validation_context`). SDS requires a node id and this sidecar passes no `--service-node`, so the bootstrap gains a `node:` stanza; the `docs/csi-deployment.md` example had the same gap and gets one too. - `overlay_test.go` now asserts `watched_directory` appears nowhere in the emitted cluster block or the patched `envoy.yaml` (comments excluded) and is present in each SDS resource file, per review. - Corrected the test comment claiming the sdsmint e2e suite is skipped in CI: the sdsmint variant is deployed in the MITM lanes; only the `--experimental-additional-egress-extproc-service` injection has no e2e coverage. Verification: `go test ./cmd/ate-setup/...` passes; `envoy --mode validate` (v1.34) passes on the reworked csi-hostpath bootstrap with dummy PEMs mounted at the referenced paths.