mirror of
https://github.com/agent-substrate/substrate.git
synced 2026-11-11 10:23:17 +08:00
Julian Gutierrez Oschmann
9f8475493b
This change removes the hard-link from templates to worker pools, allowing pools to be selected using k8s labels. Both actors and actor templates are augmented with a label selector field. When an actor is resumed, we resolve the set of *eligible* worker pools by evaluating the intersection of both actor and template selectors. Then we find a free worker from one of them. The overall design is described in [1]. [1]: https://github.com/agent-substrate/substrate/issues/47#issuecomment-4712334620
105 lines
3.7 KiB
Go
105 lines
3.7 KiB
Go
// Copyright 2026 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package controlapi
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/agent-substrate/substrate/cmd/ateapi/internal/store"
|
|
"github.com/agent-substrate/substrate/internal/resources"
|
|
"github.com/agent-substrate/substrate/pkg/proto/ateapipb"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
k8serrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/apimachinery/pkg/util/validation"
|
|
)
|
|
|
|
func (s *Service) CreateActor(ctx context.Context, req *ateapipb.CreateActorRequest) (*ateapipb.CreateActorResponse, error) {
|
|
if err := validateCreateActorRequest(req); err != nil {
|
|
return nil, err
|
|
}
|
|
_, err := s.actorTemplateLister.ActorTemplates(req.GetActorTemplateNamespace()).Get(req.GetActorTemplateName())
|
|
if err != nil {
|
|
if k8serrors.IsNotFound(err) {
|
|
return nil, status.Errorf(codes.FailedPrecondition, "ActorTemplate %s/%s not found", req.GetActorTemplateNamespace(), req.GetActorTemplateName())
|
|
}
|
|
return nil, fmt.Errorf("while getting ActorTemplate: %w", err)
|
|
}
|
|
|
|
id := req.GetActorId()
|
|
actor := &ateapipb.Actor{
|
|
ActorId: id,
|
|
Version: 1,
|
|
Status: ateapipb.Actor_STATUS_SUSPENDED,
|
|
ActorTemplateNamespace: req.GetActorTemplateNamespace(),
|
|
ActorTemplateName: req.GetActorTemplateName(),
|
|
WorkerSelector: req.GetWorkerSelector(),
|
|
}
|
|
err = s.persistence.CreateActor(ctx, actor)
|
|
if err != nil {
|
|
if errors.Is(err, store.ErrAlreadyExists) {
|
|
return nil, status.Errorf(codes.AlreadyExists, "Actor %s already exists", id)
|
|
}
|
|
return nil, fmt.Errorf("while recording actor: %w", err)
|
|
}
|
|
|
|
storedActor, err := s.persistence.GetActor(ctx, id)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("while fetching recorded actor from DB: %w", err)
|
|
}
|
|
|
|
return &ateapipb.CreateActorResponse{
|
|
Actor: storedActor,
|
|
}, nil
|
|
}
|
|
|
|
func validateCreateActorRequest(req *ateapipb.CreateActorRequest) error {
|
|
if req.GetActorTemplateNamespace() == "" {
|
|
return status.Error(codes.InvalidArgument, "actor_template_namespace is required")
|
|
}
|
|
if req.GetActorTemplateName() == "" {
|
|
return status.Error(codes.InvalidArgument, "actor_template_name is required")
|
|
}
|
|
if req.GetActorId() == "" {
|
|
return status.Error(codes.InvalidArgument, "actor_id is required")
|
|
}
|
|
if err := resources.ValidateActorID(req.GetActorId()); err != nil {
|
|
return status.Error(codes.InvalidArgument, err.Error())
|
|
}
|
|
if err := validateSelector(req.GetWorkerSelector()); err != nil {
|
|
return status.Error(codes.InvalidArgument, err.Error())
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func validateSelector(sel *ateapipb.Selector) error {
|
|
const maxSelectorMatchLabels = 10
|
|
if n := len(sel.GetMatchLabels()); n > maxSelectorMatchLabels {
|
|
return fmt.Errorf("worker_selector has %d match_labels entries, exceeding the limit of %d", n, maxSelectorMatchLabels)
|
|
}
|
|
for k, v := range sel.GetMatchLabels() {
|
|
if errs := validation.IsQualifiedName(k); len(errs) > 0 {
|
|
return fmt.Errorf("invalid worker_selector label key %q: %s", k, strings.Join(errs, "; "))
|
|
}
|
|
if errs := validation.IsValidLabelValue(v); len(errs) > 0 {
|
|
return fmt.Errorf("invalid worker_selector label value %q for key %q: %s", v, k, strings.Join(errs, "; "))
|
|
}
|
|
}
|
|
return nil
|
|
}
|