From 4672e95a20c14ed176bdab7481023328a4ecf893 Mon Sep 17 00:00:00 2001 From: haiyanmeng Date: Tue, 29 Sep 2026 17:38:32 +0000 Subject: [PATCH] nighthawk-ingress: let run-dev.sh run more actors than workers (#1982) `run-dev.sh` refused to start unless the Running worker count was at least `--actors`, on the assumption that each worker hosts one actor. It does not: a worker advertises capacity for many actors and the scheduler packs them. > It's a good idea to open an issue first for discussion. - [ ] Tests pass - [ ] Appropriate changes to documentation are included in the PR --- benchmarking/nighthawk-ingress/run-dev.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/benchmarking/nighthawk-ingress/run-dev.sh b/benchmarking/nighthawk-ingress/run-dev.sh index 3f73b4104..94e340fe8 100755 --- a/benchmarking/nighthawk-ingress/run-dev.sh +++ b/benchmarking/nighthawk-ingress/run-dev.sh @@ -36,7 +36,7 @@ usage() { cat </dev/null 2>&1 || { exit 1 } +# A worker hosts many actors, so the fleet can outnumber the workers. RUNNING_WORKERS="$(kubectl get pods -n benchmark-workloads --no-headers 2>/dev/null | grep -c ' Running ' || true)" -if (( RUNNING_WORKERS < ACTORS )); then - echo "ERROR: ${RUNNING_WORKERS} workers Running in benchmark-workloads, need ${ACTORS}. Run:" >&2 +if (( RUNNING_WORKERS < 1 )); then + echo "ERROR: no workers Running in benchmark-workloads. Run:" >&2 echo " benchmarking/workloads/deploy.sh --deploy --worker-count ${ACTORS} --sandbox-class gvisor" >&2 exit 1 fi