mirror of
https://github.com/vercel-labs/scriptc.git
synced 2026-11-02 07:43:42 +08:00
Chris TateandClaude Opus 5.5
ee2832afae
Typed-array element reads at an index that is not an integer in [0, length) now yield undefined instead of throwing a RangeError. The read is `number | undefined`, like ordinary array reads; numeric and truthiness consumers fuse back to the plain element read, which answers NaN for an invalid index without touching storage. The may-throw seed for typed reads is removed. Invalid writes stay ignored. The corpus pins reads in printing, comparison, arithmetic, defaulting, truthiness, bindings and templates, plus ignored writes, and a received worker message is checked to arrive unfrozen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
92 lines
3.4 KiB
TypeScript
92 lines
3.4 KiB
TypeScript
import { execFile } from "node:child_process";
|
|
import { mkdir, mkdtemp, rm } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { promisify } from "node:util";
|
|
import { afterAll, beforeAll, expect, test } from "vitest";
|
|
|
|
const execFileAsync = promisify(execFile);
|
|
const testDir = import.meta.dirname;
|
|
const bin = join(testDir, "build", "test_bytes");
|
|
let scratch: string;
|
|
|
|
// Compiled once with ASan + the RC audit: the assertions in test_bytes.c
|
|
// cover the ToUint8/ToUint32 coercion matrix, ToIndex construction,
|
|
// slice/set copies, the utf8/hex/base64 conversions (invalid-utf8
|
|
// replacement included), concat, the u32be pair, the fs Buffer round trip,
|
|
// zlib deflate/inflate, and the RC recursion through SCR_ELEM_BYTES arrays
|
|
// — the sanitized run proves no leak/double-free across all of them.
|
|
beforeAll(async () => {
|
|
await mkdir(join(testDir, "build"), { recursive: true });
|
|
await execFileAsync("clang", [
|
|
"-std=c11",
|
|
"-O1",
|
|
"-Wall",
|
|
"-Wextra",
|
|
"-fsanitize=address,undefined",
|
|
"-DSCR_RC_AUDIT",
|
|
"-I",
|
|
join(testDir, "../src"),
|
|
"-o",
|
|
bin,
|
|
join(testDir, "test_bytes.c"),
|
|
join(testDir, "../src/scr_bytes.test.c"),
|
|
join(testDir, "../src/scr_bytes.c"),
|
|
join(testDir, "../src/scr_shared.c"),
|
|
join(testDir, "../src/scr_bytes_io.c"),
|
|
join(testDir, "../src/scr_zlib.c"),
|
|
join(testDir, "../src/scr_lib.c"),
|
|
join(testDir, "../src/scr_string.c"),
|
|
join(testDir, "../src/scr_array.c"),
|
|
join(testDir, "../src/scr_map.c"),
|
|
join(testDir, "../src/scr_exception.c"),
|
|
join(testDir, "../src/scr_error.c"),
|
|
join(testDir, "../src/scr_number.c"),
|
|
join(testDir, "../src/scr_console.c"),
|
|
join(testDir, "../src/scr_closure.c"),
|
|
join(testDir, "../src/scr_ffi.c"),
|
|
join(testDir, "../src/scr_object.c"),
|
|
join(testDir, "../src/scr_union.c"),
|
|
join(testDir, "../src/scr_cycle.c"),
|
|
join(testDir, "../src/scr_alloc.c"),
|
|
join(testDir, "../src/scr_json.c"),
|
|
join(testDir, "../src/scr_bigint.c"),
|
|
join(testDir, "../src/scr_async.c"),
|
|
join(testDir, "../src/scr_child.c"),
|
|
join(testDir, "../src/scr_path.c"),
|
|
join(testDir, "../src/scr_url.c"),
|
|
join(testDir, "../src/scr_url_params.c"),
|
|
"-Wno-deprecated-declarations",
|
|
"-lz",
|
|
...(process.platform === "linux" ? ["-D_GNU_SOURCE", "-lm"] : []),
|
|
]);
|
|
scratch = await mkdtemp(join(tmpdir(), "scriptc-bytes-"));
|
|
});
|
|
|
|
afterAll(async () => {
|
|
if (scratch) await rm(scratch, { recursive: true, force: true });
|
|
});
|
|
|
|
test("bytes runtime: coercions, encodings, zlib, fs, RC", async () => {
|
|
const { stderr } = await execFileAsync(bin, [scratch], {
|
|
env: { ...process.env, UBSAN_OPTIONS: "halt_on_error=1" },
|
|
});
|
|
expect(stderr.trim().split("\n").pop()).toMatch(/^(\d+)\/\1 cases passed$/);
|
|
});
|
|
|
|
// Statically typed numeric reads cannot represent undefined and still trap.
|
|
// Invalid writes are ignored and covered by the runtime assertions above.
|
|
test.each([
|
|
["--crash-get-oob", "typed array index 1 out of bounds (length 1)"],
|
|
["--crash-get-frac", "typed array index 0.5 out of bounds (length 1)"],
|
|
])("trap aborts (%s)", async (mode, message) => {
|
|
const err = await execFileAsync(bin, [mode]).then(
|
|
() => {
|
|
throw new Error(`expected ${mode} to abort`);
|
|
},
|
|
(e: Error & { signal?: string; stderr?: string }) => e,
|
|
);
|
|
expect(err.signal).toBe("SIGABRT");
|
|
expect(err.stderr).toContain(`scriptc: RangeError: ${message}`);
|
|
});
|