mirror of
https://github.com/vercel-labs/scriptc.git
synced 2026-11-01 07:33:12 +08:00
Chris Tate
d3e8ab41ef
A new plan was copied into its slot as a whole struct, which wrote the slot's pc with a plain store while other threads' lookups read it atomically: a data race. The insert now copies the fields after pc and publishes pc only with the release store. The unwinder test also runs its threaded cases under ThreadSanitizer, which reports the race without this change.
56 lines
2.2 KiB
TypeScript
56 lines
2.2 KiB
TypeScript
import { execFile } from "node:child_process";
|
|
import { mkdir } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { promisify } from "node:util";
|
|
import { expect, test } from "vitest";
|
|
|
|
const execFileAsync = promisify(execFile);
|
|
const testDir = import.meta.dirname;
|
|
|
|
// scr_unwind.c walks with cached plans on x86-64 Linux only.
|
|
test.runIf(process.platform === "linux" && process.arch === "x64")(
|
|
"the unwinder runs landing pads in order, restores callee-saved registers and falls back to libgcc",
|
|
async () => {
|
|
const buildDir = join(testDir, "build");
|
|
await mkdir(buildDir, { recursive: true });
|
|
const frames = [join(testDir, "test_unwind_frames.ll"), join(testDir, "test_unwind_frames.S")];
|
|
// The frames also run from a shared library, whose FDEs are in its own
|
|
// .eh_frame_hdr.
|
|
const library = join(buildDir, "libtest_unwind_frames.so");
|
|
await execFileAsync("clang", ["-O1", "-shared", "-fPIC", "-o", library, ...frames]);
|
|
for (const build of ["plain", "asan", "tsan", "shared"] as const) {
|
|
const bin = join(buildDir, `test_unwind_${build}`);
|
|
await execFileAsync("clang", [
|
|
"-std=c11",
|
|
"-O1",
|
|
"-Wall",
|
|
"-Wextra",
|
|
"-D_GNU_SOURCE",
|
|
"-DSCR_UNWIND_TESTING",
|
|
...(build === "asan" ? ["-fsanitize=address"] : []),
|
|
...(build === "tsan" ? ["-fsanitize=thread"] : []),
|
|
"-pthread",
|
|
"-o",
|
|
bin,
|
|
join(testDir, "test_unwind.c"),
|
|
...(build === "shared" ? [library, `-Wl,-rpath,${buildDir}`] : frames),
|
|
join(testDir, "../src/scr_unwind.c"),
|
|
// The library's landing pads and the program share libgcc_s's unwinder.
|
|
...(build === "shared" ? ["-shared-libgcc"] : ["-lgcc_eh"]),
|
|
]);
|
|
const env = {
|
|
...process.env,
|
|
ASAN_OPTIONS: "detect_leaks=0:halt_on_error=1",
|
|
TSAN_OPTIONS: "halt_on_error=1",
|
|
};
|
|
// ThreadSanitizer checks the threads' concurrent plan inserts and
|
|
// lookups; the libgcc fallback cases run in the other builds.
|
|
for (const args of build === "tsan" ? [["threads"]] : [[], ["threads"]]) {
|
|
const run = await execFileAsync(bin, args, { env });
|
|
expect(run.stdout).toBe("unwind checks passed\n");
|
|
}
|
|
}
|
|
},
|
|
120_000,
|
|
);
|