mirror of
https://github.com/astral-sh/ruff.git
synced 2026-11-21 12:16:15 +08:00
Summary -- There were several new cargo and clippy lints here, so I tried to break up the changes into several commits: - deleting some unused workspace dependencies, these looked kind of intentional as they also had some shear ignores, but it seems okay to delete those too? - allowing the [redundant_homepage] lint. We could delete a lot of these, but the ones in the `ruff` and `ty` crates seem necessary for maturin, as I noted in a comment. - fixing the [missing_lints_inheritance] lint. It seems that several of our crates don't inherit our workspace lints. For now I just included the `allow` for `redundant_homepage`, but we could follow up by inheriting the full table and fixing all the additional lints that produces. (This commit is actually combined with the previous one) - allowing cargo's new [unused_dependencies] lint, which seems redundant with `shear` and had some false positives on our benchmark dependencies. Codex tried to work around this with some `cfg`-gated imports in the benchmark crate, but ignoring this seemed better for now, at least while we're still using `shear`. - running `clippy --fix` on the remaining lint errors, with one manual intervention where Clippy dropped some of our `cfg` handling. These new diagnostics were mostly around returning boolean expressions. - renaming `NodeIndex::_NONE` to avoid [used_underscore_items] There are also some new APIs in 1.98 that we can use now. I'll follow up with those separately. [redundant_homepage]: https://doc.rust-lang.org/cargo/reference/lints.html#redundant_homepage [missing_lints_inheritance]: https://doc.rust-lang.org/cargo/reference/lints.html#missing_lints_inheritance [used_underscore_items]: https://clippy.rust-lang.org/master/#used_underscore_items [unused_dependencies]: https://doc.rust-lang.org/cargo/reference/lints.html#unused_dependencies
3 lines
32 B
TOML
3 lines
32 B
TOML
[toolchain]
|
|
channel = "1.100.0"
|