Files
paperclip/scripts/codemod-extract-type.mjs
c07e650cd7 feat(ui): single-source design tokens, visual regression suite, and theme retune (#9134)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Its UI is the operator's daily surface: task lists, boards, budgets,
agent status — all built on shadcn components and Tailwind
> - Visual values (colors, spacing, type sizes, radii) were hardcoded at
~1,600 call sites: the same "small gray label" was 9/10/11px depending
on the file, charts disagreed with chips about status colors, two
toggle-switch implementations coexisted in two greens, and there was no
visual regression coverage
> - This made the UI drift-prone and made any restyle a
hundreds-of-files project, which discourages design iteration
> - This pull request extracts visual values into a single token layer
in `ui/src/index.css`, adds a Storybook visual regression suite backed
by external immutable baseline archives, and then applies a deliberate
retune reviewed change-by-change on screenshot diffs
> - The benefit is that Paperclip's look becomes a config surface:
retheming is a token edit reviewed as a snapshot diff, drift is blocked
by a token gate, and future UI PRs can prove exactly what changed
visually without committing hundreds of PNGs

## Linked Issues or Issue Description

No existing public issue covers this work (searched "design tokens",
"visual regression", "design system" across issues and PRs). Related in
spirit: Refs #8982 (theming a hardcoded panel — a one-off instance of
the same problem class this PR addresses systematically).

**Problem (feature-request form):** UI visual values are hardcoded per
call site with no source of truth and no regression coverage;
consistency depends on reviewer memory, and restyling requires mass file
edits.
**Proposed solution (this PR):** a single token layer + enforcement gate
+ externally stored visual snapshot suite, then an intentional restyle
on top of that foundation.

## What Changed

- **Token extraction (zero visual change, machine-verified during
development):** committed codemods (`scripts/codemod-*.mjs`) moved
~1,600 hardcoded color/type/spacing/radius/shadow/misc values into named
tokens in a non-inline `:root` block of `ui/src/index.css`.
- **Visual regression suite:** `pnpm test:storybook-visual` covers 255
stories × light/dark = 510 Playwright screenshots at `maxDiffPixels: 0`,
plus new primitive-coverage stories and deterministic-render fixes.
- **External visual baselines:** committed PNG snapshots were removed.
`tests/storybook-visual/baseline-manifest.json` pins an immutable
archive URL/hash/size/count, and `scripts/storybook-visual-baseline.mjs`
handles `download`, `verify`, `pack`, and trusted maintainer `upload`
flows.
- **Opt-in visual CI artifacts:** added a `Storybook Visual` workflow
that runs on manual dispatch or PRs labeled `storybook-visual`,
downloads/verifies the baseline, runs Playwright, and uploads Playwright
report/test-result artifacts for review. Normal PR runs do not mutate
baseline objects.
- **Token gate:** `pnpm check:token-gates` — zero hex literals, zero
arbitrary bracket values, zero raw font-sizes in `ui/src/components/**`
and `ui/src/pages/**`, with a documented inline allowlist for legitimate
opt-outs.
- **Theme retune (intentional, snapshot-reviewed):** new base theme
values; radius ladder derived from a single `--radius` knob; micro-type
cluster collapsed to a named ladder (`--text-nano/micro/compact` +
Tailwind `text-xs`/`text-sm`); letter-spacing collapsed to named steps.
- **One status-color vocabulary:** charts, quota/budget bar fills,
RUNNING/live chips, and liveness indicators all use the canonical
`--status-*` hues. Light-mode legibility fixes for red alert surfaces
that used dark-tuned text classes.
- **One switch:** `ToggleSwitch` restyled to the registry capsule form,
second hand-rolled implementation removed, and all call sites unified.
- **Docs:** `DESIGN.md` is the design contract; `doc/design/` holds
audit reports, decision logs, and updated guidance for external baseline
review/update workflows.
- Dead code removed (`agentStatusBadge` duplicate map), byte-identical
contrast constants consolidated, semantic renames
(`--project-seed`/`--project-none`, `--liveness-blue`).

## Verification

- `pnpm check:token-gates` — 3/3 gates CLEAN during the design-system
run
- `pnpm typecheck` && `pnpm --filter @paperclipai/ui build` — green
during the design-system run
- `node --test scripts/__tests__/storybook-visual-baseline.test.mjs` —
pass after external-baseline rework
- `pnpm exec tsc --noEmit --pretty false --module NodeNext
--moduleResolution NodeNext --target ES2022 --types
node,@playwright/test tests/storybook-visual/playwright.config.ts
tests/storybook-visual/storybook-visual.spec.ts` — pass after
external-baseline rework
- `git diff --check origin/pr/9134..HEAD` — pass after external-baseline
rework
- `find tests/storybook-visual -type f -name '*.png' -print | wc -l` —
`0`
- `node scripts/storybook-visual-baseline.mjs verify` — intentionally
fails closed until the first trusted maintainer publishes the baseline
archive and updates `baseline-manifest.json`

## Risks

- **Large but shallow:** the PR still touches many UI files due to
mechanical token extraction and retune work, but committed PNG snapshot
churn has been removed from the branch.
- **Baseline publication required before the visual suite can pass in
clean clones:** the manifest currently has placeholder archive metadata.
A trusted maintainer must publish the first immutable archive, then
update `baseline-manifest.json`.
- **Rendering platform variance:** the external baseline should be
captured in the documented Linux/Chromium environment. Future CI runs
verify against the pinned archive and fail closed on checksum/count
mismatch.
- **Visual CI is opt-in while stabilizing:** add the `storybook-visual`
label or dispatch the workflow manually to produce downloadable
Playwright report/test-result artifacts.
- **Scheduled follow-ups, deliberately out of scope:** Tailwind palette
classes map to semantic tokens in a dedicated pass; card/pill component
consolidation; ESLint ratchet. Tracked in
`doc/design/DECISION-SHEET.md`.

## Model Used

Claude Fable 5 (Anthropic, `claude-fable-5`, Mythos-class tier) with
extended thinking, running in Claude Code with tool use; mechanical
phases delegated to Claude Sonnet subagents. Follow-up external-baseline
rework assisted by OpenAI Codex (`gpt-5` coding agent with repository,
terminal, and GitHub tool use). All bulk rewrites executed via
deterministic, idempotent scripts committed in `scripts/`; intentional
visual changes were human-reviewed on screenshot contact sheets.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run targeted local verification and documented the
intentional baseline-publication failure above
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green *(pending new CI run after this
rework)*
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
*(pending review)*
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code) and
OpenAI Codex

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Dotta <bippadotta@protonmail.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-07-07 16:22:16 -05:00

240 lines
11 KiB
JavaScript

#!/usr/bin/env node
/**
* codemod-extract-type.mjs
*
* Phase 2 (extraction), Batch 2/4 of the design-token audit
* (branch design/token-extraction). Replaces hardcoded TYPE values —
* arbitrary Tailwind font-size (`text-[11px]`), letter-spacing
* (`tracking-[0.18em]`), line-height (`leading-[...]`), and raw inline
* `fontSize` style literals — in `ui/src/components/**` and
* `ui/src/pages/**` (including their *.test.tsx companions) with
* references to CSS custom-property tokens defined in `ui/src/index.css`.
*
* Unlike Batch 1's color codemod (which used a hand-audited site table to
* avoid false-positiving on non-color hex-like strings such as issue
* references), this batch's patterns are unambiguous: `text-[Npx]`,
* `text-[N.Nrem]`, `tracking-[N em]`, and `leading-[...]` inside Tailwind
* class strings, and `fontSize: "Npx"` / `fontSize: "N.Nrem"` inline-style
* string literals, cannot mean anything other than a type-size/spacing
* value. A blanket regex sweep is therefore safe and is used here, scoped
* to `ui/src/components/**` and `ui/src/pages/**` only. Numeric or
* computed `fontSize` forms (e.g. `fontSize: 12`, `fontSize: Math.round(...)`)
* are functional (third-party config objects / runtime-computed values)
* and are left untouched — see ALLOWLIST_NOTES below.
*
* Token naming (verbatim value, no normalizing):
* --fs-<N> font-size, px values, e.g. --fs-11: 11px;
* --fs-0_<N>rem font-size, rem values, e.g. --fs-0_7rem: 0.7rem;
* --ls-0_<N> letter-spacing, em values, e.g. --ls-0_18: 0.18em;
* --lh-<N> line-height (px or unitless — none found this batch)
*
* Tailwind v4 paren-shorthand rewrite forms used:
* text-[Npx] -> text-(length:--fs-N) (length hint REQUIRED —
* bare text-(--x) means color)
* tracking-[N em] -> tracking-(--ls-0_N) (unambiguous, no hint)
* leading-[...] -> leading-(--lh-N) (unambiguous, no hint)
* All variant/modifier prefixes (`sm:`, `dark:`, `group-hover:`,
* `[&>x]:`, trailing `!important` marker, etc.) are preserved verbatim —
* the regex only rewrites the bracket portion itself.
*
* Idempotent: the FIND regex only matches the ORIGINAL bracket-literal
* form (`text-[11px]` etc.); once rewritten to `text-(length:--fs-11)` the
* pattern no longer matches, so re-running is a no-op. The inline-style
* FIND is likewise the literal `fontSize: "11px"` string form.
*
* Usage: node scripts/codemod-extract-type.mjs [--check]
* --check Report what WOULD change without writing files (dry run).
*/
import { readFileSync, writeFileSync, readdirSync, statSync } from "node:fs";
import { resolve, dirname, join, relative } from "node:path";
import { fileURLToPath } from "node:url";
const __dirname = dirname(fileURLToPath(import.meta.url));
const REPO_ROOT = resolve(__dirname, "..");
const UI_SRC = resolve(REPO_ROOT, "ui/src");
const SCAN_DIRS = ["components", "pages"];
const DRY_RUN = process.argv.includes("--check");
// ── Helpers ────────────────────────────────────────────────────────────
function walk(dir, out) {
for (const entry of readdirSync(dir, { withFileTypes: true })) {
const p = join(dir, entry.name);
if (entry.isDirectory()) walk(p, out);
else if (/\.(tsx?|jsx?)$/.test(entry.name)) out.push(p);
}
}
function tokenSuffixForPx(value) {
// "11" -> "11", "0.65" -> "0_65"
return value.replace(".", "_");
}
function tokenSuffixForEm(value) {
// "0.18" -> "0_18"
return value.replace(".", "_");
}
// ── Token registries (populated as sites are discovered) ───────────────
// Map of token name (without --) -> { value, comment, kind }
const fsTokens = new Map(); // font-size
const lsTokens = new Map(); // letter-spacing
const lhTokens = new Map(); // line-height
function registerFsToken(rawValue, unit, sourceNote) {
const name = unit === "px" ? `fs-${tokenSuffixForPx(rawValue)}` : `fs-${tokenSuffixForPx(rawValue)}rem`;
if (!fsTokens.has(name)) {
fsTokens.set(name, { value: `${rawValue}${unit}`, comment: sourceNote });
}
return name;
}
function registerLsToken(rawValue, sourceNote) {
const name = `ls-${tokenSuffixForEm(rawValue)}`;
if (!lsTokens.has(name)) {
lsTokens.set(name, { value: `${rawValue}em`, comment: sourceNote });
}
return name;
}
function registerLhToken(rawValue, sourceNote) {
// rawValue includes unit already stripped by caller; store as given
const safeName = rawValue.replace(/[^a-zA-Z0-9]/g, "_");
const name = `lh-${safeName}`;
if (!lhTokens.has(name)) {
lhTokens.set(name, { value: rawValue, comment: sourceNote });
}
return name;
}
// ── Regexes ──────────────────────────────────────────────────────────
// text-[11px], text-[0.65rem], with optional /[Npx] line-height suffix
// (none found in this codebase, but handled for completeness/future-proofing).
const FS_RE = /text-\[([0-9.]+)(px|rem)\](?:\/\[([0-9.]+)(px|rem)\])?/g;
const LS_RE = /tracking-\[([0-9.]+)em\]/g;
const LEADING_RE = /leading-\[([^\]]+)\]/g;
const FONTSIZE_STYLE_RE = /fontSize:\s*"([0-9.]+)(px|rem)"/g;
function rewriteFile(filePath, relPath) {
const original = readFileSync(filePath, "utf8");
let content = original;
let siteCount = 0;
// -- font-size Tailwind class utilities --
content = content.replace(FS_RE, (match, num, unit, lhNum, lhUnit) => {
const fsName = registerFsToken(num, unit, `Extracted from ${relPath} (text-[${num}${unit}]).`);
let replacement = `text-(length:--${fsName})`;
if (lhNum) {
const lhName = registerLhToken(`${lhNum}${lhUnit}`, `Extracted from ${relPath} (text-[...]/[${lhNum}${lhUnit}] line-height suffix).`);
replacement += `/(--${lhName})`;
}
siteCount++;
return replacement;
});
// -- letter-spacing Tailwind class utilities --
content = content.replace(LS_RE, (match, num) => {
const lsName = registerLsToken(num, `Extracted from ${relPath} (tracking-[${num}em]).`);
siteCount++;
return `tracking-(--${lsName})`;
});
// -- line-height Tailwind class utilities (standalone leading-[...]) --
content = content.replace(LEADING_RE, (match, raw) => {
// Only rewrite numeric/unit literals (px, rem, unitless number). Skip
// keyword forms like leading-[inherit] or var()-based (already tokenized).
if (!/^[0-9.]+(px|rem)?$/.test(raw)) return match;
const lhName = registerLhToken(raw, `Extracted from ${relPath} (leading-[${raw}]).`);
siteCount++;
return `leading-(--${lhName})`;
});
// -- inline style fontSize string literals --
content = content.replace(FONTSIZE_STYLE_RE, (match, num, unit) => {
const fsName = registerFsToken(num, unit, `Extracted from ${relPath} (inline style fontSize: "${num}${unit}").`);
siteCount++;
return `fontSize: "var(--${fsName})"`;
});
if (content !== original && !DRY_RUN) {
writeFileSync(filePath, content, "utf8");
}
return { changed: content !== original, siteCount };
}
function main() {
const files = [];
for (const dir of SCAN_DIRS) walk(resolve(UI_SRC, dir), files);
let totalSites = 0;
let filesChanged = 0;
const changedFiles = [];
for (const filePath of files) {
const relPath = "ui/src/" + relative(UI_SRC, filePath);
const { changed, siteCount } = rewriteFile(filePath, relPath);
if (changed) {
filesChanged++;
changedFiles.push(relPath);
}
totalSites += siteCount;
}
// ── index.css token block ──────────────────────────────────────────
const cssPath = resolve(UI_SRC, "index.css");
const cssOriginal = readFileSync(cssPath, "utf8");
const marker = "/* ── Extracted verbatim TYPE tokens (Phase 2 Batch 2, design/token-extraction) ── */";
let cssNext = cssOriginal;
let cssChanged = false;
if (!cssOriginal.includes(marker) && (fsTokens.size || lsTokens.size || lhTokens.size)) {
const lines = [];
lines.push(marker);
lines.push("/* Batch 2/4: font-size + letter-spacing + line-height literals, verbatim");
lines.push(" (no normalizing — 9/10/11/12/13/14/15px and 0.08-0.24em all stay distinct;");
lines.push(" the human scale-collapse decision comes later per DESIGN.md/TOKEN-AUDIT.md).");
lines.push("");
lines.push(" Allowlist (sites intentionally left as hardcoded / functional literals,");
lines.push(" NOT converted to tokens — each also carries an inline");
lines.push(" `token-extraction: allowlisted` comment at the site):");
lines.push(" - pages/CompanyEnvironments.tsx (fontSize: 12) — xterm.js terminal theme");
lines.push(" config; functional third-party numeric option, not a rendered CSS value.");
lines.push(" Same allowlisted object as Batch 1's color entry for this file.");
lines.push(" - pages/CompanySkills.tsx (fontSize: Math.round(size * 0.42)) — computed at");
lines.push(" runtime from a prop; not a static literal, nothing to extract.");
lines.push("*/");
lines.push(":root {");
for (const [name, { value, comment }] of fsTokens) {
lines.push(` --${name}: ${value}; /* ${comment} */`);
}
for (const [name, { value, comment }] of lsTokens) {
lines.push(` --${name}: ${value}; /* ${comment} */`);
}
for (const [name, { value, comment }] of lhTokens) {
lines.push(` --${name}: ${value}; /* ${comment} */`);
}
lines.push("}");
const block = "\n" + lines.join("\n") + "\n";
cssNext = cssOriginal + block;
cssChanged = true;
}
if (cssChanged && !DRY_RUN) writeFileSync(cssPath, cssNext, "utf8");
// ── Summary ─────────────────────────────────────────────────────────
console.log(`\n${DRY_RUN ? "[DRY RUN] " : ""}codemod-extract-type summary`);
console.log(` Sites rewritten: ${totalSites}`);
console.log(` Files changed: ${filesChanged}`);
console.log(` New --fs-* tokens: ${fsTokens.size}`);
console.log(` New --ls-* tokens: ${lsTokens.size}`);
console.log(` New --lh-* tokens: ${lhTokens.size}`);
console.log(` index.css token block: ${cssChanged ? "added" : "already present or nothing to add (idempotent no-op)"}`);
if (changedFiles.length) {
console.log(`\n Changed files:`);
for (const f of changedFiles) console.log(` - ${f}`);
}
}
main();