Files
paperclip/patches/@agentclientprotocol__codex-acp@1.6.2.patch
Devin FoleyandPaperclip be6f49a425 feat(runner): refresh shared coding harness runtimes (#13838)
## Thinking Path

> - Paperclip runs agents through local adapters and the native runner.
> - Both paths must use the same installed provider CLI.
> - New models require current harness releases.
> - The runner still pins Codex 0.153.4, Claude SDK 0.3.263, and
OpenCode 1.18.29.
> - Changing the image alone would fail the runner's exact version and
executable checks.
> - This pull request updates those dependencies, integrity checks,
controller checks, and image pins together.
> - Shared installations can then run the current models without a
task-time download.

## Linked Issues or Issue Description

Refs #13829, which updates model choices and reasoning controls.
Searches found no open PR that updates these runtime pins.

**Current behavior**

The shared provider pack ships old CLIs. Claude Code 2.1.263 cannot run
Opus 5.5, which requires 2.1.280. Remote controllers reject provider
packs whose versions differ from their declared pins.

**Proposed behavior**

Use Codex 0.156.0, Claude Agent SDK 0.3.280 / Claude Code 2.1.280, and
OpenCode 1.18.32 throughout the runner. Keep the reviewed ACP bridge
patches and one shared CLI installation per provider.

**Reason and benefit**

Current harnesses support the new model IDs while preserving executable
verification and remote provider-pack compatibility checks.

## What Changed

- Update dependency overrides, the Codex ACP package patch, runtime
profiles, and remote controller pins.
- Verify the new Claude Linux x64 and macOS arm64/x64 executables and
Codex Linux x64 executable against integrity-verified npm archives.
- Refresh OpenCode version checks, fixtures, and the runner
configuration label.
- Refresh the eval image's Grok, Gemini, Kimi, Cursor, and GitHub CLI
pins and archive hashes. Hermes remains current at 0.19.0.
- Refresh the build-time lock digest from clean pnpm 9.15.4 resolution.
Leave lockfile commits to repository automation.
- Document model compatibility and the separation between CLI runtimes
and patched ACP bridges.

## Verification

- `pnpm -r typecheck` and `pnpm build` passed.
- Rust workspace release tests passed.
- Package/patch and OpenCode binary-materialization contract tests: 11
passed.
- Real Codex 0.156.0 startup-ownership and paginated session-resume
probes passed with isolated synthetic homes and no model turn.
- Codex app-server `thread/start` preserved `gpt-6-sol` and
`gpt-6-luna`; no `turn/start` was sent. An unauthenticated built-in
catalog does not include those account-served entries.
- Installed Claude integrity probes passed for `claude-opus-5-5` and
`claude-fable-5-1`.
- `pnpm --filter @paperclipai/paperclip-runner
test:opencode:qualification` passed with the actual OpenCode 1.18.32
executable under Node 24 and Node 25. The loopback provider exercise
covers health/version, session creation/read/delete, SSE, and a
completed async prompt.
- `pnpm check:token-gates` passed.
- The targeted runner suite passed 130 tests. Three macOS failures in
snapshot module lookup and OpenCode final-message selection also
reproduce on the unchanged base; Linux CI will provide the platform
check.
- [Final Linux
CI](https://github.com/paperclipai/paperclip/actions/runs/35798076399):
all gates passed. Four jobs needed one retry after their CI workers
received shutdown signals. The PR has 55 successful checks, two skipped
checks, Greptile 5/5, and no unresolved review threads.
- Changed runner configuration UI tests: 5 passed.
- Full macOS `pnpm test:run` reached 13,094 passing server tests, 84
skipped, and 18 failures before the wrapper stopped. Failures involved
skill-cache publication permissions, missing bundled connector skills in
the worktree, and a conversation-reset timing case. The 10 cache
permission failures reproduce on the unchanged base; both
conversation-reset cases passed on a targeted retry. The wrapper did not
reach its later workspace/serialized groups locally; Linux CI covers
those groups.
- The local Docker daemon did not respond, so no local Docker build was
run. No billable model requests were made.

## Risks

- Deploy the matching controller and provider pack together. Older
controllers enforce their previous exact pins.
- Current upstream CLIs can change behavior. Existing protocol tests and
isolated real Codex probes cover the integration boundaries;
authenticated model inference is not part of these checks.
- ACP bridge package versions and executable digests stay unchanged
because their executable bytes are unchanged. Only the underlying
CLI/SDK dependencies move.
- No schema migration. Revert the runtime and image pins together to
roll back.

## Model Used

OpenAI GPT-6 via Codex, with repository tools, code execution, and web
research. The exact serving model ID and context window were not exposed
by this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass for the changed surfaces
and real-executable probes; full macOS-suite limitations are listed
above
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-22 17:02:29 -07:00

136 lines
5.8 KiB
Diff

diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -65,7 +65,7 @@
},
"dependencies": {
"@agentclientprotocol/sdk": "^1.3.0",
- "@openai/codex": "^0.148.0",
+ "@openai/codex": "0.156.0",
"diff": "^9.0.0",
"open": "^11.0.0",
"vscode-jsonrpc": "^9.0.1",
diff --git a/dist/index.js b/dist/index.js
--- a/dist/index.js
+++ b/dist/index.js
@@ -25341,7 +25341,7 @@
async handleElicitation(params) {
try {
const context = this.createMcpElicitationContext(params);
- if (this.shouldUseAcpElicitation(params)) {
+ if (!context.isToolApproval && this.shouldUseAcpElicitation(params)) {
const response2 = await this.connection.request(
methods.client.elicitation.create,
this.buildElicitationRequest(params, context),
@@ -25563,7 +25563,7 @@
toolCall: {
toolCallId: context.correlatedCallId,
kind: "execute",
- status: "pending"
+ status: "pending",
+ rawInput: { serverName: params.serverName }
// content: [messageContent], — omitted: already rendered via item/started
- // rawInput: { ... } — omitted: same reason
},
@@ -26988,4 +26988,18 @@
};
+function paperclipBaseInstructions(request) {
+ if (process.env.PAPERCLIP_ACPX_ISOLATED_CONTEXT !== "1") return void 0;
+ const prompt = request?._meta?.systemPrompt;
+ if (typeof prompt === "string") return prompt;
+ if (prompt && typeof prompt === "object" && typeof prompt.append === "string") {
+ return prompt.append;
+ }
+ return void 0;
+}
+function paperclipSandboxPolicy(sandboxPolicy) {
+ const networkAccess = process.env.PAPERCLIP_CODEX_ACP_NETWORK_ACCESS;
+ if (sandboxPolicy.type !== "workspaceWrite" || !["true", "false"].includes(networkAccess)) return sandboxPolicy;
+ return { ...sandboxPolicy, networkAccess: networkAccess === "true" && process.env.PAPERCLIP_RUNNER_NETWORK_ACCESS !== "disabled" };
+}
var CodexAcpClient = class {
codexClient;
config;
@@ -27288,6 +27297,7 @@
const response = await this.codexClient.threadResume({
config: await this.createSessionConfig(request.cwd, additionalDirectories, request.mcpServers ?? []),
cwd: request.cwd,
+ baseInstructions: paperclipBaseInstructions(request),
modelProvider: await this.getResumeModelProvider(),
threadId: request.sessionId
});
@@ -27310,6 +27320,7 @@
const response = await this.codexClient.threadResume({
config: await this.createSessionConfig(request.cwd, additionalDirectories, request.mcpServers ?? []),
cwd: request.cwd,
+ baseInstructions: paperclipBaseInstructions(request),
modelProvider: await this.getResumeModelProvider(),
threadId: request.sessionId
});
@@ -27337,5 +27348,6 @@
const response = await this.codexClient.threadStart({
config: await this.createSessionConfig(request.cwd, additionalDirectories, request.mcpServers),
modelProvider: this.getModelProvider(),
+ baseInstructions: paperclipBaseInstructions(request),
cwd: request.cwd
});
@@ -27437,5 +27449,12 @@
const mergedConfig = {
...mergeGatewayConfig(this.config, this.gatewayConfig),
+ ...(process.env.PAPERCLIP_ACPX_ISOLATED_CONTEXT === "1" ? {
+ "include_apps_instructions": false,
+ "features.apps": false,
+ "features.memory_tool": false,
+ "skills.include_instructions": true,
+ "mcp_servers": {}
+ } : {}),
projects: Object.fromEntries(sessionRoots.map((root) => [root, {
trust_level: "trusted"
}]))
@@ -27449,7 +27468,7 @@
server: mcp
}));
let serversToConfigure = requestedServers;
- if (shouldDeduplicateMcpConflicts()) {
+ if (process.env.PAPERCLIP_ACPX_ISOLATED_CONTEXT !== "1" && shouldDeduplicateMcpConflicts()) {
const existingNames = await this.getConfigMcpServerNames(projectPath);
serversToConfigure = requestedServers.filter((mcp) => !existingNames.has(mcp.name));
}
@@ -27483,14 +27502,15 @@
async refreshSkills(cwd, additionalRoots) {
if (!cwd) {
return;
}
- const skillExtraRoots = additionalRoots.map((root) => path6.join(root, ".agents", "skills"));
+ const isolated = process.env.PAPERCLIP_ACPX_ISOLATED_CONTEXT === "1";
+ const skillExtraRoots = isolated ? [] : additionalRoots.map((root) => path6.join(root, ".agents", "skills"));
if (!arraysEqual(this.skillExtraRoots, skillExtraRoots)) {
await this.codexClient.skillsExtraRootsSet({ extraRoots: skillExtraRoots });
this.skillExtraRoots = skillExtraRoots;
}
await this.codexClient.listSkills({
- cwds: [cwd, ...additionalRoots],
+ cwds: isolated ? [process.env.CODEX_HOME] : [cwd, ...additionalRoots],
forceReload: true
});
}
@@ -27600,7 +27624,7 @@
threadId: request.sessionId,
input,
approvalPolicy: agentMode.approvalPolicy,
- sandboxPolicy: addAdditionalDirectoriesToSandboxPolicy(agentMode.sandboxPolicy, additionalDirectories),
+ sandboxPolicy: addAdditionalDirectoriesToSandboxPolicy(paperclipSandboxPolicy(agentMode.sandboxPolicy), additionalDirectories),
summary: disableSummary ? "none" : "auto",
effort,
model: modelId.model,
@@ -30595,6 +30614,9 @@
updatedGoal
);
}
+ if (this.goalPublishIsCurrent(sessionState, sessionGeneration)) {
+ await this.publishCurrentGoal(sessionState, sessionGeneration, true);
+ }
} else if (methodRequest.params.action === "pause") {
const goal = await this.runWithProcessCheck(() => this.codexAcpClient.setGoalStatus(sessionState.sessionId, "paused"));
if (this.goalPublishIsCurrent(sessionState, sessionGeneration)) {