mirror of
https://github.com/mvschwarz/openrig.git
synced 2026-10-02 08:35:15 +08:00
v-openrig-buildandClaude Opus 4.8
45d216aab1
The cli tsc resolves @openrig/daemon/crash-cart via the daemon's BUILT dist .d.ts (packaging ruling A + the cli tsconfig paths mapping). The root 'lint' ran daemon tsc with --noEmit (no dist) then cli tsc — so a CLEAN checkout failed cli tsc with TS2307. Fix (smallest honest form — script ordering): a 'typecheck:prep' that builds the daemon dist, run FIRST in 'lint' (&& ordering) so cli tsc cannot run before the dist exists. Makes the repo self-carrying (was only desk-side in desk-fold-gates.sh). Guard: scripts/typecheck-order.test.mjs pins the ordering (prep before cli tsc). RED-first 2/2. Real-run proof: rm daemon/dist → cli tsc TS2307 (constraint); typecheck:prep → cli tsc passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
27 lines
1.3 KiB
JavaScript
27 lines
1.3 KiB
JavaScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { readFileSync } from "node:fs";
|
|
import { fileURLToPath } from "node:url";
|
|
import { dirname, join } from "node:path";
|
|
|
|
// P9 — repo build-order encoding. The cli tsc resolves `@openrig/daemon/crash-cart` via the daemon's
|
|
// BUILT dist .d.ts (packaging ruling A + the paths mapping). So the typecheck-all path must build the
|
|
// daemon dist BEFORE it runs the cli tsc — else a clean checkout fails cli tsc with TS2307. This guard
|
|
// pins that ordering in the repo (self-carrying, not only desk-side).
|
|
|
|
const ROOT = join(dirname(fileURLToPath(import.meta.url)), "..");
|
|
const pkg = JSON.parse(readFileSync(join(ROOT, "package.json"), "utf8"));
|
|
|
|
test("lint builds the daemon dist BEFORE the cli tsc", () => {
|
|
const lint = pkg.scripts.lint;
|
|
const prepAt = lint.indexOf("typecheck:prep");
|
|
const cliTscAt = lint.indexOf("packages/cli/tsconfig");
|
|
assert.ok(prepAt >= 0, "lint must build the daemon dist (typecheck:prep) first");
|
|
assert.ok(cliTscAt >= 0, "lint must typecheck the cli");
|
|
assert.ok(prepAt < cliTscAt, "the daemon-dist build must precede the cli tsc (clean-checkout safety)");
|
|
});
|
|
|
|
test("typecheck:prep builds the daemon (emitting the dist the cli tsc consumes)", () => {
|
|
assert.match(pkg.scripts["typecheck:prep"], /build\b.*packages\/daemon|build -w packages\/daemon/);
|
|
});
|