mirror of
https://github.com/nightly-labs/openbot.git
synced 2026-11-21 12:36:50 +08:00
main
5
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
03c2ff34c2 |
Remove code comments and add the no-comments rule (#12604)
* Remove code comments and add the no-comments rule Remove the comments from first-party code and configuration files: TS/JS, JSX, CSS, SQL migrations, Swift, Kotlin, Gradle, shell, Docker, systemd, Nix, YAML, TOML, JSONC and GritQL. Keep only what a tool reads: license headers, shebangs, compiler and lint directives, JSDoc types in plain .js files, generated file headers, GritQL scope lines, the install-server.sh help text and the openbot-boat-pre-stop marker. Vendored code, fixtures and released schemas keep their comments. Add the rule to AGENTS.md, and change the docs that asked for comments. Add two i18n keys that only comments named to RELEASED_SOURCE_KEYS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep comments that are data in strings The benchmark task files in opencode-free-models-bench.ts tell the model what each function must do. The sample file and HTML page in the two stories are display content. Put their comments back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep released migrations and mobile native inputs unchanged check:migrations compares each released migration with v0.73.0 byte for byte, so restore src/backend/migrations. A change to a native build input of apps/mobile makes a new runtime version, so restore those files and the extra fingerprint sources. List these files and the comment markers that a tool reads in AGENTS.md. Remove the last requests for comments in src/renderer/AGENTS.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d0ff4e715c |
Let a GitHub workflow trigger watch many repositories (#4769)
* Let a GitHub workflow trigger watch many repositories The trigger node keeps the list in the new `repositories` field, one name on each line. `repository` stays the first name, so older hosts and the mobile app continue to work. The reader uses the list only when its first line is the same as `repository`. - Backend: an event from any listed repository starts a run. "Run with last event" asks each repository in order. The "Same as trigger" output acts on the repository of the event. - UI: the repository row shows tags and a menu with check boxes, search, owner groups, and "Private" and "No events" chips. - Long tag names end with an ellipsis. The search divider no longer shows a bright focus line. Closes #4553 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix the review findings of the repository list - A check in the repository menu keeps the rows, so the keyboard focus stays on the row. Space now turns a check row on or off. - A waiting GitHub event of a repository that the trigger no longer watches does not start a run. The e2e script checks this. - The labels of the trigger's repositories are calculated once for each change, not for each tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Remove a stale repository list when the host saves a workflow An older client that changes the repository leaves the old list in the node. The host now removes that list on create and save, so it cannot come back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
180477139d |
Make "Author is not a bot" refuse every bot, OpenBot's too (#4683)
* Make "Author is not a bot" check the author, and refuse OpenBot's bot The GitHub trigger filter checked the event actor and let OpenBot's own bot through. Now it checks the author of the item, comment or review, and refuses every bot account. A check suite names no author, so its actor still counts. "Run with last event" and live events now read the same author. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Name the release notes after the branch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Refuse a bot that acts on a person's item with "not a bot" The filter checked only the author, so a bot that labels or closes a person's issue started runs, and two bots could start runs on each other. Now the filter refuses the event when the actor or the author is a bot. Add e2e checks for both directions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
27718e4f6c |
Keep the files of a Discord mention in GitHub outputs (#4633)
* Keep the files of a Discord mention in GitHub outputs A workflow that a Discord mention starts now keeps the files of the message. The trigger payload has the name, type, size and address of each file, so agent steps can read them. A GitHub output that makes a new issue or a comment downloads the files from Discord and commits them to the orphan `openbot-attachments` branch of the target repository, with `[skip ci]`. The text links them there. GitHub has no attachment API for an App token. A file that is larger than 25 MB, or that cannot be copied, keeps its Discord link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Copy Discord files before the GitHub change is recorded - Copy the files in a new `attachFiles` step before the action is recorded as `sending`. A restart during the copy runs the step again. - Give each download a 2 minute deadline. - A file that GitHub refuses keeps its Discord link. The other files still copy. - Copy up to 50 MB for each change. - Drop whole links when the links are longer than half of the GitHub text limit, so that the text stays. - Type the download error as `MessagingAdapterError`. - Name the files of the replied-to message in PRIVACY.md, the architecture notes and the changelog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Give the upload of a file to GitHub a 2 minute deadline A file of 25 MB is about 33 MB of base64 JSON. A slow upload cannot send it in the usual 30 second deadline of a GitHub call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
39b2a95052 |
Start workflows from GitHub events and change GitHub from workflows (#4288)
* Fix workflow node fades and ports in browsers without scroll timelines Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add the GitHub workflow contract and the workflows-github-v1 capability GitHub is a trigger type, an output target and a run source. The new capability carries the GitHub catalog, repository options, event history and a run with the last event. A client shows a workflow with a trigger type or an output target that it does not know as read-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add migration 49 for GitHub workflow runs, deliveries and actions Migration 49 rebuilds workflow_runs to accept the github run source and keeps every run id. It adds three tables: - workflow_github_runs: the item of each run that a GitHub event started. - workflow_github_deliveries: the event history of each GitHub trigger, and the per-item queue (a waiting row keeps its payload until it starts). - workflow_github_actions: each change that a GitHub output made, so a retry does not repeat it and the loop guard can find its own events. The latest schema takes the same run source line and tables. Tests cover schemas 46 to 48, a late failure and retry, newer and missing histories, constraint refusals and cascades. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Route GitHub App events through Signal to the hosts that watch them Signal gets POST /v1/github/events. It checks the App signature, reads only the installation and repository IDs, and sends the exact body to every host whose GitHub route ticket names the repository. It keeps no body. The account service signs the 5-minute route ticket after it checks, with the host's GitHub sign-in, which watched repositories that sign-in can see. D1 keeps no GitHub route. The host ingress socket holds a GitHub route through the new GitHubRelay, answers github-delivery frames, and records the offline gaps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Start workflow runs from GitHub events, one run per item - Match GitHub events to triggers by repository, event and filters. - Queue an event when a run of its item is open; start it when that run ends. Runs of other items start at the same time. - Skip echoes of the workflow's own actions (self) and the fourth run in 10 minutes that OpenBot's bot caused on one item (chain). - Keep the newest 50 events per trigger and record offline gaps. - Add the refused skip reason and caused_by_bot to the unreleased v49 table. - Add scripts/github-workflow-e2e.ts (host level). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Make the changes of GitHub outputs as OpenBot's bot A GitHub output makes one of the 10 changes through the GitHub REST API with the App's installation token. "Agent chooses" asks a model once and keeps only the repository's own labels and people. Each change writes a `sending` row before the call and a `done` row after it, so a retry does not post twice and the loop guard knows the change's events. A restart sends again only a change that a second call does not repeat. "Run with last event" starts a run with the newest matching item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Show GitHub triggers and outputs on the workflow canvas The trigger and output cards get GitHub rows: repository, event, filters, action, labels and people, with "Agent chooses". The Events row lists what GitHub sent. Access and event alerts open GitHub, and Connect opens the connect dialog of the GitHub settings page. The run bar lists the open runs and the waiting events, and the canvas shows the steps of the open run that the user views. The renderer reads the catalog, labels, people and event history from the host through new IPC reads and Team API routes. GitHub shows only for an owner or admin on a host with workflows-github-v1. Stories replace the prototype stories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Translate the GitHub workflow text into 12 languages Name the GitHub event and action labels as literal catalog keys, and remove two keys that no code uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Test the redaction of GitHub errors, and document GitHub workflows Add a Vitest that checks that GitHub's error text and a failed request put no token into a step's failure. Document the GitHub trigger path, the delivery outcomes and the Team API routes, and add release notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Remove unused GitHub exports, and fix an optional field in the e2e Knip and the exactOptionalPropertyTypes ratchet failed the Check job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Send not_planned to GitHub when an output closes an issue as not planned The saved close reason is notPlanned. GitHub refused it with "Please specify a valid state reason." The adapter now maps each saved reason to the state_reason that GitHub accepts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep trigger events off GitHub, and add repository search and loading rows - A GitHub output removes the framed trigger event from its text. A comment that has only the event fails with a clear error and posts nothing. - The repository menus have a search field. - The Labels and Person menus show "Loading…" while the host reads them. - The log says that the GitHub output failed, not that it made no change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Make each loop pass change GitHub, and keep Telegram when a ticket fails - A GitHub output keys its change by run, node and pass. A loop pass makes its own change. A retry or a restart of the same pass does not make the change again. - When the trigger event comes back in a loop, the output also removes the empty "Input N:" names of the event. - A failed GitHub or webhook ticket does not stop Telegram or the other routes on the shared socket. - The connector reads the App events from GITHUB_ROUTE_EVENTS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Let Signal pass GitHub events of up to 512 KiB An issue_comment or pull_request event can hold two texts of 65,536 characters each. Signal refused such an event with 413, and GitHub does not send it again. - GITHUB_DELIVERY_BODY_BYTES_LIMIT is 512 KiB. - The pending budget for each host is 768 KiB, and the socket backpressure limit is 1 MiB, so the largest event fits. - nginx gets a /v1/github/events location with the same body limit, no access log, and the 10-second wait of GitHub. - The Signal e2e sends the largest event and one above the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep an end marker in a comment inside its event, and stop loading after a failed options read The event frame ends only at the marker on its own line. The JSON of the event keeps no line break, so a commenter cannot end the frame early and get text posted as the bot. A failed read of repository labels and people now stores empty options. The menus stop showing "Loading". A change on GitHub reads them again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |