mirror of
https://github.com/alibaba/open-code-review.git
synced 2026-10-02 09:24:52 +08:00
chethanukandKite
47b9d60774
* feat(viewer): export a session to a self-contained HTML file (#1167) The only renderer for a review session was the live viewer HTTP server, so there was no way to archive a review as a CI artifact. Adds viewer.ExportSession, which drives the same template and the same LoadSession the HTTP handler does, but renders into an io.Writer with both /static/ assets inlined. The assets are passed as template.CSS and template.JS: html/template refuses to interpolate an untyped string into a <style> or <script>, and would silently emit ZgotmplZ for the stylesheet and a JSON string literal for the script. session.html gains three gates on a new Static field, so the served page is unchanged — the field is zero for every HTTP render — while the exported page inlines the assets and de-links the two site-absolute breadcrumb anchors, which are dead over file://. style.css widens nav.breadcrumb a to cover the .crumb span that replaces one of them. Exposed as `ocr session export [session-id]`, on `session` rather than as a `viewer --export` flag because `viewer` is cobra.NoArgs and session_cmd.go already owns session-id resolution and completion. The id is optional and defaults to the newest session: a successful `ocr review` never prints its session id, so requiring one would push every CI archive step through `--format json`. Output goes through the shared --output/-o writer, with "html" added to isMachineReadable so the page is not run through stripAnsiWriter, which would eat the ESC bytes in trace-quoted source. The page is rendered fully into a buffer before the first write, so a failure part-way through Execute cannot leave a truncated file behind. Also adds maximumArgs, mirroring the existing minimumArgs, so the optional positional reports the command's own usage rather than cobra's raw "accepts at most 1 arg(s), received 2". Documented in all five locales of cli-reference.md, including the warning that the artifact embeds reviewed source. Signed-off-by: ChethanUK <chethanuk@outlook.com> * refactor(viewer): share the header brand between served and exported pages Signed-off-by: ChethanUK <chethanuk@outlook.com> * feat: Apply batched suggestions from code review Co-authored-by: Kite <254839944+lizhengfeng101@users.noreply.github.com> --------- Signed-off-by: ChethanUK <chethanuk@outlook.com> Co-authored-by: Kite <254839944+lizhengfeng101@users.noreply.github.com>