## Description
Currently, importing a module also imports its exported sub-modules.
```nushell
use std/dirs
dirs_ # completion triggered
# => dirs
# => dirs add
# => dirs drop
# => dirs goto
# => dirs next
# => dirs prev
# => dirs shells-aliases dexit
# => dirs shells-aliases enter
# => dirs shells-aliases g
# => dirs shells-aliases n
# => dirs shells-aliases p
# => dirs shells-aliases shells
```
This is unexpected (and really annoying).
Also, while it imports the sub-module's definitions, it does not run the
sub-module's `export-env` block.
With this PR:
```nushell
use std/dirs
dirs_ # completion triggered
# => dirs
# => dirs add
# => dirs drop
# => dirs goto
# => dirs next
# => dirs prev
```
To use the aliases, one just needs to `use std/dirs shells-aliases *`
## User-facing changes (Release notes)
Importing a module no longer implicitly imports its exported
sub-modules.
```nushell
export module foo {
export def bar [] {}
export module sub {
export def baz [] {}
}
}
use foo
foo bar # valid
foo sub baz # invalid, `sub` is not implicitly imported
```
To have your modules keep the old behavior, you will need to export the
modules contents explicitly:
```nushell
export module foo {
export def bar [] {}
export module sub {
export def baz [] {}
}
export use sub
}
use foo
foo bar # valid
foo sub baz # valid
```
> [!NOTE]
> `use`ing a module inside another module does *not* run the imported
module's `export-env` block.
> (See [`export-env` runs only when the use call is
evaluated](https://www.nushell.sh/book/modules/creating_modules.html#export-env-runs-only-when-the-use-call-is-evaluated))
> Thus, explicit `use`s as recommended above will not run `export-env`
blocks, which is inline with how the previous implicit imports worked.
should
- close https://github.com/nushell/nushell/issues/11133
# Description
to allow more freedom when writing complex modules, we are disabling the
auto-export of director modules.
the change was as simple as removing the crawling of files and modules
next to any `mod.nu` and update the standard library.
# User-Facing Changes
users will have to explicitely use `export module <mod>` to define
submodules and `export use <mod> <cmd>` to re-export definitions, e.g.
```nushell
# my-module/mod.nu
export module foo.nu # export a submodule
export use bar.nu bar-1 # re-export an internal command
export def top [] {
print "`top` from `mod.nu`"
}
```
```nushell
# my-module/foo.nu
export def "foo-1" [] {
print "`foo-1` from `lib/foo.nu`"
}
export def "foo-2" [] {
print "`foo-2` from `lib/foo.nu`"
}
```
```nushell
# my-module/bar.nu
export def "bar-1" [] {
print "`bar-1` from `lib/bar.nu`"
}
```
# Tests + Formatting
i had to add `export module` calls in the `tests/modules/samples/spam`
directory module and allow the `not_allowed` module to not give an
error, it is just empty, which is fine.
# After Submitting
- mention in the release note
- update the following repos
```
#┬─────name─────┬version┬─type─┬─────────repo─────────
0│nu-git-manager│0.4.0 │module│amtoine/nu-git-manager
1│nu-scripts │0.1.0 │module│amtoine/scripts
2│nu-zellij │0.1.0 │module│amtoine/zellij-layouts
3│nu-scripts │0.1.0 │module│nushell/nu_scripts
4│nupm │0.1.0 │module│nushell/nupm
─┴──────────────┴───────┴──────┴──────────────────────
```