From a85437d470d5f5223f3bcf48dc7337ac5183d5fb Mon Sep 17 00:00:00 2001 From: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Date: Sat, 26 Sep 2026 20:49:27 +0800 Subject: [PATCH] Move the wandb utils tests under tests/ (#3122) --- miles/utils/test_wandb_utils.py | 70 ------------------- tests/ci/test/test_ci_discovery_coverage.py | 5 +- .../utils/tracking_utils/test_wandb_utils.py | 67 ++++++++++++++++++ 3 files changed, 68 insertions(+), 74 deletions(-) delete mode 100644 miles/utils/test_wandb_utils.py diff --git a/miles/utils/test_wandb_utils.py b/miles/utils/test_wandb_utils.py deleted file mode 100644 index 36f46ca30e..0000000000 --- a/miles/utils/test_wandb_utils.py +++ /dev/null @@ -1,70 +0,0 @@ -from types import SimpleNamespace - -from miles.utils.tracking_utils import wandb_utils - - -def _args(**overrides): - values = { - "env_report": None, - "rank": 0, - "sglang_enable_metrics": False, - "use_wandb": True, - "wandb_dir": None, - "wandb_group": "group", - "wandb_host": None, - "wandb_key": None, - "wandb_mode": None, - "wandb_project": "project", - "wandb_random_suffix": False, - "wandb_run_id": None, - "wandb_team": None, - } - values.update(overrides) - return SimpleNamespace(**values) - - -def test_primary_wandb_init_uses_extended_init_timeout(monkeypatch): - init_calls = [] - - monkeypatch.setattr(wandb_utils.wandb, "init", lambda **kwargs: init_calls.append(kwargs)) - monkeypatch.setattr(wandb_utils.wandb, "define_metric", lambda *args, **kwargs: None) - monkeypatch.setattr(wandb_utils.wandb, "run", SimpleNamespace(id="run-id"), raising=False) - - args = _args() - wandb_utils.init_wandb_primary(args) - - settings = init_calls[0]["settings"] - assert settings.mode == "shared" - assert settings.x_primary is True - assert settings.init_timeout == 300.0 - assert args.wandb_run_id == "run-id" - - -def test_primary_wandb_init_resumes_a_preassigned_run(monkeypatch): - """An explicitly assigned run ID lets a replacement primary resume the run.""" - init_calls = [] - - monkeypatch.setattr(wandb_utils.wandb, "init", lambda **kwargs: init_calls.append(kwargs)) - monkeypatch.setattr(wandb_utils.wandb, "define_metric", lambda *args, **kwargs: None) - monkeypatch.setattr(wandb_utils.wandb, "run", SimpleNamespace(id="run-id"), raising=False) - - wandb_utils.init_wandb_primary(_args(wandb_run_id="assigned-run")) - - assert init_calls[0]["id"] == "assigned-run" - assert init_calls[0]["resume"] == "allow" - - -def test_secondary_wandb_init_uses_extended_init_timeout(monkeypatch): - init_calls = [] - - monkeypatch.setattr(wandb_utils.wandb, "init", lambda **kwargs: init_calls.append(kwargs)) - monkeypatch.setattr(wandb_utils.wandb, "define_metric", lambda *args, **kwargs: None) - - args = _args(wandb_run_id="run-id") - wandb_utils.init_wandb_secondary(args) - - settings = init_calls[0]["settings"] - assert settings.mode == "shared" - assert settings.x_primary is False - assert settings.x_update_finish_state is False - assert settings.init_timeout == 300.0 diff --git a/tests/ci/test/test_ci_discovery_coverage.py b/tests/ci/test/test_ci_discovery_coverage.py index daafff33e5..5f4152a7f4 100644 --- a/tests/ci/test/test_ci_discovery_coverage.py +++ b/tests/ci/test/test_ci_discovery_coverage.py @@ -29,10 +29,7 @@ REPO_ROOT = Path(__file__).resolve().parents[3] # Files the rule spares for now. Entries exist to be deleted; adding one is a # decision to defend in review, not a formality. -_KNOWN_ORPHANS = { - # TODO(#2557): move it under tests/ and delete this entry. - "miles/utils/test_wandb_utils.py", -} +_KNOWN_ORPHANS: set[str] = set() def _test_files_outside_the_tests_tree() -> list[str]: diff --git a/tests/fast/utils/tracking_utils/test_wandb_utils.py b/tests/fast/utils/tracking_utils/test_wandb_utils.py index 1b2f45802f..643df00dfb 100644 --- a/tests/fast/utils/tracking_utils/test_wandb_utils.py +++ b/tests/fast/utils/tracking_utils/test_wandb_utils.py @@ -57,3 +57,70 @@ class TestTheLoggedConfig: config = _compute_config_for_logging(make_args(env_report=str(tmp_path / "gone.json"))) assert "launcher_env_report" not in config + + +def _args(**overrides): + values = { + "env_report": None, + "rank": 0, + "sglang_enable_metrics": False, + "use_wandb": True, + "wandb_dir": None, + "wandb_group": "group", + "wandb_host": None, + "wandb_key": None, + "wandb_mode": None, + "wandb_project": "project", + "wandb_random_suffix": False, + "wandb_run_id": None, + "wandb_team": None, + } + values.update(overrides) + return SimpleNamespace(**values) + + +def test_primary_wandb_init_uses_extended_init_timeout(monkeypatch): + init_calls = [] + + monkeypatch.setattr(wandb_utils.wandb, "init", lambda **kwargs: init_calls.append(kwargs)) + monkeypatch.setattr(wandb_utils.wandb, "define_metric", lambda *args, **kwargs: None) + monkeypatch.setattr(wandb_utils.wandb, "run", SimpleNamespace(id="run-id"), raising=False) + + args = _args() + wandb_utils.init_wandb_primary(args) + + settings = init_calls[0]["settings"] + assert settings.mode == "shared" + assert settings.x_primary is True + assert settings.init_timeout == 300.0 + assert args.wandb_run_id == "run-id" + + +def test_primary_wandb_init_resumes_a_preassigned_run(monkeypatch): + """An explicitly assigned run ID lets a replacement primary resume the run.""" + init_calls = [] + + monkeypatch.setattr(wandb_utils.wandb, "init", lambda **kwargs: init_calls.append(kwargs)) + monkeypatch.setattr(wandb_utils.wandb, "define_metric", lambda *args, **kwargs: None) + monkeypatch.setattr(wandb_utils.wandb, "run", SimpleNamespace(id="run-id"), raising=False) + + wandb_utils.init_wandb_primary(_args(wandb_run_id="assigned-run")) + + assert init_calls[0]["id"] == "assigned-run" + assert init_calls[0]["resume"] == "allow" + + +def test_secondary_wandb_init_uses_extended_init_timeout(monkeypatch): + init_calls = [] + + monkeypatch.setattr(wandb_utils.wandb, "init", lambda **kwargs: init_calls.append(kwargs)) + monkeypatch.setattr(wandb_utils.wandb, "define_metric", lambda *args, **kwargs: None) + + args = _args(wandb_run_id="run-id") + wandb_utils.init_wandb_secondary(args) + + settings = init_calls[0]["settings"] + assert settings.mode == "shared" + assert settings.x_primary is False + assert settings.x_update_finish_state is False + assert settings.init_timeout == 300.0