Files
hex/.github/workflows/windows-setup-engine.yml
Dax 538d16f668 windows: sign the setup engine so smart app control can run setup (#1987)
* windows: sign the setup engine so smart app control can run setup

Setup extracts a copy of its engine to %TEMP% at launch and writes the
installed uninstaller from the same bytes. Signing only the outer
hex-setup-*.exe left both unsigned, and Windows 11 Smart App Control
blocked the extracted copy ("Unable to execute file in the temporary
directory", error 4551).

SignedUninstaller embeds the engine's signature, but the signature has to
exist before the compile that uses it, and the compile job holds no
credentials. So the release signs it in two passes: the new
windows-setup-engine.yml compiles once with SignedUninstaller=yes and keeps
the unsigned uninst-*.e32 ISCC asks to be signed (ISCC leaves it and aborts
as a compile failure, exit 2); sign-windows-engine signs and verifies it in
the release environment; windows-installers.yml then compiles with the
signed engine and asserts the installed uninstaller's signature.

Test builds and runs without the Azure values keep the unsigned single
compile. Inno Setup is pinned to 6.7.1, read from the compiler's own banner
(ISCC.exe's version resource is 0.0.0), so both passes use one compiler.

* windows: harden the setup engine passes

Review fixes for the signed setup engine:

- sign-windows-engine requires sign-windows to have succeeded, and its
  steps are unguarded like sign-windows-installers, so it can never upload
  an empty digest.
- setup-engine runs only when Windows is signed (it waits for
  sign-windows), so unsigned runs really do a single compile with no
  engine pass at all.
- the Inno re-pin uses choco upgrade --allow-downgrade, because choco
  install --version treats a preinstalled package as already installed.
- Invoke-Iscc collects native stderr safely under Windows PowerShell 5.1
  and pwsh with $PSNativeCommandUseErrorActionPreference on, and echoes
  the compiler's lines so build logs stay readable.
- the version probe compiles a minimal script from standard input into a
  throwaway OutputDir, so it never touches the caller's -OutDir.
- only .e32 exists for the engine; drop the unused .e64 handling.
- the uninstaller signature test also checks the release publisher, and
  the test-builds doc warns that Smart App Control cannot be turned back
  on without resetting Windows.

* windows: correct the setup engine comments
2026-11-19 02:38:03 -05:00

80 lines
3.2 KiB
YAML

name: Windows setup engine
# Compiles packaging/windows/hex.iss with SignedUninstaller=yes so the compiler
# leaves the unsigned uninst-<version>-<hash>.e32 it asks to have signed
# (scripts/build-windows-installer.ps1 -ExtractSignedEngine). Release signs that
# file in its release environment (sign-windows-engine), then runs
# windows-installers.yml with it, so the installed uninstaller and the copy
# Setup extracts to %TEMP% at launch carry the release signature; Smart App
# Control blocks them when they do not (docs/windows-signing.md). Repository
# code runs here, so there is no environment, no secret, and no id-token.
on:
workflow_call:
inputs:
sha:
required: true
type: string
version:
required: true
type: string
pattern:
description: Artifact name pattern of the executables the compile wraps
required: true
type: string
digests:
description: Space-separated name=digest pairs for those artifacts
required: true
type: string
artifact-name:
description: The setup engine's artifact
required: true
type: string
retention-days:
type: number
default: 0
outputs:
digest:
value: ${{ jobs.extract.outputs.digest }}
permissions:
contents: read
jobs:
extract:
name: Compile for the setup engine
runs-on: windows-latest
timeout-minutes: 20
env:
HEX_VERSION: ${{ inputs.version }}
outputs:
digest: ${{ steps.upload.outputs.digest }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: ${{ inputs.sha }}
persist-credentials: false
- uses: ./.github/release/download
with:
pattern: ${{ inputs.pattern }}
digests: ${{ inputs.digests }}
- name: Compile for the unsigned setup engine
shell: pwsh
run: |
$out = New-Item -ItemType Directory -Force "$env:RUNNER_TEMP/engine"
foreach ($arch in 'x86_64', 'aarch64') {
$label = if ($arch -eq 'x86_64') { 'x64' } else { 'arm64' }
$exe = @(Get-ChildItem "$env:RUNNER_TEMP/in" -Recurse -Filter "hex-$env:HEX_VERSION-windows-$label.exe")
if ($exe.Count -ne 1) { throw "Expected one hex-$env:HEX_VERSION-windows-$label.exe, found $($exe.Count)." }
$console = @(Get-ChildItem "$env:RUNNER_TEMP/in" -Recurse -Filter "hex-$env:HEX_VERSION-windows-$label.com")
if ($console.Count -ne 1) { throw "Expected one hex-$env:HEX_VERSION-windows-$label.com, found $($console.Count)." }
scripts/build-windows-installer.ps1 -Executable $exe[0].FullName -Console $console[0].FullName -Version $env:HEX_VERSION -Arch $arch -OutDir $out -ExtractSignedEngine
}
Get-ChildItem $out | Where-Object { $_.Name -notlike 'uninst-*.e32' } | Remove-Item -Force
Get-ChildItem $out | Select-Object Name, Length | Format-Table -AutoSize | Out-String | Write-Output
- id: upload
uses: ./.github/release/upload
with:
name: ${{ inputs.artifact-name }}
path: ${{ runner.temp }}/engine
retention-days: ${{ inputs.retention-days }}