mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-11-22 13:29:19 +08:00
## Description `headroom/graph/installer.py` had its own downloader for the codebase-memory-mcp binary: `download_cbm` and `ensure_cbm`, plus platform, asset-name and zip helpers. `headroom wrap` stopped calling `ensure_cbm()` indca9853e(#1230), when tokensave and Serena replaced codebase-memory-mcp in wrap. Since then the only product user of the module is the `--code-graph` watcher (`graph/watcher.py:121`). It calls only `get_cbm_path()`. The downloader duplicated `headroom.binaries` (the same `tools.json` pin, the same verification), and only its tests kept it alive. This PR keeps `get_cbm_path`, `_installed_name`, `CBM_BIN_DIR` and `CBM_BIN_NAME`, and removes the rest. Evidence: - `grep -rnw` for `download_cbm`, `ensure_cbm`, `_detect_platform`, `_asset_filename`, `_extract_from_zip`, `CBM_VERSION`, `CBM_REPO` and `GITHUB_RELEASE_URL` found only `installer.py` and tests. The search covered `headroom crates plugins sdk docs wiki scripts benchmarks examples e2e .github` and the consumer repos. - `git show dca9853e` shows the removed `from headroom.graph.installer import ensure_cbm, get_cbm_path` in `cli/wrap.py`. - `installer.py` has no `__all__`. `headroom/graph/__init__.py` re-exports nothing. Neither is documented. **`binaries.resolve` vs `get_cbm_path` check (requested before deleting).** - `binaries.resolve("codebase-memory-mcp")` installs to `binaries.cache_dir()/codebase-memory-mcp-<version>-<platform>/codebase-memory-mcp`. The same goes for `headroom tools install` and `ensure_tools()` at proxy startup with `--intercept-tool-results`. On macOS that is `~/Library/Caches/headroom/bin/...`; elsewhere it is the platform cache dir or `HEADROOM_BINARIES_CACHE`. - `get_cbm_path()` looks on `PATH` and then in `~/.local/bin` only. - So a binary installed through `headroom.binaries` is **not** found by the watcher unless that cache dir is on `PATH`. This gap already exists on main and this PR does not change it. - The removed `download_cbm` did install into `~/.local/bin`, but nothing has called it since #1230. - A follow-up could make `get_cbm_path()` also try `binaries.which("codebase-memory-mcp")`. I left that out because it is a behaviour change. Refs #4136 ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [x] Code refactoring (no functional changes) ## Changes Made - `headroom/graph/installer.py`: - Remove `download_cbm`, `ensure_cbm`, `_detect_platform`, `_asset_filename` and `_extract_from_zip`. - Remove the constants `CBM_VERSION`, `CBM_REPO` and `GITHUB_RELEASE_URL`, and the imports only they used. - The module docstring now says what the module does: it locates the binary. - `headroom/offline.py`: the docstring lists codebase-memory-mcp under release-binary downloads. - Tests: - `tests/test_graph.py`: drop the platform, download and ensure tests. - `tests/test_graph_installer.py`: rewrite the real-PATH-lookup test so it creates the binary directly instead of through `download_cbm`, and keep the off-PATH test. - `tests/test_binaries_refusal_reaches_callers.py`: drop the two `ensure_cbm` tests. - `tests/test_offline_egress_chokepoint.py`: drop `test_cbm_download_opens_no_socket`. - The watcher tests are unchanged. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [ ] New tests added for new functionality - [x] Manual testing performed ### Test Output ```text $ pytest -q -p no:cacheprovider tests/test_graph.py tests/test_graph_installer.py tests/test_binaries_refusal_reaches_callers.py tests/test_offline_egress_chokepoint.py tests/test_litellm_optional.py tests/test_binaries.py FAILED tests/test_offline_egress_chokepoint.py::TestHeadroomCloudCompressionOffline::test_asgi_middleware_opens_no_socket FAILED tests/test_offline_egress_chokepoint.py::TestHeadroomCloudCompressionOffline::test_litellm_callback_opens_no_socket ======================== 2 failed, 188 passed in 16.14s ======================== # The same two fail on a clean origin/main (2 failed, 141 passed for that file), so they are pre-existing and unrelated. $ mypy headroom/graph/installer.py headroom/graph/watcher.py --ignore-missing-imports Success: no issues found in 2 source files $ uvx ruff@0.16.8 check <changed files> All checks passed! ``` ## Real Behavior Proof - Environment: macOS, Python 3.12.13, repo .venv, branch checkout at0cbd67d6(basea9815bbb), temp HOME / HEADROOM_WORKSPACE_DIR / CODEX_HOME, offline. - Exact command / steps: - Ran the shared smoke harness with `--code-graph`. It starts a real proxy from this checkout against a local fake upstream and sends one Anthropic and one OpenAI request with a compressible tool result. - Ran a direct script with a stub `codebase-memory-mcp` in the temp `~/.local/bin`. It calls `get_cbm_path` and starts the real `CodeGraphWatcher`, then repeats both with the binary removed. - Ran the graph, installer, binaries and offline-egress tests. - Observed result: - With `--code-graph`, the proxy starts and both requests return HTTP 200 with savings. The temp HOME has no binary, so the watcher stays off, which is unchanged and logged at DEBUG only. - With the stub present, `get_cbm_path` finds it and the watcher starts. Without it, both return None/False. - 188 tests pass. The 2 failures are pre-existing on main. - Not tested: Indexing with a real codebase-memory-mcp binary. `get_cbm_path` and the watcher are unchanged. ```text $ bash smoke.sh <worktree> --code-graph branch: cleanup/memory-cache-graph-downloader @0cbd67d6health: 200 POST /v1/messages -> HTTP200 smoke-ok POST /v1/chat/completions -> HTTP200 smoke-ok stats: requests=2 failed=0 tokens_saved=13574 savings_percent=99.82 proxy.log WARNING/ERROR lines: 2 headroom.proxy - WARNING - event=proxy_offline_mode air-gap active — every connection Headroom initiates is refused (telemetry, update check, license reporter, model/tokenizer/binary/dataset downloads, remote Kompress, OTLP/Langfuse export, Copilot auth, subscription polling, OpenAI embedders, Headroom Cloud compression). Still allowed on purpose: forwarding your requests to the upstream you 4 headroom.transforms.kompress_compressor - WARNING - Kompress: artifact prefetch found no usable file for chopratejas/kompress-v2-base 4 headroom.transforms.kompress_compressor - WARNING - Kompress: artifact prefetch refused for chopratejas/kompress-v2-base (HEADROOM_OFFLINE is set): HEADROOM_OFFLINE is set: refusing outbound network access for HuggingFace download of chopratejas/kompress-v2-base/onnx/kompress-int8-wo.onnx to huggingface.co. Unset HEADROOM_OFFLINE, or turn off the feature that needs this connection. $ HOME=$TMP/home HEADROOM_WORKSPACE_DIR=$TMP/ws CODEX_HOME=$TMP/codex python -u -c "<get_cbm_path(); CodeGraphWatcher(project_dir).start(); remove stub; repeat>" get_cbm_path() -> $TMP/home/.local/bin/codebase-memory-mcp watcher.start() -> True without binary: get_cbm_path() -> None ; start() -> False ``` ## Runtime Rollout Safety - Rollout-managed feature(s): None. - Minimum rollout channel: N/A; dead-code removal. - Stable/default behavior changed: No. Nothing called the removed downloader. - Kill switch / disable path: N/A. - Unsafe override required: No. - Qualification impact: None. - Rollback path: Revert this commit. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] I did **not** edit `CHANGELOG.md` — it is generated by release-please from my Conventional Commit PR title (a CI guard enforces this) ## Screenshots (if applicable) N/A. ## Additional Notes Part of maintainer-requested cleanup #4136 (dead code, duplication, debuggability), split into small PRs for review. Follow-ups, out of scope here: - the install-location gap described above; - `binaries.verify_download_bytes`, whose only product caller was the removed `download_cbm`. It is now used only by `tests/test_binaries.py`, and its docstring still names codebase-memory-mcp. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
50 lines
1.9 KiB
Python
50 lines
1.9 KiB
Python
"""Locating the codebase-memory-mcp binary for the code-graph watcher."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import platform
|
|
import shutil
|
|
import stat
|
|
from pathlib import Path
|
|
|
|
from headroom.graph import installer
|
|
|
|
|
|
def test_installed_binary_is_found_by_a_real_path_lookup(monkeypatch, tmp_path: Path) -> None:
|
|
"""A binary named the way ``get_cbm_path`` expects must be what
|
|
``shutil.which`` resolves on this host.
|
|
|
|
Nothing about the file name is mocked: on Windows this needs the .exe
|
|
extension, elsewhere the extensionless name with its executable bit.
|
|
"""
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
path = bin_dir / installer._installed_name(platform.system().lower())
|
|
path.write_bytes(b"#!/bin/sh\necho codebase-memory-mcp test\n")
|
|
path.chmod(path.stat().st_mode | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH)
|
|
monkeypatch.setattr(installer, "CBM_BIN_DIR", bin_dir)
|
|
|
|
monkeypatch.setenv("PATH", str(bin_dir))
|
|
found = shutil.which("codebase-memory-mcp")
|
|
assert found is not None
|
|
assert Path(found).samefile(path)
|
|
assert installer.get_cbm_path() == Path(found)
|
|
|
|
|
|
def test_get_cbm_path_finds_the_installed_binary_off_path(monkeypatch, tmp_path: Path) -> None:
|
|
empty_dir = tmp_path / "empty"
|
|
empty_dir.mkdir()
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
monkeypatch.setenv("PATH", str(empty_dir))
|
|
monkeypatch.setattr(installer, "CBM_BIN_DIR", bin_dir)
|
|
monkeypatch.setattr(installer.platform, "system", lambda: "Windows")
|
|
(bin_dir / "codebase-memory-mcp.exe").write_bytes(b"MZ fake binary")
|
|
|
|
assert installer.get_cbm_path() == bin_dir / "codebase-memory-mcp.exe"
|
|
|
|
monkeypatch.setattr(installer.platform, "system", lambda: "Linux")
|
|
assert installer.get_cbm_path() is None
|
|
(bin_dir / "codebase-memory-mcp").write_bytes(b"#!/bin/sh\n")
|
|
assert installer.get_cbm_path() == bin_dir / "codebase-memory-mcp"
|