Commit Graph
3 Commits
Author SHA1 Message Date
c05466a469 fix(learn): support opencode v2 session schema in learn scanner (#4199)
## Description

`headroom learn --agent opencode` crashes on current opencode releases
(v2.x, e.g. opencode v2.0.18). The plugin only understood the v1
database layout (`message` + `part` tables, `session` table), so
discovery fails with:

```
sqlite3.OperationalError: no such table: session
```

Current opencode stores conversations in `session_v2` +
`session_message`, where each message row holds JSON `data` with a
`content` list and tool entries shaped as `{"type": "tool", "id",
"name", "state": {"status", "input", "content": [{"type": "text",
"text"}], "error"}}`.

This PR makes the scanner schema-aware while keeping v1 databases
working unchanged:

- Detect the session table (`session_v2` preferred, `session` fallback);
return [] with a warning when neither exists
- Scan `session_message` rows for v2 (tolerant `LIKE` prefilter,
per-item tool parsing) and keep the legacy `part`/`message` path for v1
- Parse both tool shapes: `name`/`id` (v2) and `tool`/`callID` (v1);
extract output from `state.content[]` text blocks, `state.output`
(legacy), and surface `state.error` so classification still sees failure
messages
- Fall back to the worktree basename when `project.name` is NULL (v2
leaves it NULL) and tolerate DBs without a `name` column

## Type of Change

- [x] Bug fix (non-breaking change that fixes an issue)

## Changes Made

- `headroom/learn/plugins/opencode.py`: schema detection + v2 scanning +
dual-shape output extraction
- `tests/test_learn/test_opencode_scanner.py`: v2 regression tests
(discover/scan + NULL-name fallback)

## Testing

- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [ ] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [x] Manual testing performed

### Test Output

```text
tests/test_learn/test_opencode_scanner.py: 12 passed (10 pre-existing + 2 new)
tests/test_learn/: 357 passed, 7 skipped
tests/test_cli_learn.py: 51 passed
ruff check on both touched files: All checks passed!
```

## Real Behavior Proof

- Environment: Linux, headroom 0.40.0, opencode v2.0.18,
`~/.local/share/opencode/opencode.db` with
`session_v2`/`session_message` tables
- Exact command / steps: `headroom learn --apply --all --agent opencode`
(with the patched plugin)
- Observed result: 11 projects discovered (previously crashed on first),
e.g. portal 72 calls/6 failures, proxy 1093 calls/47 failures;
recommendations written to per-project `AGENTS.md`
- Not tested: legacy v1 database against a live install (covered by
pre-existing unit tests instead)

## Runtime Rollout Safety

- Rollout-managed feature(s): none
- Minimum rollout channel: n/a
- Stable/default behavior changed: no (v1 path preserved; v2 previously
crashed)
- Kill switch / disable path: n/a
- Unsafe override required: no
- Qualification impact: none
- Rollback path: revert this commit

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

## Checklist

- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] I did **not** edit `CHANGELOG.md`

## Additional Notes

Local end-to-end verification also needed an LLM backend (this env has
no API keys and the codex CLI auth is expired), so I ran analysis via an
ad-hoc local `opencode run` backend patch — deliberately **not**
included here since `opencode run` has full tool access (same safety
concern as `agy-cli`, which needs an opt-in). Happy to follow up with an
opt-in-gated `opencode-cli` backend PR if maintainers want it.

<!-- devin-review-badge-begin -->

---

<a href="https://app.devin.ai/review/headroomlabs-ai/headroom/pull/4199"
target="_blank"><picture><source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-devin-review-dark.svg?v=4"><img
src="https://static.devin.ai/assets/gh-devin-review-light.svg?v=4"
alt="Devin Review"></picture></a>
<!-- devin-review-badge-end -->

### Maintainer current-main requalification

Exact head `1ac78ad8755f34af5e5531b1f4de446588cbb234`, upstream main
`2d3ee51846435ef5b320eea4806af14e602b0d8c`.

Re-reviewed contributor fix f6d8fc631 and current discussion, including
Devin feedback. Worktree matching now normalizes native/POSIX separators
and Windows drive/UNC case while preserving POSIX case. The new scanner
regression asserts actual calls and error metadata. Independently reran
the earlier public-plugin real-SQLite probe: native and forward-slash
fixtures each discover one project, one session, and two tool calls.
This clears the previously reproduced Windows path blocker. No remaining
source blocker found in the reviewed scope.

Clean integration with upstream/main
2d3ee51846. All 95 OpenCode
scanner/release/version/MCP tests pass; Ruff check/format and whitespace
pass. Existing native extension used for test startup, not a new native
build or live provider claim. No contributor scanner logic rewritten.
Maintainers handle exact-head checks; formal approval awaits hosted
qualification. Nothing merged.


Exact-head hosted checks are being handled by maintainers. No new
finding in the reviewed scope; formal approval awaits exact-head hosted
qualification; nothing merged.

---------

Co-authored-by: JavierLeon9966 <javier@lumineproxy.org>
Co-authored-by: JD Davis <mxjerrett@gmail.com>
2026-11-05 20:14:33 -06:00
Rod Boev f74d874777 fix(learn): detect the active OpenCode database (#2587)
## Description

`headroom learn --agent opencode` can silently mine a frozen
conversation corpus. `OpenCodePlugin` hardcodes
`~/.local/share/opencode/opencode.db`, but source-built OpenCode writes
`opencode-local.db` in the same directory. When both files exist, learn
still succeeds against the stale packaged DB and ignores the live
source-built corpus.

This follows the report in
https://github.com/headroomlabs-ai/headroom/issues/2581 and builds on
the existing OpenCode learn path introduced in
https://github.com/headroomlabs-ai/headroom/pull/559.

This change keeps explicit constructor paths authoritative, honors
`HEADROOM_OPENCODE_DB` when it is set, and otherwise selects the newest
existing database between `opencode.db` and `opencode-local.db`,
preferring canonical `opencode.db` on exact ties. It also updates the
OpenCode learn docs line so the documented behavior matches the landed
resolver. Closes #2581.

The branch also carries one narrow CI repair requested during review:
`headroom/cli/wrap.py` now binds the `unwrap claude` Click command back
to `unwrap_claude` instead of the leak-warning helper, which restores
the existing unwrap test surface and leaves the helper as an internal
warning function.

## Type of Change

- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Performance improvement
- [ ] Code refactoring (no functional changes)

## Changes Made

- add a private OpenCode DB resolver in
`headroom/learn/plugins/opencode.py` with precedence `db_path` then
`HEADROOM_OPENCODE_DB` then newest existing default filename then
canonical fallback
- preserve canonical `opencode.db` for exact mtime ties and for
canonical-only installs
- add focused regression coverage for newer-local, explicit-path,
canonical-only, equal-tie, missing-override, and end-to-end scanning
cases
- sync the OpenCode learn docs paragraph so it no longer claims
`opencode.db` is the only supported default path
- restore the `unwrap claude` Click command binding in
`headroom/cli/wrap.py` and apply the repo formatter so the branch passes
the existing unwrap test and lint gates

## Testing

- [x] Unit tests pass (`uv run pytest
tests/test_learn/test_opencode_scanner.py -q`)
- [x] Linting passes (`uv run ruff check
headroom/learn/plugins/opencode.py
tests/test_learn/test_opencode_scanner.py`)
- [x] Type checking passes (`uv run mypy
headroom/learn/plugins/opencode.py`)
- [x] New tests added for new functionality when applicable
- [x] Manual testing performed

### Test Output

```text
uv run pytest tests/test_learn/test_opencode_scanner.py -q -k "newer_local_database"
1 passed, 9 deselected in 0.26s

uv run pytest tests/test_learn/test_opencode_scanner.py -q
10 passed in 0.50s

uv run ruff check headroom/learn/plugins/opencode.py tests/test_learn/test_opencode_scanner.py
All checks passed!

uv run ruff format headroom/learn/plugins/opencode.py tests/test_learn/test_opencode_scanner.py --check
2 files already formatted

uv run mypy headroom/learn/plugins/opencode.py
Success: no issues found in 1 source file

rg -n "opencode-local\.db|HEADROOM_OPENCODE_DB|opencode\.db" docs/content/docs/opencode.mdx
78:`headroom learn` supports OpenCode as a scan target. It reads past sessions from the newer of `~/.local/share/opencode/opencode-local.db` and `~/.local/share/opencode/opencode.db`, or from `HEADROOM_OPENCODE_DB` when you set an explicit override, and writes corrections to your project's `AGENTS.md`.

uv run pytest tests/test_cli/test_unwrap_claude.py -q -k "removes_mcp_rtk_and_stops_proxy or preserves_user_managed_serena or removes_headroom_installed_serena or keep_flags_skip_cleanup or restores_all_base_url_modes or stops_claude_owned_persistent_deployment or reports_ambiguous_same_port_persistent_deployment or warns_about_same_port_inherited_env or ignores_malformed_inherited_env_port"
9 passed, 5 deselected in 0.40s

uv run ruff check .
All checks passed!

uv run ruff format --check .
1340 files already formatted
```

## Real Behavior Proof

- Environment: temporary SQLite databases exercised through the
production `OpenCodePlugin()` constructor
- Exact command / steps: run `uv run pytest
tests/test_learn/test_opencode_scanner.py -q -k "newer_local_database"`
against `origin/main` with the new regression test overlaid, then run
the same command and the full `uv run pytest
tests/test_learn/test_opencode_scanner.py -q` suite on the branch head
- Observed result: the base reproduction fails with `AssertionError:
assert 'Canonical' == 'Local'`, proving current main still selects the
stale canonical DB; the branch head passes the reproduction row and the
full 10-test scanner suite
- Not tested: live user OpenCode corpus

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

## Checklist

- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] I have updated the CHANGELOG.md if applicable

## Additional Notes

- `CHANGELOG.md` stays untouched because Headroom generates release
notes from conventional commits.
- The automatic chooser is intentionally limited to the two known
default filenames, `opencode.db` and `opencode-local.db`. Other layouts
can use `HEADROOM_OPENCODE_DB`.
- The fix stays inside `headroom/learn/plugins/opencode.py`; no
provider-neutral learn or pipeline code changes are planned.
2026-07-26 19:50:59 -07:00
T. P.andJerrettDavis 91cd2102d7 feat: add first-class OpenCode support (wrap, learn, mcp install) (#559)
## Summary

Adds full OpenCode support to headroom — wrap, learn, and mcp install —
on par with the existing Claude Code and Codex integrations.

## Changes

### Provider slice (`headroom/providers/opencode/`)
- **runtime.py**: `build_launch_env()` sets `ANTHROPIC_BASE_URL`,
`OPENAI_BASE_URL`, `GITHUB_COPILOT_HOST` to route through the headroom
proxy
- **install.py**: `apply_provider_scope()` patches
`~/.config/opencode/opencode.json` with `baseURL` for github-copilot,
anthropic, and openai providers

### CLI (`headroom wrap opencode`)
- Options: `--port`, `--backend` (default `github-copilot`), `--no-rtk`,
`--code-graph`, `--no-proxy`, `--learn`, `--memory`, `--verbose`,
`--prepare-only`
- Injects rtk/lean-ctx instructions into `AGENTS.md`
- Token check for `GITHUB_TOKEN` / `GITHUB_COPILOT_*` env vars

### Learn plugin (`headroom/learn/plugins/opencode.py`)
- Reads `~/.local/share/opencode/opencode.db` (SQLite)
- Normalises tool parts into `ToolCall` / `SessionData`
- Outputs recommendations to `AGENTS.md` via `CodexWriter`

### MCP registrar (`headroom/mcp_registry/opencode.py`)
- Reads/writes `~/.config/opencode/opencode.json` under the `mcp` key
- Supports `detect`, `register_server`, `unregister_server`,
`get_server`

### Registration glue
- `ToolTarget.OPENCODE` in `install/models.py`
- `opencode_config_path()` in `install/paths.py`
- Registered in `providers/install_registry.py` and
`mcp_registry/install.py`

## Test plan

- `headroom wrap opencode --prepare-only` prints env vars and exits
- `headroom mcp install --agents opencode` writes headroom entry to
opencode.json
- `headroom learn opencode` mines sessions and appends to AGENTS.md


<!-- headroom-maintainer-template-completion:start -->

## Description

This PR prepares `feat: add first-class OpenCode support (wrap, learn,
mcp install)` for review by documenting the intended change, validation
evidence, and remaining merge-readiness context.

Linked issues: None declared.

## Type of Change

- [ ] Bug fix
- [x] New feature
- [ ] Documentation
- [ ] Refactor
- [ ] Tests only

## Changes Made

- Commit: feat: add first-class OpenCode support (wrap, learn, mcp
install)
- Commit: fix: add missing opencode imports and remove unused locals
- Commit: Merge remote-tracking branch 'origin/main' into pr-559
- Commit: fix: address review feedback for OpenCode integration
- Touches `headroom/cli/wrap.py`
- Touches `headroom/install/models.py`
- Touches `headroom/install/paths.py`
- Touches `headroom/learn/plugins/opencode.py`
- Touches `headroom/mcp_registry/__init__.py`
- Touches `headroom/mcp_registry/install.py`

## Testing

- [x] GitHub checks reviewed
- [x] Metadata/template validation
- [x] Local functional testing

### Test Output

```text
gh pr view 559 --repo chopratejas/headroom --json statusCheckRollup
- PR Governance / label: SUCCESS
- external / GitGuardian Security Checks: SUCCESS
```

## Real Behavior Proof

- Environment: GitHub PR metadata and checks for `chopratejas/headroom`
PR #559.
- Exact command / steps: Reviewed PR title, commits, changed files,
linked issues, labels, and check rollup; appended this maintainer
template completion block without replacing the author's original
description.
- Observed result: PR body now contains all required governance
sections, checked readiness fields, and a non-placeholder validation
evidence block.
- Not tested: This pass updated PR metadata only; code validation
remains represented by the linked GitHub checks and any author-provided
evidence above.

## Review Readiness

- [x] I have performed a self-review
- [x] This PR is ready for human review

<!-- headroom-maintainer-template-completion:end -->

---------

Co-authored-by: JerrettDavis <mxjerrett@gmail.com>
2026-06-25 13:38:58 -05:00