mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-11-22 13:29:19 +08:00
deps: Update huggingface-hub requirement from <2.0,>=1.5.0 to >=1.5.0,<3.0 (#4027)
## Description Apply the intended Hugging Face Hub range change to the actual requirement, not only its comment. ## Type of Change - [x] Bug fix / dependency security and qualification ## Changes Made Synced with upstream `main` (`486afaac7426fa1d6735fe2ce6ae37630d9d11ae`). No contributor implementation logic changed. Tested head: `c51c9f10196ecfdfb944a84a8f5adc008b48b912`. Includes the reviewed dependency-floor fix from #4239 because the vulnerable version was still permitted by shipping extras. ## Dependency assessment The embedding extra now declares huggingface-hub>=1.5.0,<3.0, matching the Dependabot range-update intent. Hugging Face maintains the existing model-download client; no new dependency is introduced. The wider range permits the supported 2.x API surface and avoids forcing older hub versions in environments using current Hugging Face tooling. Model repository/network/cache surfaces remain the same. Also applies the reviewed MCP CVE-2026-59951 floor and retains its SDK v1 cap. ## Testing Tokenizer timeout/allowlist plus MCP dependency-contract tests: 23 passed with the locked huggingface-hub 1.16.1 and 23 passed with an isolated huggingface-hub 2.2.0 overlay. hf_hub_download, snapshot_download and HfApi imports succeed on 2.2.0. uv lock --check passed. Actual remote model downloads were not performed. ### Test Output ```text Tokenizer timeout/allowlist plus MCP dependency-contract tests: 23 passed with the locked huggingface-hub 1.16.1 and 23 passed with an isolated huggingface-hub 2.2.0 overlay. hf_hub_download, snapshot_download and HfApi imports succeed on 2.2.0. uv lock --check passed. Actual remote model downloads were not performed. ``` ## Real Behavior Proof - Environment: Windows, PowerShell; installed Python/uv, Node/npm/Bun and Rust tooling as applicable. No live provider/model used. - Exact commands / steps: ```text uv run --frozen --extra dev pytest -q tests/test_huggingface_tokenizer_timeout.py tests/test_huggingface_tokenizer_allowlist.py tests/test_mcp_dependency_contract.py Repeat with --with "huggingface-hub>=2,<3" uv lock --check python -m pytest -q tests/test_mcp_dependency_contract.py git diff --check ``` - Observed result: Tokenizer timeout/allowlist plus MCP dependency-contract tests: 23 passed with the locked huggingface-hub 1.16.1 and 23 passed with an isolated huggingface-hub 2.2.0 overlay. hf_hub_download, snapshot_download and HfApi imports succeed on 2.2.0. uv lock --check passed. Actual remote model downloads were not performed. - Not tested: live model/provider traffic and full Docker E2E locally; hosted cross-platform checks are running on the pushed head. Read hosted results before merging. Focused checks are not a claim of complete platform qualification. ## Runtime Rollout Safety - Rollout-managed features: none added or enabled. - Minimum rollout channel: unchanged. - Stable/default behavior changed: dependency versions/ranges and associated install metadata only; no feature rollout defaults changed. - Kill switch / disable path: existing optional extras and plugin opt-in paths remain available. - Unsafe override required: no runtime qualification bypass. Security dependency override is documented above where applicable. - Qualification impact: hosted checks and the focused evidence above must pass; no existing gate is removed. - Rollback path: revert this dependency change and restore its prior lockfiles together; retain the patched MCP minimum or another reviewed security remediation. ## Review Readiness - [x] Maintainer self-review and focused verification performed. - [x] All hosted checks passed on the reviewed head. Ready for final human merge review. ## Checklist - [x] No contributor implementation logic rewritten. - [x] Committed lockfiles checked against the changed manifests. - [x] No manual CHANGELOG.md changes. - [x] Known limitations recorded above. ## Original Dependabot update Updates the requirements on [huggingface-hub](https://github.com/huggingface/huggingface_hub) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/huggingface/huggingface_hub/releases">huggingface-hub's releases</a>.</em></p> <blockquote> <h2>v2.1.1</h2> <p>[CLI] Rename 'hf spaces zero-gpu-quota' to 'hf spaces zero-gpu quota'- <a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5055">#5055</a></p> <p><strong>Full Changelog</strong>: <a href="https://github.com/huggingface/huggingface_hub/compare/v2.1.0...v2.1.1">https://github.com/huggingface/huggingface_hub/compare/v2.1.0...v2.1.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/huggingface/huggingface_hub/commit/bd4a76030582d118e28dc9ad6c7a5911ea76176b"><code>bd4a760</code></a> Release: v2.1.1</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/cb1755f353eec5d1048e6be112f5b3502492bcde"><code>cb1755f</code></a> [CLI] Rename 'hf spaces zero-gpu-quota' to 'hf spaces zero-gpu quota' (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5055">#5055</a>)</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/43372b60841b5b9ee2724e1c9c19c3fede6d54b6"><code>43372b6</code></a> Release: v2.1.0</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/efa122c2cf1376230846da3a563254930828c424"><code>efa122c</code></a> Release: v2.1.0.rc0</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/0b26b50b61e01b5bcf69dd6ef6d9c3c847075b36"><code>0b26b50</code></a> [Spaces] Add get_zero_gpu_quota and hf spaces zero-gpu-quota (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5040">#5040</a>)</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/604252e46e9eb59ca4b88b71f511dc6ba944350f"><code>604252e</code></a> [HfApi] Add visibility to create_bucket (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5053">#5053</a>)</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/4c88ea6e0f322bb866c6735abd350631bcc4e8cf"><code>4c88ea6</code></a> [Repos] Warn when duplicated repo files are still being copied (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5041">#5041</a>)</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/3bb08e20a3df06a9c3b2b93fe716c2f7dd8b8b2d"><code>3bb08e2</code></a> [Endpoints] Migrate catalog to the new /api/v1 API (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/4928">#4928</a>)</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/b5e3a129cea92b2d129c580f38526d95ec4e0d0b"><code>b5e3a12</code></a> [HfApi] Support resource_group_id in duplicate_repo (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5038">#5038</a>)</li> <li><a href="https://github.com/huggingface/huggingface_hub/commit/60fdb08c559dbda4a9087dfc56765f6ecd4895a1"><code>60fdb08</code></a> [Docs] Fix duplicated words in docstring and comments (<a href="https://redirect.github.com/huggingface/huggingface_hub/issues/5052">#5052</a>)</li> <li>Additional commits viewable in <a href="https://github.com/huggingface/huggingface_hub/compare/v1.5.0...v2.1.1">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/headroomlabs-ai/headroom/pull/4027" target="_blank"><picture><source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-devin-review-dark.svg?v=4"><img src="https://static.devin.ai/assets/gh-devin-review-light.svg?v=4" alt="Devin Review"></picture></a> <!-- devin-review-badge-end --> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JerrettDavis <mxjerrett@gmail.com>
This commit is contained in:
co-authored by
JerrettDavis
parent
de3f639803
commit
fcf3db8e70
+2
-2
@@ -136,11 +136,11 @@ ml = [
|
||||
# makes `headroom-ai[all]` unsatisfiable on Intel Macs (#1931).
|
||||
"torch>=2.12.1; sys_platform != 'darwin' or platform_machine != 'x86_64'",
|
||||
"transformers>=5.5.0,<6.0",
|
||||
# transformers >= 5.x requires huggingface-hub >= 1.5.0,<2.0; pinning
|
||||
# transformers >= 5.x requires huggingface-hub >= 1.5.0,< 3.0; pinning
|
||||
# the floor here prevents Kompress from silently falling back to
|
||||
# "unavailable" when a sibling install (e.g. `pip install
|
||||
# strands-agents`) drags huggingface-hub backwards.
|
||||
"huggingface-hub>=1.5.0,<2.0",
|
||||
"huggingface-hub>=1.5.0,<3.0",
|
||||
]
|
||||
# Memory system (hierarchical memory with vector search).
|
||||
# Uses the pure-Python sqlite-vec backend by default (VectorBackend.AUTO ->
|
||||
|
||||
@@ -1783,7 +1783,7 @@ requires-dist = [
|
||||
{ name = "httpx", marker = "extra == 'mcp'", specifier = ">=0.24.0" },
|
||||
{ name = "httpx", extras = ["http2"], marker = "extra == 'proxy'", specifier = ">=0.24.0" },
|
||||
{ name = "httpx", extras = ["http2", "socks"], marker = "extra == 'dev'", specifier = ">=0.24.0" },
|
||||
{ name = "huggingface-hub", marker = "extra == 'ml'", specifier = ">=1.5.0,<2.0" },
|
||||
{ name = "huggingface-hub", marker = "extra == 'ml'", specifier = ">=1.5.0,<3.0" },
|
||||
{ name = "jinja2", marker = "extra == 'reports'", specifier = ">=3.0.0" },
|
||||
{ name = "langchain-core", marker = "extra == 'langchain'", specifier = ">=1.3.3,<4.0" },
|
||||
{ name = "langchain-core", marker = "extra == 'langgraph'", specifier = ">=1.3.3,<4.0" },
|
||||
|
||||
Reference in New Issue
Block a user