mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-11-22 13:29:19 +08:00
fix(thinking): leave a thinking block with a null or non-string value unchanged (#4562)
## Description
`compact_thinking_to_text` says it never raises
(`headroom/transforms/thinking_compactor.py:115`), but a block with
`"thinking": null` reached `text.split()` and raised `AttributeError`. A
non-string `thinking` value now leaves the block as it is, like the
`isinstance` guard `compact_reasoning_openai_chat` already has. Item 1
of #4546.
Refs #4546
## Type of Change
- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [ ] Performance improvement
- [ ] Code refactoring (no functional changes)
## Changes Made
- `headroom/transforms/thinking_compactor.py`: `text =
block.get("thinking")`; if it is not a `str`, the block is appended
unchanged.
- `tests/test_thinking_compactor_version_gate.py`:
`test_compact_thinking_to_text_leaves_null_thinking_block_alone`.
## Testing
- [x] Unit tests pass (`pytest`)
- [x] Linting passes (`ruff check .`)
- [ ] Type checking passes (`mypy headroom`)
- [x] New tests added for new functionality
- [x] Manual testing performed
### Test Output
```text
# fail before (source at a2d4fe72, new test kept)
1 failed, 17 deselected
# pass after: tests/test_thinking_compactor_version_gate.py
18 passed
# ruff check / ruff format --check: All checks passed! / 2 files already formatted
```
## Real Behavior Proof
- Environment: Ubuntu (WSL2) on Windows 11, Python 3.12.15, `headroom`
Python source at `a2d4fe72` and at this branch, `_core` from the 0.42.0
wheel, offline.
- Exact command / steps: called `compact_thinking_to_text` on a
conversation whose older assistant turn has `{"type": "thinking",
"thinking": None}` (the snippet in #4546).
- Observed result: on `a2d4fe72`: `AttributeError: 'NoneType' object has
no attribute 'split'`. On this branch: the call returns, and the null
block is left in place unchanged.
- Not tested: the full suite and `mypy`. I found no production caller of
`compact_thinking_to_text` under `headroom/` (the proxy imports only
`compact_reasoning_openai_chat`), so this affects SDK callers.
## Runtime Rollout Safety
- Rollout-managed feature(s): None.
- Minimum rollout channel: N/A
- Stable/default behavior changed: Only for an input that previously
raised.
- Kill switch / disable path: None needed; revert.
- Unsafe override required: No
- Qualification impact: None expected
- Rollback path: revert this commit.
## Review Readiness
- [x] I have performed a self-review
- [x] This PR is ready for human review
## Checklist
- [x] My code follows the project's style guidelines
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] I did **not** edit `CHANGELOG.md` — it is generated by
release-please from my Conventional Commit PR title (a CI guard enforces
this)
## Screenshots (if applicable)
N/A
## Additional Notes
Split out of #4560 (one logical change per PR, as CONTRIBUTING asks).
The three items of #4546 are now #4560 (update check), #4562 (null
thinking block) and #4563 (interior blank CSV rows).
Produced with AI assistance (Claude Code) operated by me (HetCreep); the
reproduction was run on my machine against a clone of the repository.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: JD Davis <mxjerrett@gmail.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
JD Davis
parent
3d9a6f2cf7
commit
cc1eb5402a
@@ -162,7 +162,10 @@ def compact_thinking_to_text(
|
||||
if not (isinstance(block, dict) and block.get("type") == "thinking"):
|
||||
new_content.append(block)
|
||||
continue
|
||||
text = block.get("thinking", "")
|
||||
text = block.get("thinking")
|
||||
if not isinstance(text, str): # null/non-str: leave the block as it is
|
||||
new_content.append(block)
|
||||
continue
|
||||
words = len(text.split())
|
||||
if words < min_words:
|
||||
new_content.append(block)
|
||||
|
||||
@@ -51,3 +51,23 @@ def test_date_suffix_is_not_read_as_minor_version() -> None:
|
||||
assert bills_prior_thinking("claude-sonnet-4-20250514") is False
|
||||
# Sanity: the real 4.6 id still bills.
|
||||
assert bills_prior_thinking("claude-sonnet-4-6-20260101") is True
|
||||
|
||||
|
||||
def test_compact_thinking_to_text_leaves_null_thinking_block_alone() -> None:
|
||||
"""``"thinking": null`` must not raise (docstring: "Never raises")."""
|
||||
from headroom.transforms.thinking_compactor import compact_thinking_to_text
|
||||
|
||||
class _K:
|
||||
def compress(self, text, **kwargs):
|
||||
return type("R", (), {"compressed": text[:10]})()
|
||||
|
||||
null_block = {"type": "thinking", "thinking": None, "signature": "s"}
|
||||
msgs = [
|
||||
{"role": "user", "content": "q"},
|
||||
{"role": "assistant", "content": [null_block, {"type": "text", "text": "a"}]},
|
||||
{"role": "user", "content": "q2"},
|
||||
{"role": "assistant", "content": [{"type": "text", "text": "b"}]},
|
||||
]
|
||||
out, stats = compact_thinking_to_text(msgs, kompress=_K())
|
||||
assert out[1]["content"][0] == null_block
|
||||
assert stats["blocks"] == 0
|
||||
|
||||
Reference in New Issue
Block a user