mirror of
https://github.com/ever-co/ever-gauzy.git
synced 2026-10-20 06:09:29 +08:00
Ruslan KonviserandClaude Opus 5
54ed5ebdb3
Two correctness bugs from the AI review of #10010, both confirmed against the merged code on develop. 1. build.yml - every warm run would fail. `Restore node_modules archive` used `lookup-only: true`, so on a cache HIT the archive is never written to disk. `Install`, `Run postinstall`, `Archive` and `Save` are all gated on `cache-hit != 'true'` and correctly skip - but `Upload node_modules archive` carries NO `if:` guard and sets `if-no-files-found: error`. On a hit it therefore uploads nothing and fails the job, and because the other four jobs `needs:` this one, it takes the whole gate with it. The cold run that first writes the key passes, so this is invisible until the SECOND run - the one the cache exists for. Dropping `lookup-only` makes the producer always materialise the archive: a ~2.9 GB download costs a few minutes against the ~90-minute install it replaces, and it is what guarantees the run-scoped artifact handoff actually has a file to hand off. 2. archive-node-modules.sh - a failed tar could publish a corrupt archive. The script set only `-o pipefail`, never `-e`, and tolerated tar exit 1 with `|| [ $? -eq 1 ]`. A tar exit status of 2 - a real error - left the `||` compound false and execution simply continued to the size check. A ~2.9 GB tree truncated early still clears the 100 MB floor, so the partial archive would be published and unpacked by four consumer jobs. Now `set -e`, with the tar status captured explicitly so exit 1 stays tolerated and anything else aborts before the archive can be published. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
54 lines
2.2 KiB
Bash
Executable File
54 lines
2.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Packs the installed dependency tree into ONE compressed file for the other jobs to unpack.
|
|
#
|
|
# Paired with restore-node-modules.sh. A single ~2.9 GB file beats handing actions/cache ~900k loose
|
|
# files in both directions, and it is small enough to sit in the 10 GB per-repo cache budget — which
|
|
# the exploded ~9 GB tree never was.
|
|
# `set -e` matters here: without it a tar exit status of 2 (a REAL error, unlike the tolerated
|
|
# exit 1 below) falls straight through to the size check, and a ~2.9 GB tree truncated early still
|
|
# clears the 100 MB floor - so a corrupt archive gets published and four consumer jobs unpack it.
|
|
set -e
|
|
set -o pipefail
|
|
|
|
ARCHIVE="${NODE_MODULES_ARCHIVE:?NODE_MODULES_ARCHIVE must be set}"
|
|
|
|
PATHS=()
|
|
for p in node_modules apps/*/node_modules packages/*/node_modules \
|
|
packages/plugins/*/node_modules tools/node_modules; do
|
|
[ -d "$p" ] && PATHS+=("$p")
|
|
done
|
|
if [ ${#PATHS[@]} -eq 0 ]; then
|
|
echo "::error::install produced no node_modules directories"
|
|
exit 1
|
|
fi
|
|
echo "archiving ${#PATHS[@]} directories"
|
|
|
|
if command -v zstd >/dev/null 2>&1; then
|
|
COMPRESS="zstd -3 -T0"
|
|
else
|
|
echo "::warning::zstd unavailable — falling back to gzip (larger archive, slower)"
|
|
COMPRESS="gzip -3"
|
|
fi
|
|
|
|
# `--warning=no-file-changed` because yarn's daemon can touch files while we read them; `|| [ $? -eq 1 ]`
|
|
# accepts tar's "file changed as we read it" (exit 1) while still failing on a real error (exit 2).
|
|
# Capture the status explicitly. `|| [ $? -eq 1 ]` cannot express this: under `set -e` it still
|
|
# swallows every non-1 failure exactly as it did without it.
|
|
tar_status=0
|
|
tar --warning=no-file-changed --use-compress-program="$COMPRESS" \
|
|
-cf "$ARCHIVE" "${PATHS[@]}" || tar_status=$?
|
|
if [ "$tar_status" -ne 0 ] && [ "$tar_status" -ne 1 ]; then
|
|
echo "::error::tar failed with status $tar_status - refusing to publish a partial archive"
|
|
exit "$tar_status"
|
|
fi
|
|
|
|
# Tolerating exit 1 means a TRUNCATED archive could be published, and every consumer would then fall
|
|
# back to its own multi-hour install. A cheap size floor catches the gross case.
|
|
size=$(stat -c%s "$ARCHIVE")
|
|
ls -lh "$ARCHIVE"
|
|
if [ "$size" -lt 104857600 ]; then
|
|
echo "::error::archive is only $size bytes — the dependency tree cannot be that small"
|
|
exit 1
|
|
fi
|