Commit Graph
732 Commits
Author SHA1 Message Date
Michael D'AngeloandCodex 514de3d489 test(workbench): release the SQLite writer after lock acquisition (#2585)
Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-10 16:53:47 -08:00
ianw-oaiandmldangelo-oai e90a30ac25 fix(scan): reduce setup and tool output in Standard scans (#2046)
* fix(scan): reduce setup and tool output in Standard scans

* fix(workbench): keep policy paths optional for scan lookups

* fix(sdk): retain the preflight callback before scan dispatch

* fix(workbench): only advertise scoped inventory for Standard scans

* docs(workbench): explain optional scope report failures

* fix(workbench): preserve the Deep Scan registration response

* test(workbench): use the current scan context request in the Deep Scan fixture

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-10 15:26:19 -08:00
Michael D'AngeloandMichael D'Angelo 55261a78e6 docs: import hosted Semgrep findings locally or in Cloud (#2576)
* docs: add a local import guide for Semgrep hosted MCP findings

* docs: extend the hosted Semgrep import example through Cloud

* docs: clarify the Semgrep Cloud workspace prerequisite

---------

Co-authored-by: Michael D'Angelo <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-10 14:52:10 -08:00
ianw-oai aa57e09e3d fix: report exit status when the scan helper fails (#2406)
fix: report exit status when the scan helper fails silently
2026-11-10 14:08:54 -08:00
Michael D'Angelo fc51c1a42a fix(plugin): require thread attachment for legacy scan continuations (#2428)
* fix(plugin): scope legacy scan continuations to the attached scan

* fix(plugin): rejoin attached legacy deep scans by target

* fix(plugin): keep attached deep scan results with their conversation
2026-11-10 11:12:55 -08:00
Michael D'Angelo 4fac2dfdf3 fix(plugin): preserve native filename bytes in SQLite URIs (#2571)
* fix(plugin): preserve native filename bytes in SQLite URIs

* test(sdk): include SQLite URI support in the usage fixture
2026-11-10 08:12:09 -08:00
Michael D'Angelo ba6702440e fix(scan): isolate Git display settings in content snapshots (#2568)
* fix(scan): isolate Git display settings in content snapshots

* fix(scan): pin hunk, file order, and rename rendering in snapshots

* test(scan): write Git order fixtures with LF on every platform

* fix(scan): stabilize submodule, indentation, and rename presentation

* Capture the configured submodule diff before asserting

* Normalize Git driver annotations and binary patch rendering
2026-11-10 07:16:21 -08:00
Michael D'Angelo d4175bc3b5 fix(native): read deep sealed artifacts under Linux descriptor limits (#2570) 2026-11-10 06:45:57 -08:00
Michael D'Angelo bf98530200 fix(sdk): discover Python for targets when launched from filesystem root (#2569)
* fix(sdk): discover Python for targets when launched from filesystem root

* test(sdk): launch the Python discovery regression from root
2026-11-10 05:44:51 -08:00
Michael D'AngeloandCodex fce296540c fix(windows): tolerate executable metadata changes on first launch (#2555)
* fix(windows): preserve executable pins across first launch

* fix(windows): cancel executable pin verification

* fix: preserve active deep worker cancellation errors

* style: format deep worker cancellation catch

* test: make Windows pin metadata fixtures deterministic

---------

Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-10 03:58:12 -08:00
Michael D'Angelo 34d0e634ea fix(mcp): use UTF-8 for workbench responses and diagnostics (#2566) 2026-11-10 03:46:29 -08:00
Michael D'AngeloandCodex 943ea05777 fix(windows): preserve long Git metadata in reviewed patch replay (#2543)
* fix(windows): preserve long Git metadata in reviewed patch replay

* fix(windows): keep reviewed patch replay within source limits

* fix(windows): preserve metadata-free LF patch replay

* test(workbench): select short replay case only on Windows

---------

Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-10 02:28:58 -08:00
a353226b47 fix(workbench): pin Git metadata on another Windows fixed drive (#2539)
* fix(workbench): recover nested Windows inventories with a pinned Git marker

* fix(workbench): pin Git metadata on a separate Windows fixed drive

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-10 02:28:49 -08:00
Michael D'Angelo 6993830d5d fix(native): read sealed artifacts in searchable Linux directories (#2564)
* fix(native): read sealed artifacts in searchable Linux directories

* test(native): unlink the known directory symlink in the scan read proof
2026-11-10 02:18:52 -08:00
Michael D'Angelo a86445c841 fix(scan): isolate Git pathspec modes for file inventories (#2565) 2026-11-10 02:14:50 -08:00
Michael D'Angelo 4ede567343 fix(scan): verify assumed-unchanged files for committed diffs (#2554)
* fix(scan): verify assumed-unchanged files for committed diffs

* test(workbench): read the index flag before asserting

* fix(workbench): isolate Git settings during private index refresh
2026-11-10 01:33:18 -08:00
Michael D'AngeloandCodex 337dd60c96 fix(windows): grant scan workers explicit source read access (#2545)
* fix(windows): configure explicit read access to scan sources

* fix(windows): preserve source reads through MCP launch

* test(mcp): expect repository environment forwarding

---------

Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-10 01:19:23 -08:00
Michael D'Angelo 1c4431b36e fix(workbench): preserve explicit usage database paths (#2556)
* fix(workbench): preserve explicit usage database paths

* test(workbench): close usage fixtures before renaming them

* test(workbench): use supported database names on each host
2026-11-10 00:58:45 -08:00
Michael D'Angelo a0fedec4ca fix(runtime): honor literal POSIX executable override paths (#2551)
* fix(runtime): honor literal POSIX executable override paths

* fix(runtime): retain the lookup origin of padded executable paths

* fix(runtime): keep bare executable overrides on their original lookup path
2026-11-10 00:14:26 -08:00
Michael D'Angelo cd47bb2b98 fix(plugin): preserve trailing whitespace in POSIX scan roots (#2552) 2026-11-09 23:40:46 -08:00
f91c51e514 fix(workbench): preserve Windows checkout identity across Python versions (#2541)
* fix(windows): resume Deep Scans before the first checkpoint

* fix(windows): retain the resume directory handle through registration

* fix(windows): finish Deep output registration after cancellation

* fix(windows): retain registration control across plugin entrypoints

* fix(windows): read Deep resume identities from pinned handles

* fix(windows): preserve Deep Scan checkout identity across Python versions

* fix(windows): verify bound checkouts throughout Deep Scan recovery

* fix(workbench): keep scan history when a legacy checkout moves

* test: include checkout binding in migration expectations

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-09 21:50:14 -08:00
Michael D'Angeloandmldangelo-oai ff9f8dda4d fix(plugin): publish new patch files on musl without hard links (#2530)
* fix(plugin): publish new patch files on musl without hard links

* test(plugin): close the rename fixture directory explicitly

* test(plugin): select the raw rename syscall test only on Linux

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 21:50:08 -08:00
Michael D'Angeloandmldangelo-oai 5813bb1b66 fix(runtime): find system Python for Linux accounts without a home (#2509)
* fix(plugin): fall back to system Python when a Linux UID has no home

* fix(sdk): discover system Python when a Linux UID has no home

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 21:40:56 -08:00
Michael D'Angeloandmldangelo-oai 067bfcd616 fix(plugin): preserve closed helper stdin under BusyBox ash (#2540)
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 21:08:13 -08:00
Michael D'Angeloandmldangelo-oai 9ea8f5b56f fix(workbench): register nested Windows scans with long Git metadata paths (#2534)
fix(workbench): recover nested Windows inventories with a pinned Git marker

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 20:58:41 -08:00
Michael D'Angeloandmldangelo-oai d84df10c1a fix(workbench): identify replaced checkout parent directories (#2537)
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 20:34:52 -08:00
Michael D'Angeloandmldangelo-oai 3254a21592 fix(scans): archive long POSIX output directory names (#2529)
* fix(scans): archive long POSIX output directory names

* fix(logs): recover bound sessions from short scan archives

* fix(package): include the scan archive path helper in the release contract

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 20:21:32 -08:00
Michael D'Angeloandmldangelo-oai 5ee74aeedc fix(plugin): save artifacts with long POSIX filenames (#2533)
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 20:05:06 -08:00
Michael D'Angeloandmldangelo-oai 6df392cf02 test(workbench): make Git scope and sealed CSV fixtures portable (#2517)
* test(workbench): make Git scope and sealed CSV fixtures portable

* test(workbench): read Unicode CSV exports as UTF-8

* test(workbench): select representable Git names in native CI

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 18:27:53 -08:00
Michael D'Angeloandmldangelo-oai 91c01f08ab fix(windows): resume Deep Scans interrupted before their first artifact (#2515)
* fix(windows): resume Deep Scans before the first checkpoint

* fix(windows): retain the resume directory handle through registration

* fix(windows): finish Deep output registration after cancellation

* fix(windows): retain registration control across plugin entrypoints

* fix(windows): read Deep resume identities from pinned handles

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 18:27:47 -08:00
Michael D'Angeloandmldangelo-oai f3efffee06 fix(package): build the bundled plugin in long Windows checkouts (#2508)
* fix(sdk): build bundled plugins from long Windows paths

Use the extended Windows path only when creating the temporary build directory. Keep the selected parent spelling for the compiler, publication, and cleanup, and exercise the package build from a long source snapshot.

* fix(plugin): build the selected MCP app on long Windows paths

Run the declared app build with its local dependency binaries when the Windows Node task runner would skip a long package or tool path. Keep the native runner on shorter paths, other platforms, and Bun.

* fix(plugin): run the selected Bun build script in deep Windows checkouts

Use Bun run build for long Windows MCP app paths so the reserved bundler command cannot shadow the package script. Exercise the real Bun process and its selected package lifecycle in the long source-build regression.

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 18:07:06 -08:00
Michael D'Angeloandmldangelo-oai 64bb360706 fix(plugin): select a SQLite-capable Node runtime on Linux (#2499)
* fix(plugin): select a SQLite-capable Node runtime on Linux

* fix(plugin): limit Linux SQLite fallback to system installations

* fix(plugin): distinguish missing SQLite by probe exit status

* fix(plugin): follow fixed system Node installation symlinks

* test(plugin): pass the system Node fixture path as data

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 16:20:26 -08:00
Michael D'Angeloandmldangelo-oai e0de9ee323 fix(windows): preserve literal paths when loading scan policy (#2510)
* Invoke the selected Windows policy helper without re-expanding paths

* Keep the reviewed Windows policy workflow available to custom validation

* Keep PowerShell native preferences local to the policy command

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 16:00:27 -08:00
Michael D'Angeloandmldangelo-oai 4e51fb768b fix(deep-scan): resolve home-relative project config paths on POSIX (#2505)
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 14:33:53 -08:00
1deca2d70e fix(logs): persist terminal scan boundaries (#1527)
* fix(sdk): bound saved scan log events by scan completion

* fix(sdk): simplify saved log completion filtering

* fix(sdk): preserve finishing scan turns in saved logs

* fix(logs): persist terminal scan boundaries

* fix(sdk): preserve legacy scan worker attribution

* test(workbench): expect the log boundary migration

* test: reuse accepted source path coverage

* refactor(logs): share scan turn boundary detection

* test(workbench): restore the v53 schema before replaying migrations

* test(sdk): expect cancellation after an explicit component scan abort

* Repair schema history for published scan-log boundary previews

* Format scan log timestamp metadata

---------

Co-authored-by: Codex <codex@users.noreply.github.com>
Co-authored-by: Michael D'Angelo <mdangelo@openai.com>
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 13:44:52 -08:00
Michael D'Angeloandmldangelo-oai ea8c16644f fix(package): preserve LF in the POSIX MCP launcher on Windows (#2500)
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 13:25:52 -08:00
Michael D'Angeloandmldangelo-oai 7b6c058dc5 fix(windows): stage the bundled plugin for scan sandbox reads (#2494)
Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 11:34:49 -08:00
Michael D'Angelo 0a12733373 fix(windows): verify scan output directory ownership and ancestry (#2432)
* fix(windows): verify scan output directory ownership and ancestry

* fix(windows): read access entries within the ACL buffer

* test(windows): read the native rename access result

* fix(windows): check directory reparse access during output selection

* fix(windows): preserve output link diagnostics and verify native permissions

* test(windows): exercise empty directory removal and runtime admission

* fix(windows): keep known checkpoint reads scoped to selected files

* fix(windows): preserve selected output directories during preparation

* fix(runtime): verify selected POSIX output parents before resolving the leaf
2026-11-09 08:41:41 -08:00
Michael D'AngeloandCodex 1d586acc2b fix: keep workbench lifecycle results scoped to the selected scan (#2421)
* fix: keep workbench lifecycle results scoped to the selected scan

* test(plugin): bind lifecycle fixtures to their scan thread

* fix(plugin): bind rejoined scans and load assigned remediation context

---------

Co-authored-by: Codex <codex@users.noreply.github.com>
2026-11-09 08:41:33 -08:00
Michael D'Angelo 08a9a247d1 test(plugin): exercise macOS filesystem fixtures portably (#2487) 2026-11-09 08:04:52 -08:00
Michael D'Angeloandmldangelo-oai 884b7b657a refactor!: consolidate scan, workbench and release rules (#2452)
* refactor(workbench): share schema repair and saved finding projections

* refactor(cli): resolve the command route once

* refactor(settings): share Deep Scan configuration and restore saved inputs

* refactor(imports): reuse scanner projections at the file boundary

* refactor(publish): share pending request and receipt handling

* refactor(telemetry): classify publication failures in the recorder

* refactor(package): share plugin inventory and archive checks

* refactor(release): reuse verified provenance and release decisions

* fix(ci): reconcile release labels with an empty array on Bash 3.2

* ci: report failed source checks after cancelled PR edits

---------

Co-authored-by: mldangelo-oai <269034524+mldangelo-oai@users.noreply.github.com>
2026-11-09 05:02:21 -08:00
Michael D'Angelo b833a43423 fix(windows): pin directories during scan artifact operations (#2427) 2026-11-09 04:18:38 -08:00
Michael D'Angelo cc823c6472 fix: show deferred validation in cost-limited Deep Scan reports (#2436) 2026-11-09 04:18:11 -08:00
Michael D'Angelo 228003abbd refactor(deep-scan): stop passing host CPU counts to worker setup (#2482)
Deep Scan selects workers from per-run settings, legacy TOML, or the bundled default of four. The former automatic setting also resolves to four. Stop sampling host CPUs in the MCP client, setup inspection, and workbench launch. Preserve validation for callers that still send the legacy argument.

Verified workbench startup and the standalone helper with omitted, zero, one, and sixteen as the CPU count. Project setup, saved settings, coordinator resume, and the MCP store integration suite passed on both revisions. The SDK types and format checks and portable plugin checks also passed.
2026-11-09 04:08:25 -08:00
Michael D'Angelo a0d193e309 refactor(artifacts): share relative path validation for draft and sealed scans (#2478)
Use the sealed contract's path grammar to validate a draft's finding locations
and code evidence. The draft retains each original spelling and its existing
error type. The sealed reader still returns the normalized path and allows a
dot only in contexts that previously allowed it. CSV keeps its own rules,
including a different Windows check on drive-prefixed paths.

The two maintained plugin sources lose 19 lines. Regenerating the SDK mirror
adds five lines, for 14 deleted overall. Compared 1,242,746 inputs under each
of Node's POSIX and Windows path semantics, including the Unicode code-point
range. Windows behavior was modeled on Linux.

Replayed 99 cases on the standalone plugin under Node 22.13.0 using examples
from releases 0.1.0 and 0.8.3. Four exported CSVs and an actual sparse CSV
preserved their source locations through scan import. The 316 focused MCP
tests and 263 SDK tests passed, along with types and plugin source checks.
2026-11-09 04:07:55 -08:00
Michael D'Angelo f8edafd5dc refactor(plugin): store each MCP runtime in one Brotli file (#2469)
Keep one compressed payload per generated MCP launcher so bundle growth
no longer requires changing a numbered file list. The server and helper
entrypoints retain their paths, module identities and exports. Rebuilding
removes previous parts, and the package checker still reads split archives.

Both new payloads match the concatenated original parts byte for byte.
The packed npm archive grew by 4,377 bytes. All 81 focused tests passed
on each revision, with three platform skips. The installed npm smoke
passed, including MCP initialization, nested worker launch, retry and
detached plugin restart.
2026-11-09 04:06:49 -08:00
Michael D'Angelo 1c17ead213 refactor(scan): derive inline review fields once before sealing (#2466)
The change to inline scan reviews in #1762 taught both the schema preview
and the first-seal publisher to select a mode and construct the compact
review. Make that decision once and use the same fields for both. A sealed
rerun still leaves the stored review alone, and coverageRef bundles still
use their separate coverage document.

Keep the provisional and final manifest validations. The former catches a
malformed reviewState before the publisher drops it and checks report
inputs before optional writeup handling. The latter checks the real
artifact records. Custom schemas can distinguish the two.

Compared finalization against the published 0.1.0 completed scan and the
0.8.3 current and legacy examples. All 14 output files matched byte for
byte, including each original sealed JSON file. Both trees passed the
541 selected finalization and replay tests and 177 subtests (2 skips).
2026-11-09 04:06:24 -08:00
Michael D'Angelo ab7a9bb3fd refactor(mcp): validate delivered scan identity in one place (#2465)
* refactor(mcp): validate delivered scan identity in one place

Give headless Standard and prompt-only starts one definition of a delivered
scan. Its disposition, UUID, directory and workspace ID must agree. Keep
the additional Standard claim, thread, mode, progress and new-scan phase
checks at the Standard entry point. Prompt-only does not grant artifact
access. Both tools still return the original workbench response.

Compared 10,119 synthetic responses through the registered callbacks on
each of Node 22.13, 24.19 and 26. Independent checks observed actual claim
insertion and rejection. In 27 stdio workflows the released 0.8.3 plugin,
main and this change created and rejoined headless Standard, prompt-only
Standard and diff scans, retaining the expected identity and token
handling. Main and the candidate retained the same telemetry fields.

MCP types, formatting, the plugin build, Ruff and nine portable checks
passed. A broader four-file MCP run encountered host process and thread
creation failures. Native Windows and macOS were not part of this run.
No caller migration or generated-source changes are required.

* fix(mcp): drop the unused prompt-only scan directory binding

Keep scan directory validation and return the complete workbench response. The shorter binding reads only the scan identifier used by the prompt-only result.
2026-11-09 04:06:16 -08:00
Michael D'Angelo 297f168cb0 refactor(recovery): reuse accepted worker coverage sources (#2464)
Select each accepted worker result once for coverage lookup and review
emission. Keep source order when a recovered row has several matching
inputs, and preserve archived evidence when the registered result is
missing.

All 720 recovery and projection tests pass before and after the change,
including failed workers, missing current results, and frozen replay.
2026-11-09 04:06:06 -08:00
Michael D'Angelo db1c7fb746 refactor(artifacts): derive historical union types from their members (#2459)
Mark the canonical findings unions that expose the historical JSON Schema
type array and property layout. Derive their type names from Zod's resolved
branches during serialization. A member change now needs one edit instead
of a corresponding metadata array edit. Keep unmarked unions and authored
type restrictions untouched. Fail generation on a marked union with an
unresolved, untyped, or duplicate member rather than emitting a broader
contract.

All eleven generated JSON files are byte-identical. Dropping the layout
outright changes published property pointers and validation diagnostics.
A temporary numeric rootCause member verified the new generator accepts
that member while retaining the nested object restrictions. Independent
experiments covered unsupported branches and unmarked restrictions.

Checked generation on Node 22.13, 24.19, and 26.0, MCP typecheck, the three
MCP artifact contract test files, 15 Python schema/checkpoint tests, plugin
source compatibility and its nine tests, and formatting. The two generator
sources add 22 and remove 28 lines, with no generated or consumer changes.
2026-11-09 04:05:23 -08:00