mirror of
https://github.com/colbymchenry/codegraph.git
synced 2026-10-24 06:53:52 +08:00
Closes the visibility gap behind issues #138 (WASM-on-macOS) and #139 (MCP "database is locked"). `better-sqlite3` is in optionalDependencies, so when the native build fails npm install still succeeds and the runtime silently falls back to node-sqlite3-wasm — 5-10x slower and without WAL, so writers block readers (which is what makes the MCP server appear to "lock the DB" in #139). The only existing signal was a one-line `console.warn` to stderr that MCP transports typically swallow. This patch does NOT change install behavior — better-sqlite3 stays in optionalDependencies so cross-platform installs keep working. It just makes the substitution observable + recoverable. ## Visibility (4 surfaces) - CLI `codegraph status`: new `Backend:` line under Index Statistics. `native` rendered green; `wasm` rendered yellow with an inline `npm rebuild better-sqlite3` nudge. Also exposed in `--json` as `backend: 'native' | 'wasm'`. - MCP `codegraph_status`: new `**Backend:**` line. Native form reads `native (better-sqlite3)`; wasm form prepends a warning glyph and includes the full fix recipe. - Stderr banner on fallback (`buildWasmFallbackBanner`): replaces the bare one-line `console.warn` with a multi-line bordered banner covering macOS + Linux fix steps and optionally appending the native load error. - README troubleshooting: new "Indexing is slow / MCP database is locked / WASM fallback active" entry that walks users to the `Backend:` line and the fix. ## Per-instance backend tracking `createDatabase` previously set a module-level `activeBackend` global. MCP can open multiple project DBs in one process via the `getCodeGraph()` cache, so the global would race / overwrite. Refactor: `createDatabase` now returns `{db, backend}`, `DatabaseConnection` carries `private backend` and exposes `getBackend()`, and `CodeGraph.getBackend()` is the public surface. The CLI and MCP both call `cg.getBackend()`. ## What this does NOT fix The root cause of users landing on WASM is environment-specific (Mac without Xcode CLT, Node version mismatch, etc.) and not fixable in code without changing the optionalDependencies design. The README entry tells users what to run; `Backend: native` after rebuild is the confirmation signal. ## Tests New `__tests__/sqlite-backend.test.ts` (6 tests) pins the banner recipe content (so future edits can't strip the recovery commands), the `WASM_FALLBACK_FIX_RECIPE` constant, and per-instance `DatabaseConnection.getBackend()` / `CodeGraph.getBackend()` reporting. Suite: 503 → 509, all passing. Credit to @andreinknv whose analysis on #138 (and patches on his fork at 6d0e7a2 + 69f7001) framed the visibility approach. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
268 lines
8.9 KiB
TypeScript
268 lines
8.9 KiB
TypeScript
/**
|
|
* SQLite Adapter
|
|
*
|
|
* Provides a unified interface over better-sqlite3 (native) and
|
|
* node-sqlite3-wasm (WASM fallback) for universal cross-platform support.
|
|
*/
|
|
|
|
export interface SqliteStatement {
|
|
run(...params: any[]): { changes: number; lastInsertRowid: number | bigint };
|
|
get(...params: any[]): any;
|
|
all(...params: any[]): any[];
|
|
}
|
|
|
|
export interface SqliteDatabase {
|
|
prepare(sql: string): SqliteStatement;
|
|
exec(sql: string): void;
|
|
pragma(str: string): any;
|
|
transaction<T>(fn: (...args: any[]) => T): (...args: any[]) => T;
|
|
close(): void;
|
|
readonly open: boolean;
|
|
}
|
|
|
|
export type SqliteBackend = 'native' | 'wasm';
|
|
|
|
/**
|
|
* One-line summary of the recovery steps shown when WASM fallback is
|
|
* active. Single source of truth so the recipe can't drift between the
|
|
* stderr banner and the MCP status formatter.
|
|
*/
|
|
export const WASM_FALLBACK_FIX_RECIPE =
|
|
'`xcode-select --install` (macOS) or `apt install build-essential` (Debian/Ubuntu), ' +
|
|
'then `npm rebuild better-sqlite3`, or `npm install better-sqlite3 --save` to force-include it.';
|
|
|
|
/**
|
|
* Multi-line banner shown to stderr when `createDatabase` falls back to
|
|
* WASM. Replaces a one-line `console.warn` that MCP transports (which
|
|
* take stdout for the protocol) typically swallow, leaving users on a
|
|
* 5-10x slower backend with no signal.
|
|
*
|
|
* Exported for unit testing — pinning the recipe content prevents
|
|
* future edits from silently stripping the recovery commands.
|
|
*/
|
|
export function buildWasmFallbackBanner(nativeError?: string): string {
|
|
const sep = '─'.repeat(72);
|
|
const lines = [
|
|
sep,
|
|
'[CodeGraph] WASM SQLite fallback active (better-sqlite3 unavailable)',
|
|
sep,
|
|
'Indexing and sync will be 5-10x slower than the native backend.',
|
|
'',
|
|
'Fix on macOS:',
|
|
' xcode-select --install # install C build tools',
|
|
' npm rebuild better-sqlite3 # rebuild native binding for current Node',
|
|
'',
|
|
'Fix on Linux:',
|
|
' sudo apt install build-essential python3 make # Debian/Ubuntu',
|
|
' # or: sudo yum groupinstall "Development Tools" # RHEL/Fedora',
|
|
' npm rebuild better-sqlite3',
|
|
'',
|
|
'Or force-include as a hard dependency on any platform:',
|
|
' npm install better-sqlite3 --save',
|
|
'',
|
|
'Verify after fix: `codegraph status` should show `Backend: native`.',
|
|
];
|
|
if (nativeError) {
|
|
lines.push('', `Native load error: ${nativeError}`);
|
|
}
|
|
lines.push(sep);
|
|
return lines.join('\n');
|
|
}
|
|
|
|
/**
|
|
* Translate @named parameters (better-sqlite3 style) to positional ? params
|
|
* for node-sqlite3-wasm, which only supports positional binding.
|
|
*
|
|
* Returns the rewritten SQL and an ordered list of parameter names.
|
|
* If no named params are found, returns null for paramOrder (positional mode).
|
|
*/
|
|
function translateNamedParams(sql: string): { sql: string; paramOrder: string[] | null } {
|
|
const paramOrder: string[] = [];
|
|
const rewritten = sql.replace(/@(\w+)/g, (_match, name: string) => {
|
|
paramOrder.push(name);
|
|
return '?';
|
|
});
|
|
if (paramOrder.length === 0) {
|
|
return { sql, paramOrder: null };
|
|
}
|
|
return { sql: rewritten, paramOrder };
|
|
}
|
|
|
|
/**
|
|
* Convert better-sqlite3-style params to a positional array for node-sqlite3-wasm.
|
|
*
|
|
* Handles three calling conventions:
|
|
* - Named object: run({ id: '1', name: 'a' }) → positional array via paramOrder
|
|
* - Positional args: run('a', 'b') → ['a', 'b']
|
|
* - No args: run() → undefined
|
|
*/
|
|
function resolveParams(params: any[], paramOrder: string[] | null): any {
|
|
if (params.length === 0) return undefined;
|
|
|
|
// If paramOrder exists and first arg is a plain object, do named→positional translation
|
|
if (paramOrder && params.length === 1 && params[0] !== null && typeof params[0] === 'object' && !Array.isArray(params[0]) && !(params[0] instanceof Buffer) && !(params[0] instanceof Uint8Array)) {
|
|
const obj = params[0];
|
|
return paramOrder.map(name => obj[name]);
|
|
}
|
|
|
|
// Positional: single value or already an array
|
|
if (params.length === 1) return params[0];
|
|
return params;
|
|
}
|
|
|
|
/**
|
|
* Wraps node-sqlite3-wasm to match the better-sqlite3 interface.
|
|
*
|
|
* Key differences handled:
|
|
* - better-sqlite3 uses @named params; node-sqlite3-wasm uses positional ? only
|
|
* - better-sqlite3 uses variadic args: stmt.run(a, b, c)
|
|
* - node-sqlite3-wasm uses a single array/object: stmt.run([a, b, c])
|
|
* - node-sqlite3-wasm has `isOpen` instead of `open`
|
|
* - node-sqlite3-wasm doesn't have a `pragma()` method
|
|
* - node-sqlite3-wasm doesn't have a `transaction()` method
|
|
*/
|
|
class WasmDatabaseAdapter implements SqliteDatabase {
|
|
private _db: any;
|
|
// Track raw WASM statements so we can finalize them on close.
|
|
// node-sqlite3-wasm won't release its file lock if statements are left open.
|
|
private _openStmts = new Set<any>();
|
|
|
|
constructor(dbPath: string) {
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const { Database } = require('node-sqlite3-wasm');
|
|
this._db = new Database(dbPath);
|
|
}
|
|
|
|
get open(): boolean {
|
|
return this._db.isOpen;
|
|
}
|
|
|
|
prepare(sql: string): SqliteStatement {
|
|
const { sql: rewrittenSql, paramOrder } = translateNamedParams(sql);
|
|
const stmt = this._db.prepare(rewrittenSql);
|
|
this._openStmts.add(stmt);
|
|
return {
|
|
run(...params: any[]) {
|
|
const resolved = resolveParams(params, paramOrder);
|
|
const result = resolved !== undefined ? stmt.run(resolved) : stmt.run();
|
|
return {
|
|
changes: result?.changes ?? 0,
|
|
lastInsertRowid: result?.lastInsertRowid ?? 0,
|
|
};
|
|
},
|
|
get(...params: any[]) {
|
|
const resolved = resolveParams(params, paramOrder);
|
|
return resolved !== undefined ? stmt.get(resolved) : stmt.get();
|
|
},
|
|
all(...params: any[]) {
|
|
const resolved = resolveParams(params, paramOrder);
|
|
return resolved !== undefined ? stmt.all(resolved) : stmt.all();
|
|
},
|
|
};
|
|
}
|
|
|
|
exec(sql: string): void {
|
|
this._db.exec(sql);
|
|
}
|
|
|
|
pragma(str: string): any {
|
|
const trimmed = str.trim();
|
|
|
|
// Write pragma: "key = value"
|
|
if (trimmed.includes('=')) {
|
|
const eqIdx = trimmed.indexOf('=');
|
|
const key = trimmed.substring(0, eqIdx).trim();
|
|
const value = trimmed.substring(eqIdx + 1).trim();
|
|
|
|
// WAL is not supported in WASM SQLite — use DELETE journal mode
|
|
if (key === 'journal_mode' && value.toUpperCase() === 'WAL') {
|
|
this._db.exec('PRAGMA journal_mode = DELETE');
|
|
return;
|
|
}
|
|
|
|
// mmap is not available in WASM — silently skip
|
|
if (key === 'mmap_size') {
|
|
return;
|
|
}
|
|
|
|
// synchronous = NORMAL is unsafe without WAL — use FULL
|
|
if (key === 'synchronous' && value.toUpperCase() === 'NORMAL') {
|
|
this._db.exec('PRAGMA synchronous = FULL');
|
|
return;
|
|
}
|
|
|
|
this._db.exec(`PRAGMA ${key} = ${value}`);
|
|
return;
|
|
}
|
|
|
|
// Read pragma: "key" — return the value
|
|
const stmt = this._db.prepare(`PRAGMA ${trimmed}`);
|
|
const result = stmt.get();
|
|
stmt.finalize();
|
|
return result;
|
|
}
|
|
|
|
transaction<T>(fn: (...args: any[]) => T): (...args: any[]) => T {
|
|
return (...args: any[]) => {
|
|
this._db.exec('BEGIN');
|
|
try {
|
|
const result = fn(...args);
|
|
this._db.exec('COMMIT');
|
|
return result;
|
|
} catch (error) {
|
|
this._db.exec('ROLLBACK');
|
|
throw error;
|
|
}
|
|
};
|
|
}
|
|
|
|
close(): void {
|
|
// Finalize all tracked statements before closing.
|
|
// node-sqlite3-wasm won't release its directory-based file lock
|
|
// if any prepared statements remain open.
|
|
for (const stmt of this._openStmts) {
|
|
try { stmt.finalize(); } catch { /* already finalized */ }
|
|
}
|
|
this._openStmts.clear();
|
|
this._db.close();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Create a database connection. Tries native better-sqlite3 first,
|
|
* falls back to node-sqlite3-wasm. Returns the active backend
|
|
* alongside the db so each `DatabaseConnection` can report its own
|
|
* backend per-instance — MCP can open multiple project DBs in one
|
|
* process (`tools.ts` getCodeGraph cache), so a process-global would
|
|
* race / overwrite.
|
|
*/
|
|
export function createDatabase(dbPath: string): { db: SqliteDatabase; backend: SqliteBackend } {
|
|
let nativeError: string | undefined;
|
|
let wasmError: string | undefined;
|
|
|
|
// Try native better-sqlite3 first
|
|
try {
|
|
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
|
const Database = require('better-sqlite3');
|
|
const db = new Database(dbPath);
|
|
return { db: db as SqliteDatabase, backend: 'native' };
|
|
} catch (error) {
|
|
nativeError = error instanceof Error ? error.message : String(error);
|
|
}
|
|
|
|
// Fall back to WASM
|
|
try {
|
|
const db = new WasmDatabaseAdapter(dbPath);
|
|
console.warn(buildWasmFallbackBanner(nativeError));
|
|
return { db, backend: 'wasm' };
|
|
} catch (error) {
|
|
wasmError = error instanceof Error ? error.message : String(error);
|
|
}
|
|
|
|
throw new Error(
|
|
`Failed to load any SQLite backend.\n` +
|
|
` Native (better-sqlite3): ${nativeError}\n` +
|
|
` WASM (node-sqlite3-wasm): ${wasmError}`
|
|
);
|
|
}
|