mirror of
https://github.com/DeusData/codebase-memory-mcp.git
synced 2026-11-15 13:56:34 +08:00
Martin Vogel
f9dc6503ae
Three changes to how PR CI consumes the test-impact selection (user decisions R150 and R151, 2026-11-11). Fork PRs. select-tests ran only when vars.TEST_IMPACT_MODE was `gate`, and GitHub passes no repository variables to a pull_request run from a fork: all 24 fork runs in the last 40 PR runs skipped the job, maintainer-started ones included. The condition is now (vars.TEST_IMPACT_MODE || 'gate') == 'gate'. Setting the variable to anything else (e.g. `shadow`) still turns the gate off for same-repository and Dependabot PRs; for fork PRs the off switch is the default in the expression on main. No pull_request_target, no new permissions, no secrets. Base tooling. select-tests built and ran the PR checkout's own engine, test-impact-select.sh and selection.py, so a change to them could narrow its own tests. The job now checks out the merge base (HEAD^1 of the merge ref) into a worktree, builds that engine and runs that copy of the script with --repo pointing at the PR checkout. test-impact-select.sh separates the tooling (its own checkout) from the repository under test (--repo). Until this lands, a PR's merge base has no --repo: the job then fails and, as before, every test runs. All legs. Only the Linux x86_64 test leg consumed a selection. A narrowed answer now also produces portable/ (selection.py --whole-suites with the platform-specific suites of the base and HEAD), and the arm64 and macOS test-unix legs and the Windows leg run that view: platform-neutral suites as selected, every platform-specific suite whole. No portable view, no narrowing there. Sanitizer, TSan, MSan, diag and LSan lanes still run every test. The shard harness already slices the selected list, so the sharded arm64 leg and the shard-completeness proof need no change. docs/SMART_CI.md and README.md follow; tests/test_lane_wiring_contract.sh pins the new wiring. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
