mirror of
https://github.com/DeusData/codebase-memory-mcp.git
synced 2026-10-02 04:54:47 +08:00
Every item here was measured on a real corpus before and after, not
reasoned about. Go corpus, event lane, first run -> now: 245.5 M
allocations -> 134.8 M, 190 GB cumulative -> 29.3 GB, 158 GB never
written -> 9.2 GB, 132 M churn pairs -> 35.7 M, 93 GB of allocator byte
work -> 0.84 GB. Wall clock: Go 40.7 s -> 19.3 s, linux kernel 239.6 s ->
194.6 s, and all ten LSP languages faster with none slower.
Graph output is unchanged, proven rather than assumed: per-class multiset
digests over the full kernel index (8,563,471 nodes identical, 18/20 node
classes and 18/24 edge classes byte-identical, the rest differing only in
the classes a same-binary re-run also perturbs through worker merge order).
The changes, each with its own reason:
arena an exact arena that is appended to later restarts growth at
8 KB instead of the 64 KB default — the cross-file pass adds a
few resolved calls to a compacted result, so the default block
was ~60 KB untouched per result, 0.5 GB of the Go worker peak.
cbm_arena_init_lazy defers the first block for arenas that are
usually never used at all.
scratch per-thread reuse instead of allocate-and-free per unit of
work: result_compact (8 MB kept), the cross-file pass (4 MB),
extract_defs' walk stack, and the sqlite index cells (a 1 MB
arena replacing 12.1 M malloc/free pairs on Go). Walk frames
moving into scratch is why pass_k8s now opens the keep window
explicitly: without it every YAML file opened a 512 KB scratch
on the main thread, +3 GB.
sqlite index cells are written in place — building the record and
copying it into the cell was a second allocation per entry,
16 M record buffers of pure churn on Go.
registry is_test_qn and common_prefix_len in one pass, per-bucket test
flags computed once instead of per candidate comparison, and
the reachability keys arena allocated lazily.
minhash the unique-trigram set is sized from the trigram count and
skips repeats, and LSH queries reuse one seen-set per worker
instead of allocating per query.
parallel lsp_surface rows and the k8s manifest prep now run across
workers (graph writes stay sequential and ordered), the file
node is hoisted out of register_and_link_def, and configlink
prepares dependency imports once with a length prefilter.
go_lsp one sealed stdlib registry shared by all workers, published
by CAS, instead of one per worker.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
107 lines
4.5 KiB
C
107 lines
4.5 KiB
C
/*
|
|
* extract_node_stack.h — Growable TSNode stack for AST traversal.
|
|
*
|
|
* Replaces fixed-size TSNode stack[] arrays that silently drop AST subtrees
|
|
* when the stack overflows (GitHub issue #199).
|
|
*
|
|
* Traversal stacks are scratch: nothing in a CBMFileResult ever points into
|
|
* one. They are therefore cut from ctx->scratch, which the enclosing
|
|
* cbm_extract_file_ex call owns and destroys on the way out, and never from
|
|
* ctx->arena, which the pipeline holds for every file until the whole result
|
|
* cache is freed (#1997).
|
|
*
|
|
* Growth abandons the old buffer in that scratch arena, which is free because
|
|
* the arena dies with the file. The initial capacities below are unchanged, but
|
|
* they are no longer what a small file costs: cbm_extract_file_ex hands every
|
|
* call a lazy scratch arena, whose first block is taken by the first stack
|
|
* built, so a call that builds no stack allocates nothing.
|
|
*/
|
|
#ifndef CBM_EXTRACT_NODE_STACK_H
|
|
#define CBM_EXTRACT_NODE_STACK_H
|
|
|
|
#include "cbm.h" /* CBMExtractCtx: a stack draws from ctx->scratch */
|
|
#include "arena.h"
|
|
#include "tree_sitter/api.h"
|
|
#include <string.h> /* memcpy */
|
|
|
|
typedef struct {
|
|
TSNode *items;
|
|
int count;
|
|
int cap;
|
|
/* The arena every allocation for this stack comes from, recorded once by
|
|
* ts_nstack_init so push() cannot be handed a different one. It is
|
|
* ctx->scratch, or ctx->arena as the fallback when the context has none. */
|
|
CBMArena *scratch;
|
|
} TSNodeStack;
|
|
|
|
/* Initialize a stack with the given initial capacity, allocated from the
|
|
* context's traversal scratch. Taking the context rather than an arena is
|
|
* deliberate: it makes handing over ctx->arena, or a local alias of it, a type
|
|
* error rather than a retention bug nobody notices. A context built without a
|
|
* scratch falls back to ctx->arena, which is the behaviour that shipped before
|
|
* #1997, so no caller ever gets a NULL arena and silently loses nodes. */
|
|
static inline void ts_nstack_init(TSNodeStack *s, const CBMExtractCtx *ctx, int initial_cap) {
|
|
CBMArena *arena = ctx->scratch ? ctx->scratch : ctx->arena;
|
|
s->scratch = arena;
|
|
s->items = (TSNode *)cbm_arena_alloc(arena, (size_t)initial_cap * sizeof(TSNode));
|
|
s->count = 0;
|
|
s->cap = s->items ? initial_cap : 0;
|
|
}
|
|
|
|
/* Push a node onto the stack, growing 2x if needed. */
|
|
static inline void ts_nstack_push(TSNodeStack *s, TSNode node) {
|
|
if (s->count >= s->cap) {
|
|
int new_cap = s->cap ? s->cap * 2 : 512;
|
|
TSNode *new_items = (TSNode *)cbm_arena_alloc(s->scratch, (size_t)new_cap * sizeof(TSNode));
|
|
if (!new_items)
|
|
return; /* OOM: best-effort, stop growing */
|
|
if (s->items && s->count > 0) {
|
|
memcpy(new_items, s->items, (size_t)s->count * sizeof(TSNode));
|
|
}
|
|
/* Old s->items is abandoned in the arena — freed on arena_destroy. */
|
|
s->items = new_items;
|
|
s->cap = new_cap;
|
|
}
|
|
s->items[s->count++] = node;
|
|
}
|
|
|
|
/* Pop a node from the stack. Caller must check s->count > 0. */
|
|
static inline TSNode ts_nstack_pop(TSNodeStack *s) {
|
|
return s->items[--s->count];
|
|
}
|
|
|
|
/*
|
|
* Push all children of `node` so they POP in forward (source) order — a drop-in
|
|
* replacement for the common idiom:
|
|
* for (int i = (int)count - 1; i >= 0; i--) ts_nstack_push(s, ts_node_child(node, i));
|
|
*
|
|
* That idiom calls ts_node_child(node, i) once per index, and ts_node_child is
|
|
* O(i) in tree-sitter (it walks the child iterator from the first child each
|
|
* time). Over a node with N children that is O(N^2) — catastrophic on a program
|
|
* root holding hundreds of thousands of top-level nodes (e.g. fixture/generated
|
|
* files). This helper enumerates children in a single O(N) cursor pass, then
|
|
* reverses the just-pushed segment so pop order is identical to the old idiom.
|
|
*/
|
|
static inline void ts_nstack_push_children(TSNodeStack *s, TSNode node) {
|
|
int base = s->count;
|
|
/* The thread's reusable cursor (cbm_thread_cursor): the walk completes
|
|
* before anything else on this thread can ask for it. */
|
|
TSTreeCursor *cursor = cbm_thread_cursor(node);
|
|
if (ts_tree_cursor_goto_first_child(cursor)) {
|
|
do {
|
|
ts_nstack_push(s, ts_tree_cursor_current_node(cursor));
|
|
} while (ts_tree_cursor_goto_next_sibling(cursor));
|
|
}
|
|
/* Reverse [base, count) so the first child pops first (forward order). */
|
|
int lo = base, hi = s->count - 1;
|
|
while (lo < hi) {
|
|
TSNode tmp = s->items[lo];
|
|
s->items[lo] = s->items[hi];
|
|
s->items[hi] = tmp;
|
|
lo++;
|
|
hi--;
|
|
}
|
|
}
|
|
|
|
#endif /* CBM_EXTRACT_NODE_STACK_H */
|