Files
Martin Vogel f9158d9e6a fix(discover): index deploy config files, skip env only as a virtualenv
Discovery skipped every directory named deploy, deployed or env, at any
depth. The deploy rule came in because build output copied into deploy/
produced duplicate Class and Method nodes (discover_deploy_excluded_full_mode),
but it also dropped what deploy/ usually holds: Kubernetes manifests, Helm
charts, Kustomize overlays, Terraform, Dockerfiles, Compose files and
scripts. The env rule was meant for Python virtual environments and dropped
ordinary packages and settings folders of that name (a Go package env, a
Python env module).

deploy/ and deployed/ are now walked for their deployment and configuration
files only. A file there, at any depth, is kept when its language (the
registry's own classification, by name and shebang) is deployment
configuration in the language registry (cbm_language_is_deployment_config):
the build-configuration languages the registry's build_config_language
already names (Makefile, CMake, YAML, TOML, JSON, INI, Dockerfile; now one
list, cbm_language_is_build_config, which build_config_language delegates
to), Properties, XML, JSON5, Jsonnet, Jinja2, Kustomize, Go Template, HCL,
Bicep, Nix, Puppet, Pkl, DotEnv, and the shells Bash, Zsh, Fish and
PowerShell. Program source, SQL and Groovy stay out, and so do the
dependency manifests the package-map walk skips there (package.json,
go.mod, Cargo.toml, pyproject.toml, pom.xml, *.gemspec, ...: one list,
cbm_discover_is_package_manifest, now shared with that walk). Each is
recorded as a skip-list drop. A .cbmignore negation of the directory lifts
the rule, and below a JVM source root it does not apply, as for every
built-in skip.

A directory named env is skipped only when it holds pyvenv.cfg,
bin/activate, Scripts/activate or conda-meta/history as a regular file.
Each marker is decided from the directory listings by its exact stored
name, one component at a time and without following links, so a
case-insensitive disk answers as a case-sensitive one does.

The pinned test-impact inventory makes the same decision: the directory
rule in cif_directory_reason, the virtual-environment test against its own
file list by exact name, and a config-only flag on each row that the
language step honours, so its file list stays equal to discovery's. The
package-manifest walk keeps skipping deploy/ and deployed/, and the JVM
doc-link classifier keeps calling a deploy package not indexed.

Pinned by
- discover_deploy_indexes_config_files_only: one file per kept language
  indexed under deploy/, each dropped kind beside it not, and the same
  files under ops/ all indexed;
- discover_env_skipped_only_as_virtualenv: every marker, conda included,
  skips its env; a Go package and a settings folder named env are indexed;
  markers that differ only in letter case do not count;
- discover_env_venv_marker_through_symlink_not_followed;
- test_impact_classify_matches_discovery_in_deploy_and_env and
  test_impact_classify_matches_discovery_on_env_layouts: one table each,
  both code paths;
- doc_mentions_jvm_deploy_package_not_indexed: the guard first, then a
  deploy package reads not_indexed and an env package binds.
discover_deploy_excluded_full_mode passes unchanged. Two JVM doc-mention
fixtures used a plain src/a/env/ package as their example of a directory
discovery skips by name; that package is indexed now, so they use tmp/.
The repro board's always-skip table no longer lists env.

A large generated tree under deploy/ now costs what the same tree costs
under any other name; a .cbmignore line such as deploy/generated/
excludes it (docs/cbmignore.md).

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
2026-11-18 21:21:38 +01:00
..