From babc3d837cb3317daf46b0aea945e0503f0b7bc5 Mon Sep 17 00:00:00 2001 From: Martin Vogel Date: Sun, 26 Jul 2026 07:24:40 +0200 Subject: [PATCH] revert(guards): drop the unverified launcher-guard edits Neither the fresh portable pair nor the ownership stamp fixed the immediate managed reinstall, so both were guesses and do not belong on a release-blocking PR. The guard's failure is pre-existing on main -- byte-identical output there, and unchanged with the #581 fix disabled -- so this branch carries no regression and no speculative test edits either. What the investigation did establish: the reinstall's install command fails with 'managed install requires a verified adjacent codebase-memory-mcp.exe launcher' when run directly, and emits no diagnostic on the stream the guard captures, which is why the guard reports only a version banner. Signed-off-by: Martin Vogel --- tests/windows/test_windows_launcher.py | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/tests/windows/test_windows_launcher.py b/tests/windows/test_windows_launcher.py index 4c499bd64..9183f5afb 100644 --- a/tests/windows/test_windows_launcher.py +++ b/tests/windows/test_windows_launcher.py @@ -1566,24 +1566,8 @@ def main(): source_launcher, source_payload, launcher, env, cache, work ) assert_failed_uninstall_restores_state(launcher, managed_dir, env) - # Stage a FRESH portable pair: the earlier managed installs consume the - # launcher sitting beside work/portable-install's payload, and a managed - # install legitimately refuses a payload with no verified adjacent - # launcher ("managed install requires a verified adjacent - # codebase-memory-mcp.exe launcher"). Reusing the consumed pair made this - # guard fail on the product's correct behaviour rather than on the - # immediate-reinstall contract it exists to protect. - reinstall_dir = work / "portable-reinstall" - _, reinstall_payload = copy_portable_pair( - source_launcher, source_payload, reinstall_dir - ) - # Copied files inherit Administrators ownership on runner images, and the - # launcher's exact-owner validators (correctly) require the current user - # -- so an unstamped pair is refused as unverified, which is the same - # error as having no adjacent launcher at all. - stamp_fixture_owner_current(reinstall_dir, env) assert_uninstall_immediate_reinstall_safe( - launcher, managed_dir, reinstall_payload, env + launcher, managed_dir, portable_payload, env ) print("\nGREEN: permanent Windows launcher contract honored.") return 0