OpenShell

mirror of https://github.com/NVIDIA/OpenShell.git synced 2026-10-16 05:20:22 +08:00

Files

T

mjamiv 1a57519f2d fix(sandbox): escape control characters in format_sse_error (#842 )

format_sse_error only escaped `\` and `"`, leaving two problems:

1. Control characters (`\n`, `\r`, `\t`, and all `\u0000-\u001F`) in
   `reason` produce output that fails `serde_json::from_str` — defeating
   #834's goal of giving clients a parseable SSE truncation signal.

2. An unescaped `\n\n` inside `reason` splits the single error event
   into two SSE frames, letting a misbehaving upstream inject a forged
   frame (e.g. a fake tool_calls delta) into the client's stream. Latent
   today since all in-tree callers pass static strings, but a footgun
   for any future caller passing upstream error text, and the function's
   docstring already invites dynamic reasons.

Replace the manual escape with `serde_json::to_writer` (already a
workspace dep of `openshell-sandbox`). Add unit tests for control
character escaping and SSE event-boundary injection.

Closes #840

Signed-off-by: mjamiv <michael.commack@gmail.com>

2026-04-15 07:28:08 -07:00

openshell-bootstrap

fix(cli): support plaintext gateway registration (#824 )

2026-04-13 17:08:08 -07:00

openshell-cli

fix(cli): support plaintext gateway registration (#824 )

2026-04-13 17:08:08 -07:00

openshell-core

refactor(server): extract kubernetes compute driver (#817 )

2026-04-14 13:32:05 -07:00

openshell-driver-kubernetes

refactor(server): use ComputeDriver RPC surface in-process (#839 )