mirror of
https://github.com/NVIDIA/OpenShell.git
synced 2026-10-26 06:52:57 +08:00
Drew Newberry
0b6aa0f742
## Summary - Add a "push" path for local development that exports Docker images from the host daemon and imports them directly into the k3s containerd runtime, eliminating the need for a local registry or remote image pulls during `mise run cluster` - Add `mise run cluster:deploy` task for fast iterative rebuilds (~25s) against a running cluster without recreating it - Update `cluster-entrypoint.sh` to patch HelmChart manifest with local image tags and `IfNotPresent` pull policy when push mode is active ## Details Previously, after the local registry (k3d + skaffold) was removed, `mise run cluster` only pulled component images from the remote CloudFront registry. This meant local code changes required a remote publish cycle to test in-cluster. This MR adds a push path that sits alongside the existing pull path: - **`push.rs`** — Uses bollard to `export_images()` all 3 component images into a single tar (with shared layer dedup), uploads via Docker `put_archive` API into the cluster container, then runs `ctr images import` to load them into containerd - **`docker.rs`** — Passes `IMAGE_TAG` and `IMAGE_PULL_POLICY` env vars into the cluster container when `NAVIGATOR_PUSH_IMAGES` is set - **`lib.rs`** — Wires push into the deploy flow between `clean_stale_nodes()` and `wait_for_cluster_ready()`, guarded by `remote_opts.is_none() && NAVIGATOR_PUSH_IMAGES` - **`cluster-entrypoint.sh`** — Patches the baked-in HelmChart manifest with sed to use the local image tag and pull policy before k3s starts - **`cluster.toml`** — Updated `[cluster]` task to tag and push images; new `[cluster:deploy]` task for iterative deploys via `docker save | ctr import` + `helm upgrade` The remote deploy path (`nav cluster admin deploy --remote`) is completely unaffected — the push logic only activates for local deploys with the env var set. ## Test Plan - `mise run cluster` — end-to-end success, cluster healthy with local images (~168s) - `mise run cluster:deploy` — iterative deploy success, helm upgrade + rollout (~43s) - `mise run pre-commit` — all checks pass (fmt, clippy, 82 tests, python lint) - Verified images present in containerd: `ctr -a /run/k3s/containerd/containerd.sock images ls | grep navigator/` - Remote path verified safe via code analysis (guards prevent push logic from running)