mirror of
https://github.com/NVIDIA/OpenShell.git
synced 2026-10-03 07:58:25 +08:00
John T. MyersandJohn Myers
66df9f7614
* feat(tui): add port forwarding support to Gator (#80) Extract forward PID management, resolve_ssh_gateway, and shell_escape from navigator-cli into navigator-core::forward as a shared module. Add a Ports field to the TUI create sandbox modal, a NOTES column to the sandbox table, and a Forwards row to the sandbox detail view. On creation with ports, Gator polls for Ready state then spawns background SSH tunnels. Forward cleanup runs automatically on sandbox delete. Closes #80 * fix(tui): fix Ports field invisible due to modal height overflow The modal height calculation used content_height + 3 but block chrome (borders + padding) is 4 rows, not 3. Combined with the 3-row Ports field layout, the input line was clipped to zero height on standard 24-row terminals. Switch Ports to a compact single-line inline layout and fix the chrome arithmetic. * wip: BYOC example with port forwarding and TUI command field fix - Move examples/bring-your-own-container.md into its own directory - Add example Dockerfile and app.py (Python REST API with /hello endpoint) - Rewrite README with full CLI and TUI port-forward workflows - Change TUI Command field default from /bin/bash to empty so custom image entrypoints run without manual clearing * feat(tui): wire up Command field to SSH exec after sandbox creation When a command is specified in the create sandbox modal, the TUI now waits for the sandbox to reach Ready (with the pacman animation), starts any port forwards, then suspends the TUI and executes the command via SSH — matching the CLI's post-creation flow. - Refactor spawn_create_sandbox to poll for Ready inline when ports or command are set, keeping the animation visible throughout - Add start_port_forwards() helper called within the create task - Add handle_exec_command() to suspend TUI and run SSH exec - Remove unused ForwardResult event variant (forwards are now started within the create task, not as a separate event) * fix(tui): fix command exec, forward timeouts, and create modal UX - Fix handle_exec_command to suspend TUI and run SSH attached (matching CLI behavior) so the process stays alive for the session duration - Fix shell_escape double-quoting: escape each word individually - Add ConnectTimeout and 20s spawn timeout to forward SSH so a stalled auth doesn't freeze the create flow forever - Remove dead ForwardResult event variant - Add cluster_name to start_port_forwards for ProxyCommand - Add spacer between Providers and Ports in create modal - Fix Command placeholder: 'runs /bin/bash if empty' (not image entrypoint) - Update BYOC README: document that CMD is replaced by supervisor, command must be passed explicitly, remove TUI-specific sections * fix(sandbox): demote Landlock fallback log from warn to debug The Landlock filesystem sandbox emits a noisy warning when a policy path does not exist (e.g. /app in custom images). Since BestEffort mode intentionally continues without Landlock, demote to debug. * docs: fix BYOC Dockerfile comments for supervisor CMD override --------- Co-authored-by: John Myers <johntmyers@users.noreply.github.com>