mirror of
https://github.com/NVIDIA/OpenShell.git
synced 2026-10-21 06:11:31 +08:00
Mrunal Patel
c502be9fd7
* feat(api): return typed deletion outcomes with explicit missing-target semantics Implement phase 2 of #3051 across the public gateway API and first-party SDKs. Preserve asynchronous sandbox deletion and observed resource identities, reserve legacy wire fields, and document the coordinated migration. Signed-off-by: Mrunal Patel <mrunalp@gmail.com> * fix(sdk): bind deletion waits to sandbox identity Track accepted deletions by original sandbox identity in Rust and TypeScript. Preserve name-only waits and cover replacement races and lookup failures. Merge the phase-one cleanup fix and adapt its interceptor regressions to typed deletion outcomes. Refs #3051. Signed-off-by: Mrunal Patel <mrunalp@gmail.com> * test(e2e): accept asynchronous stopped sandbox deletion Allow either completed or accepted deletion output, then continue polling for actual sandbox absence. This preserves the lifecycle assertion under the phase-two deletion contract. Refs #3051. Signed-off-by: Mrunal Patel <mrunalp@gmail.com> --------- Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
38 lines
1.2 KiB
Go
38 lines
1.2 KiB
Go
// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package v1
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
|
|
"github.com/NVIDIA/OpenShell/sdk/go/openshell/v1/types"
|
|
)
|
|
|
|
// SSHSession represents an SSH session created for a sandbox.
|
|
type SSHSession = types.SSHSession
|
|
|
|
// tunnelConfig accumulates options for the Tunnel method.
|
|
type tunnelConfig struct {
|
|
serviceID string
|
|
}
|
|
|
|
// TunnelOption configures an SSH tunnel opened via [SSHInterface.Tunnel].
|
|
type TunnelOption func(*tunnelConfig)
|
|
|
|
// WithTunnelServiceID sets an optional service identifier on the tunnel's
|
|
// init frame for audit and correlation purposes.
|
|
func WithTunnelServiceID(id string) TunnelOption {
|
|
return func(c *tunnelConfig) {
|
|
c.serviceID = id
|
|
}
|
|
}
|
|
|
|
// SSHInterface defines operations for managing SSH sessions.
|
|
type SSHInterface interface {
|
|
CreateSession(ctx context.Context, workspace, sandboxID string) (*SSHSession, error)
|
|
RevokeSession(ctx context.Context, workspace, token string, opts ...DeleteOptions) (*DeletionResult, error)
|
|
Tunnel(ctx context.Context, workspace, sandboxName string, port uint32, opts ...TunnelOption) (io.ReadWriteCloser, error)
|
|
}
|